Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Distorted display of db_input.php in debug mode  (Read 5662 times)

0 Members and 1 Guest are viewing this topic.

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Distorted display of db_input.php in debug mode
« on: September 03, 2004, 11:04:11 am »

I just noticed there's something fishy in db_input.php (at least when updating an album), when you have debug_mode enabled. Some volunteer to look into this?

Joachim
« Last Edit: September 12, 2004, 11:26:52 pm by Nibbler »
Logged

Nibbler

  • Guest
Re: Distoreted display of db_input.php in debug mode
« Reply #1 on: September 03, 2004, 11:50:47 am »

Looks intentional to me, the pageheader is deliberately not shown in debug mode.

Code: [Select]
        if ($CONFIG['debug_mode'] == 0) {
            pageheader($lang_db_input_php['alb_updated'], "<META http-equiv=\"refresh\" content=\"1;url=modifyalb.php?album=$aid\">");
        }
I'll go ahead and change it though if no one objects.

Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Distorted display of db_input.php in debug mode
« Reply #2 on: September 06, 2004, 09:50:48 am »

doesn't make sense to me to hide the pageheader, as the pageheader is being displayed on all other pages when in admin mode - might be a leftover from someone trying to fix something during development and forgetting to enable the pageheader again after the fix. I suggest putting the pageheader back into place. Please commit.

Joachim
Logged

Nibbler

  • Guest
Re: Distorted display of db_input.php in debug mode
« Reply #3 on: September 08, 2004, 11:29:04 pm »

Commited.

Also removed this block I noticed a few lines down...
Code: [Select]
        if (isset($CONFIG['debug_mode']) && ($CONFIG['debug_mode'] == 1)) {
            $queries[] = $query;
        }

...since query logging for the debug mode is automatically handled by cpg_db_query.
Logged
Pages: [1]   Go Up
 

Page created in 0.014 seconds with 18 queries.