forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Joachim Müller on September 03, 2004, 11:04:11 am

Title: Distorted display of db_input.php in debug mode
Post by: Joachim Müller on September 03, 2004, 11:04:11 am

I just noticed there's something fishy in db_input.php (at least when updating an album), when you have debug_mode enabled. Some volunteer to look into this?

Joachim

Title: Re: Distoreted display of db_input.php in debug mode
Post by: Nibbler on September 03, 2004, 11:50:47 am

Looks intentional to me, the pageheader is deliberately not shown in debug mode.

Code: [Select]

        if ($CONFIG['debug_mode'] == 0) {
            pageheader($lang_db_input_php['alb_updated'], "<META http-equiv=\"refresh\" content=\"1;url=modifyalb.php?album=$aid\">");
        }I'll go ahead and change it though if no one objects.

Title: Re: Distorted display of db_input.php in debug mode
Post by: Joachim Müller on September 06, 2004, 09:50:48 am

doesn't make sense to me to hide the pageheader, as the pageheader is being displayed on all other pages when in admin mode - might be a leftover from someone trying to fix something during development and forgetting to enable the pageheader again after the fix. I suggest putting the pageheader back into place. Please commit.

Joachim

Title: Re: Distorted display of db_input.php in debug mode
Post by: Nibbler on September 08, 2004, 11:29:04 pm

Commited.

Also removed this block I noticed a few lines down...

Code: [Select]

        if (isset($CONFIG['debug_mode']) && ($CONFIG['debug_mode'] == 1)) {
            $queries[] = $query;
        }

...since query logging for the debug mode is automatically handled by cpg_db_query.