Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: [bug] charset hardcoded in keyword_select.php and other files  (Read 5588 times)

0 Members and 1 Guest are viewing this topic.

Titooy

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Posts: 736
    • under construction...
[bug] charset hardcoded in keyword_select.php and other files
« on: December 15, 2005, 01:00:16 am »

I checked the devel too and these files still have "iso-8859-1" hardcoded

keyword_select.php
stat_details.php
xp_publish.php
include/mailer.inc.php
« Last Edit: May 18, 2006, 05:47:59 pm by Paver »
Logged

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1609
  • Paul V.
Re: [bug] charset hardcoded in keyword_select.php and other files
« Reply #1 on: May 18, 2006, 03:52:08 am »

Fixed & committed to stable & devel: keyword_select.php, stat_details.php, xp_publish.php.

I didn't want to play with include/mailer.inc.php since I cannot test it.
Logged

Nibbler

  • Guest
Re: [bug] charset hardcoded in keyword_select.php and other files
« Reply #2 on: May 18, 2006, 01:43:56 pm »

There is no need to change the charset in include/mailer.inc.php.
Logged

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1609
  • Paul V.
Re: [bug] charset hardcoded in keyword_select.php and other files
« Reply #3 on: May 18, 2006, 02:11:26 pm »

I was wondering if that were true.  The hardcoded iso-8859-1 is just the default it seems.  It isn't used because $charset is then pulled from the correct place in the object instance.  Correct?
Logged

Nibbler

  • Guest
Re: [bug] charset hardcoded in keyword_select.php and other files
« Reply #4 on: May 18, 2006, 04:15:25 pm »

Yeah, the proper charset is specified when we use the object.
Logged
Pages: [1]   Go Up
 

Page created in 0.019 seconds with 18 queries.