forum.coppermine-gallery.net

Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: Titooy on December 15, 2005, 01:00:16 am

Title: [bug] charset hardcoded in keyword_select.php and other files
Post by: Titooy on December 15, 2005, 01:00:16 am

I checked the devel too and these files still have "iso-8859-1" hardcoded

keyword_select.php
stat_details.php
xp_publish.php
include/mailer.inc.php

Title: Re: [bug] charset hardcoded in keyword_select.php and other files
Post by: Paver on May 18, 2006, 03:52:08 am

Fixed & committed to stable & devel: keyword_select.php, stat_details.php, xp_publish.php.

I didn't want to play with include/mailer.inc.php since I cannot test it.

Title: Re: [bug] charset hardcoded in keyword_select.php and other files
Post by: Nibbler on May 18, 2006, 01:43:56 pm

There is no need to change the charset in include/mailer.inc.php.

Title: Re: [bug] charset hardcoded in keyword_select.php and other files
Post by: Paver on May 18, 2006, 02:11:26 pm

I was wondering if that were true.  The hardcoded iso-8859-1 is just the default it seems.  It isn't used because $charset is then pulled from the correct place in the object instance.  Correct?

Title: Re: [bug] charset hardcoded in keyword_select.php and other files
Post by: Nibbler on May 18, 2006, 04:15:25 pm

Yeah, the proper charset is specified when we use the object.