It works on my site.
I'd like to see that in action. Please post a link and non-admin test user account if you're convinced that your suggestion
does work. I find it hard to believe though: in keyword_select.php, the target form field ID is hard-coded to "keywords". However, in editpics.php, the form fields don't have an ID and the name is "keywordsXXX" (where XXX corresponds to the PID).
I understand that your suggested code change displays the words "Keywords (separate with spaces) Insert from list" instead of just displaying the word "keywords". However, when clicking on the "insert from list" link and after the pop-up (keyword_select.php) shows up, nothing will happen when you click on individual keywords (i.e. the selected keywords will not appear within the form field in editpics.php). That's why I suggested that your suggestion is invalid, as it would introduce a feature that would not work. The changes I had to apply in cpg1.5.x are manifold, you're free to check out the SVN repository to find out what needs changing.
And I can explain my I called this one a bug. When one future/process/idea is broken (I speak about inserting from list), then from my opinion it is a bug.
A bug is something that is suppossed to work, but doesn't (or doesn't work in the expected way). Yours is an additional feature suggestion, not a bug. That's how we (the coppermine dev team members) define the word "bug" as well as all other similar projects that I'm aware of. If you have another definition for the word "bug", then fine. But on this board, please use the word "bug" as we define it. Shouting "bug" actually means accusing the developers to have made a mistake. Of course we make mistakes as well, that's why there are actual bugs. However, yours is not a genuine bug, but a missing feature.
Joachim