Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: 1 [2] 3   Go Down

Author Topic: Disable click setting stuck.  (Read 18256 times)

0 Members and 1 Guest are viewing this topic.

Zarsky

  • VIP
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 268
    • Zerr Family Website
Edit: Right click issues w/ 1.2RC2
« Reply #20 on: October 23, 2003, 10:54:48 pm »

its ok...someone will move it....this feature is buggy and will be removed or revised in the next version

Search the board, I know the fix is out there somewhere.
Logged
Read the Online DOCs, FAQ, and SEARCH the board BEFORE posting questions for help.

DefenceTalk.com

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 230
    • http://www.defencetalk.com
Edit: Right click issues w/ 1.2RC2
« Reply #21 on: October 24, 2003, 05:35:18 am »

Open "scripts.js" and edit this part down at the bottom, you can't miss it:

Code: [Select]

///////////////////////////////////
// disable right-click start///////
function click(e)
   {
   if (document.all)
   if (event.button == 2) return false;
   if(document.layers) if (e.which == 3) return false;
   }
function click2()
   {
   event.returnValue=false;return false;
   }
   if (document.layers)document.captureEvents(Event.MOUSEDOWN);
   document.onmousedown=click;
   document.oncontextmenu=click2;
   
// disable right-click end/////////
///////////////////////////////////


You will no longer have to worry about right clicks. :)
Logged
(http://www.defencetalk.com/pictures/signature_cpg.php)

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Edit: Right click issues w/ 1.2RC2
« Reply #22 on: October 24, 2003, 09:09:23 am »

no right-click modifications completely removed in the stable branch of the cvs - some dev team members please confirm this...

GauGau
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Edit: Right click issues w/ 1.2RC2
« Reply #23 on: October 24, 2003, 01:08:16 pm »

Confirmed - right click related code not seen in stable...
Logged
SANIsoft PHP applications for E Biz

ElkySS

  • Coppermine newbie
  • Offline Offline
  • Posts: 9
Edit: Right click issues w/ 1.2RC2
« Reply #24 on: October 26, 2003, 04:01:41 am »

for some reason I cannot right click on any part of my new gallery.  
both "Disable right-click on full-size pop-up (JavaScript - no foolproof method) " and "Disable right-click on all "regular" pages (JavaScript - no foolproof method) " are set to no but it still won't let me.  please help...

also the URL link that shows up in the pic info is worng.  it is showing up like "http://elkyss.servebeer.com/gallery//displayimage.php/?pos=-15989"
the / infront of the ? is messing it all up. I have tryed changing the "Target address for the 'See more pictures' link in e-cards " but it allways puts the / back in there.
Logged

hyperion

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Posts: 1317
  • - retired -
Edit: Right click issues w/ 1.2RC2
« Reply #25 on: October 26, 2003, 05:48:18 am »

You are suffering from two separate issues.  The right click feature is buggy, and the solution is noted in several posts.  Just search to find.


The second issue is new, and it will be investigated.
Logged
"Then, Fletch," that bright creature said to him, and the voice was very kind, "let's begin with level flight . . . ."

-Richard Bach, Jonathan Livingston Seagull

(http://www.mozilla.org/products/firefox/buttons/getfirefox_small.png)

ElkySS

  • Coppermine newbie
  • Offline Offline
  • Posts: 9
Edit: Right click issues w/ 1.2RC2
« Reply #26 on: October 26, 2003, 12:44:55 pm »

kewl thx.  I get my right click back and hope for a speedy solution to that trailing / thingy.

BTW Great work on the new gallery guys.  I am sure that Greg would be happy with the direction that things are going.
Logged

jacques_brelle

  • Coppermine newbie
  • Offline Offline
  • Posts: 19
Edit: Right click issues w/ 1.2RC2
« Reply #27 on: October 26, 2003, 03:10:54 pm »

Hi,
I had the same problem with the right click...
so I just modified the file "scripts.js" in the main directory deleting these lines :
///////////////////////////////////
// disable right-click start///////
function click(e)
   {
   if (document.all)
   if (event.button == 2) return false;
   if(document.layers) if (e.which == 3) return false;
   }
function click2()
   {
   event.returnValue=false;return false;
   }
   if (document.layers)document.captureEvents(Event.MOUSEDOWN);
   document.onmousedown=click;
   document.oncontextmenu=click2;
   
// disable right-click end/////////
///////////////////////////////////

and it works... I hope this is what you wanted.
 :mrgreen:
Logged

jdbaranger

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 169
    • Accro-Photo
Edit: Right click issues w/ 1.2RC2
« Reply #28 on: October 27, 2003, 10:48:49 am »

Hi,

For the // problem, in displayimage.php, search the line

Code: [Select]
$info['URL'] = '<a href=' . $CONFIG["ecards_more_pic_target"] . '/' . basename($_SERVER['PHP_SELF']) . "?pos=-$CURRENT_PIC_DATA[pid]" . ' >' . $CONFIG["ecards_more_pic_target"] . '/' . basename($_SERVER['PHP_SELF']) . "?pos=-$CURRENT_PIC_DATA[pid]" . '</a>';

and replace it with

Code: [Select]
$info['URL'] = '<a href=' . $CONFIG["ecards_more_pic_target"] . basename($_SERVER['PHP_SELF']) . "?pos=-$CURRENT_PIC_DATA[pid]" . ' >' . $CONFIG["ecards_more_pic_target"] . basename($_SERVER['PHP_SELF']) . "?pos=-$CURRENT_PIC_DATA[pid]" . '</a>';

Jean-Denis
Logged
Jean-Denis

ElkySS

  • Coppermine newbie
  • Offline Offline
  • Posts: 9
Edit: Right click issues w/ 1.2RC2
« Reply #29 on: October 28, 2003, 03:20:31 am »

You guys are great.  I actually found the right click code and just commented it out with a // rather than del it.  the the other code worked gread.  keep it up.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Edit: Right click issues w/ 1.2RC2
« Reply #30 on: October 31, 2003, 08:01:55 am »

As there are several threads dealing with the right-click issue I keep on merging them into one...

GauGau
Logged

Jeff Seabrook

  • Coppermine newbie
  • Offline Offline
  • Posts: 9
Edit: Right click issues w/ 1.2RC2
« Reply #31 on: November 12, 2003, 02:35:43 am »

i'd suggest making it an announcement?

change this:

///////////////////////////////////
// disable right-click start///////
function click(e)
{
if (document.all)
if (event.button == 2) return false;
if(document.layers) if (e.which == 3) return false;
}
function click2()
{
event.returnValue=false;return false;
}
if (document.layers)document.captureEvents(Event.MOUSEDOWN);
document.onmousedown=click;
document.oncontextmenu=click2;

// disable right-click end/////////
///////////////////////////////////


TO THIS:

///////////////////////////////////
// disable right-click start///////
//function click(e)
//{
//if (document.all)
//if (event.button == 2) return false;
//if(document.layers) if (e.which == 3) return false;
//}
//function click2()
//{
//event.returnValue=false;return false;
//}
//if (document.layers)document.captureEvents(Event.MOUSEDOWN);
//document.onmousedown=click;
//document.oncontextmenu=click2;

// disable right-click end/////////
///////////////////////////////////

this is in SCRIPTS.JS

commenting out this section fixes the right click bug, and can be removed alltogether.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Edit: Right click issues w/ 1.2RC2
« Reply #32 on: November 12, 2003, 08:39:31 am »

this is only half of the story, there are changes in other files as well.
Check the whole thread for an answer.
We're hopefully going to release cpg1.2.0final in the very near future (which will fix the issue), so please be patient for the moment...

GauGau
Logged

Cyberpawz

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 122
Edit: Right click issues w/ 1.2RC2
« Reply #33 on: November 13, 2003, 12:22:59 am »

I have solved the issue for the right click...

In the file SCRIPTS.JS

Change
/////////////////////////////////
// disable right-click start///////
function click(e)
{
if (document.all)
if (event.button == 2) return false;
if(document.layers) if (e.which == 3) return false;
}
function click2()
{
event.returnValue=false;return false;
}
if (document.layers)document.captureEvents(Event.MOUSEDOWN);
document.onmousedown=click;
document.oncontextmenu=click2;

// disable right-click end/////////
///////////////////////////////////


To This below.

///////////////////////////////////
// disable right-click start///////
//function click(e)
//{
//if (document.all)
//if (event.button == 2) return false;
//if(document.layers) if (e.which == 3) return false;
//}
//function click2()
//{
//event.returnValue=false;return false;
//}
//if (document.layers)document.captureEvents(Event.MOUSEDOWN);
//document.onmousedown=click;
//document.oncontextmenu=click2;

// disable right-click end/////////
///////////////////////////////////


THEN, and this is important...

Go to the functions.inc.php

Which is in the include folder of Coppermine, and look for this line.

        if ($CONFIG['disable_gallery_rightclick'] == 1)

Change this to

        if ($CONFIG['disable_gallery_rightclick'] == 0)

Save the page.

Reload the Coppermine page if you have it open, or open it, and right click away.  This works on my server..

http://www.cyberpawz.com/coppermine/displayimage.php?pid=1318&fullsize=1

Test here.

Cyberpawz
Logged

Cyberpawz

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 122
Edit: Right click issues w/ 1.2RC2
« Reply #34 on: November 13, 2003, 04:07:33 am »

The issue I am having now is that smaller images that don't need to be resized are not right clickable.

Small image

I have fixed the portion that is right clickable in the large images, but not the smaller, can someone please tell me how to get this portion of it fixed, so far I have found nothing really to state how to change it.

Cyberpawz
Logged

Cyberpawz

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Posts: 122
Edit: Right click issues w/ 1.2RC2
« Reply #35 on: November 14, 2003, 04:54:59 pm »

You know for future releases, programmer notes in the PR versions would be great for those who want to help...
Logged

bromide

  • Coppermine newbie
  • Offline Offline
  • Posts: 7
enable remote linking
« Reply #36 on: November 20, 2003, 12:03:20 am »

when using ie, my users can't right click the photo to get the url for remote linking.  i dont mind them remote linking, so how do they get around the java script?  thanks!!!!
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Edit: Right click issues w/ 1.2RC2
« Reply #37 on: November 20, 2003, 07:26:45 am »

@bromide: this has been answered in detail in this thread (I moved your posting to it for this very reason). Upgrade to cpg1.2.0final and you should be fine, the no-right-click feature has been removed from final (because it was buggy).

GauGau

P.S. searching before posting would have helped
Logged

Digital Pea

  • Coppermine newbie
  • Offline Offline
  • Posts: 2
Uh-oh!
« Reply #38 on: February 07, 2004, 07:47:21 pm »

You're all going to throw rotten eggs at me (http://www.photo-art-gallery.com/phpbb/images/smiles/paranoid.gif)... but... erm.... well....... I WANT DISABLE RIGHT CLICK!! (http://www.photo-art-gallery.com/phpbb/images/smiles/ma.gif)

It's all well and good peeps telling me "if you don't want images nicked then don't put them on the net", but I sell the damn things! They are my livelihood, as I am a photographer, so how am I supposed to display my wares if I don't put them up to view?!  (http://www.photo-art-gallery.com/phpbb/images/smiles/u_nut.gif)

The coppermine album is the best for my needs so far, having given up on alternatives. But, I really want a disable right click option.... watermarking ruins the pics, and digimark only tags them, neither these options stop copying in the first place.
(http://www.photo-art-gallery.com/phpbb/images/smiles/hob.gif)
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Edit: Right click issues w/ 1.2RC2
« Reply #39 on: February 07, 2004, 07:54:52 pm »

The hack has been posted by gaugau, here

But as he says, anyone with any sense can still get them.
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here
Pages: 1 [2] 3   Go Up
 

Page created in 0.025 seconds with 19 queries.