Advanced search  

News:

CPG Release 1.6.26
Correct PHP8.2 issues with user and language managers.
Additional fixes for PHP 8.2
Correct PHP8 error with SMF 2.0 bridge.
Correct IPTC supplimental category parsing.
Download and info HERE

Pages: [1]   Go Down

Author Topic: showdoc.php variables question  (Read 5978 times)

0 Members and 1 Guest are viewing this topic.

kegobeer

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 4637
  • Beer - it does a body good!
    • The Kazebeer Family Website
showdoc.php variables question
« on: September 12, 2004, 03:48:44 am »

There are a bunch of unset variables requested:

$remove_head = $_REQUEST['remove_head'];
$remove_stylesheet = $_REQUEST['remove_stylesheet'];
$remove_to_top = $_REQUEST['top'];
$header = $_REQUEST['h'];
$text = $_REQUEST['t'];
$style = $_REQUEST['style'];
$close = $_REQUEST['close'];
$base = $_REQUEST['base'];

And then a few if-then statements for some of them.  While it doesn't cause any problems (unless you have error reporting turned on in php) I was wondering if this for future use, or maybe no longer used at all.
« Last Edit: October 04, 2004, 07:44:32 am by GauGau »
Logged
Do not send me a private message unless I ask for one.  Make your post public so everyone can benefit.

There are no stupid questions
But there are a LOT of inquisitive idiots

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: showdoc.php variables question
« Reply #1 on: September 12, 2004, 11:03:27 am »

I only introduced showdoc.php a short while ago, will have to look into this. I was planning to add more functionality by implementing code related to those vars. I will do a clean-up of the code (assigning this task to me).

Moving this thread to bugs section, so I won't forget about it.

Joachim
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: showdoc.php variables question
« Reply #2 on: October 04, 2004, 07:44:19 am »

you were right, so I removed the unneeded vars from showdoc.php.

Joachim
Logged

kegobeer

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 4637
  • Beer - it does a body good!
    • The Kazebeer Family Website
Re: showdoc.php variables question
« Reply #3 on: October 06, 2004, 02:09:35 am »

Has this been committed to devel yet?  I still get the same undefined index errors.
Logged
Do not send me a private message unless I ask for one.  Make your post public so everyone can benefit.

There are no stupid questions
But there are a LOT of inquisitive idiots

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: showdoc.php variables question
« Reply #4 on: October 06, 2004, 08:39:37 am »

OK, finally even I got the point  ;)
I added a check for existance for every var that might get used. Committed to devel.

Joachim
Logged
Pages: [1]   Go Up
 

Page created in 0.023 seconds with 18 queries.