I fixed the background showing through in Firefox, Opera, and IE 6 for Rainy_Day in 1.4devel
I tested this fix with album list thumbnails set at 100, 75, and 50.
I did see some odd heights that were throwing off my measurements that I tracked down to height
differences returned by two function in index.php.
In these tests Album List Thumbnails were set to 50 in the config.
theme_display_album_list_cat returned a height 1 pixel taller than theme_display_album_list
<img src="albums/Bruce/Strip%20Wood%20Floors/thumb_WIND.JPG" class="image" height="51" border="0" alt="WIND.JPG" />
theme_display_album_list
<img src="albums/Bruce/Plank%20Wood%20Floors/thumb_WMASTM.JPG" class="image" height="50" border="0" alt="WMASTM.JPG" />
My html is set to account for the difference at 50, but at 75 they were 1 pixel off, at 100 the were the same again.
I think this has been happening all along, and its just because I was counting every pixel to get my fix to look right
that I caught it. Regardless of picture size I don't think those two functions should return anything other than what's in the system config.
But I couldn't track it down.
Empty Cell Fix for Rainy_Day, the cvs version as of 12/2/04):
Need to add a class to the css, I thought this method was peferrable to burying a +7 in the code somewhere when calculating height.
If a user changes their .image class it will throw off the height needed for spacer.gif.
.blank_image {
/* Margin should = .image (margin+border-width) */
border:0;
margin: 3px;
}
Everything else is in theme.php
In function theme_display_album_list_cat AND function theme_display_album_list find
$params = array('{COL_WIDTH}' => $column_width);
$empty_cell = template_eval($empty_cell, $params);
Replace with
$params = array('{COL_WIDTH}' => $column_width,
'{SPACER_HEIGHT}' => $CONFIG['alb_list_thumb_size']
);
$empty_cell = template_eval($empty_cell, $params);
Replace the empty_cell section starting at line 294
<!-- BEGIN empty_cell -->
<td width="{COL_WIDTH}%" valign="top">
<table width="100%" cellspacing="0" cellpadding="0">
<tr>
<td height="1" valign="top" class="tableh2">
</td>
</tr>
<tr>
<td>
<img src="images/spacer.gif" width="1" height="1" border="0" alt="" /><br />
</td>
</tr>
<tr>
<td align="center" class="thumbnails">
<img src="images/spacer.gif" width="1" height="2" border="0" alt="" /><br />
<img src="images/spacer.gif" width="1" height="{SPACER_HEIGHT}" class="blank_image" alt="" /><br />
</td>
</tr>
</table>
</td>
<!-- END empty_cell -->
Replace the c_empty_cell section starting at line 404
<!-- BEGIN c_empty_cell -->
<td width="{COL_WIDTH}%" valign="top">
<table width="100%" cellspacing="0" cellpadding="0">
<tr>
<td height="1" valign="top" class="tableh2">
</td>
</tr>
<tr>
<td>
<img src="images/spacer.gif" width="1" height="1" border="0" alt="" /><br />
</td>
</tr>
<tr>
<td align="center" class="thumbnails">
<img src="images/spacer.gif" width="1" height="1" border="0" alt="" /><br />
<img src="images/spacer.gif" width="1" height="{SPACER_HEIGHT}" class="blank_image" alt="" /><br />
</td>
</tr>
</table>
</td>
<!-- END c_empty_cell -->
I know this may be an ugly fix, but at least its a starting point.