Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Opening pictures in new browser window  (Read 3744 times)

0 Members and 1 Guest are viewing this topic.

MilchstrabeStern

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 23
Opening pictures in new browser window
« on: September 07, 2004, 03:16:33 am »

When you click on a picture, I want it to appear in a new window because the picture will only fit with my design if there 360 px wide, and thats small, so how can i configure it so it opens them up in a seperate window?
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Opening pictures in new browser window
« Reply #1 on: September 07, 2004, 07:42:00 am »

go through the coppermine code with a search tool (the one of your OS will do), look for "displayimage.php", edit the files your search comes up with and add target="_blank" as an attribute to the links you find.
This is not recommended though, with most modern browsers having some sort of pop-up blocker for valid reasons. Personally, I hate it when new browser windows get launched with my approval, I'd be away from your site very fast. I especially can't see any reason to open new winows if you have pics with very low dimensions, as they go perfect with your style without messing up the design.

Joachim

P.S. Please stop posting support requests on the general discussion board. These kind of questions are suppossed to go into the proper support board. Since you're using cpg1.3.2 (as I remember from previous posts), I have moved your thread accordingly.
Logged

cryogenic

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 79
    • the cynic says...
Re: Opening pictures in new browser window
« Reply #2 on: September 13, 2004, 02:20:10 pm »

Even worse, that will invalidate all the hard work the devs are putting into making CPG xhtml compliant. I'm in agreement that "target=_blank" should more or less never be used. If I want something in a new window, I'll make it open in a new window. Don't make the decision for me.  :)
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Opening pictures in new browser window
« Reply #3 on: September 14, 2004, 08:57:32 am »

we already decided that in cpg1.4.x, all external links will look like this: <a href="external_page" title="sometitle" rel="external"> instead of <a href="external_page" target="_blank">. It will be up to the user then to add some JavaScript/DHTML bits to make them open in a new window - by default, they will open in the same window.
For cpg1.3.x, use the method I described.

Joachim
Logged

cryogenic

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 79
    • the cynic says...
Re: Opening pictures in new browser window
« Reply #4 on: September 14, 2004, 09:06:04 am »

That's a great idea in adding the rel=external to the links. I haven't looked through the 1.4 dev code all that thoroughly at the moment, but is it present in cvs yet? (I just updated today--found another bug, but feel as though I'm annoying you guys reporting bugs since I'm not a dev)
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Opening pictures in new browser window
« Reply #5 on: September 15, 2004, 09:05:20 am »

isn't in the cvs yet, we just agreed to have it that way in the non-public dev board.
The problem with bug reports for the devel version is that you can't actually see what features is being worked on. Some have been flagged with "I'm working on this issue" by some team member in the dev board - if you come up with a bug report on that particular issue, it's not very helpfull. However, we don't want to scare you away, as other bug reports may be very helpfull, correcting oversights or plain bugs that haven't been discovered yet. We appreciate your readiness to help very much, but discussing cpg1.4(devel) things on the regular board just stirrs to much distraction for "regular" users imo.
Here's my recommendation: we'll release a non-public beta package to some groups of users and give them access to the cpg1.4 bugs board. The pre-release will go to the groups "Translator", "Contributor" and "VIP". Easiest way to get access to the board in question and the pre-release would be to become a member of those groups. There are several ways to get promoted to "Contributor" status: post a theme, a hack/mod, continuously do support work etc.
What do you think? ;)

Joachim
Logged

cryogenic

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 79
    • the cynic says...
Re: Opening pictures in new browser window
« Reply #6 on: September 21, 2004, 11:58:07 pm »

Well, given that I don't code, I won't be posting any hacks or mods anytime soon. All I can hope for is just be of assistance to other users on the board. :P
Logged
Pages: [1]   Go Up
 

Page created in 0.022 seconds with 20 queries.