Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: 1 2 3 [4] 5 6 7 8   Go Down

Author Topic: New CSS based XHTML compliant themes  (Read 103739 times)

0 Members and 1 Guest are viewing this topic.

pjoern

  • Coppermine newbie
  • Offline Offline
  • Posts: 9
    • Danish page about Miskito Indians in Prinzapolka, Nicaragua
Re: New CSS based XHTML compliant themes
« Reply #60 on: September 09, 2004, 08:02:12 am »

Hi,
in another thread, Tarique Sani wrote (about theme Reynolds and standards compliancy):

Quote
Like Gaugau said - the theme is - the code for 1.3.2 is still not
See the latest one at http://validator.w3.org/check?uri=http%3A%2F%2Ftariquesani.net%2Findex.php
You will need the code from CVS to make it work

Wow, it is the first time I have seen a CPG site which validates. Congratulations! Could you perhaps be a little specific explaining which files from the CVS I would need to implement a standard compliant CPG theme in my site?

Thanks in advance
Jĝrgen Peter Kjeldsen
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: New CSS based XHTML compliant themes
« Reply #61 on: September 09, 2004, 09:01:16 am »

The files which need to be changed are index.php, thumbnail.php, displayimage.php and functions.inc.php BUT if you take just these files from the CVS and not the entire package - your install of coppermine is likely to break.

If you are comfortable with Alpha code then you can download the entire CVS devel and run the update.php. Currently the devs are not aware of any show stopping bugs in the CVS devel, so that way it is almost Beta...
Logged
SANIsoft PHP applications for E Biz

pjoern

  • Coppermine newbie
  • Offline Offline
  • Posts: 9
    • Danish page about Miskito Indians in Prinzapolka, Nicaragua
Re: New CSS based XHTML compliant themes
« Reply #62 on: September 09, 2004, 09:22:56 am »

If you are comfortable with Alpha code then you can download the entire CVS devel and run the update.php. Currently the devs are not aware of any show stopping bugs in the CVS devel, so that way it is almost Beta...

Well, as I am not at all familiar with Alpha code, I think I will follow the advice in your signature: "Don't! just Don't!!"

I'll be patient and wait till there will be an official Beta... When do you expect that to happen?

Thanks for your answer, anyway!

Jorgen Peter Kjeldsen
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: New CSS based XHTML compliant themes
« Reply #63 on: September 09, 2004, 09:52:11 am »

When do you expect that to happen?
Well the official line is "When it is ready" but a Beta can be expected in a couple of weeks
Logged
SANIsoft PHP applications for E Biz

CarLBanks

  • Coppermine newbie
  • Offline Offline
  • Posts: 8
Re: New CSS based XHTML compliant themes
« Reply #64 on: September 10, 2004, 06:06:10 pm »

When I try to uncompress the Reynolds theme, it only gives me three images.
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: New CSS based XHTML compliant themes
« Reply #65 on: September 10, 2004, 07:19:44 pm »

Where did you get the download from.  It sounds as if it is corrupt, please download a new copy.
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

cryogenic

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 79
    • the cynic says...
Re: New CSS based XHTML compliant themes
« Reply #66 on: September 13, 2004, 09:02:03 am »

If you are comfortable with Alpha code then you can download the entire CVS devel and run the update.php. Currently the devs are not aware of any show stopping bugs in the CVS devel, so that way it is almost Beta...

Well, as I am not at all familiar with Alpha code, I think I will follow the advice in your signature: "Don't! just Don't!!"

I'll be patient and wait till there will be an official Beta... When do you expect that to happen?

Thanks for your answer, anyway!

Jorgen Peter Kjeldsen

Don't know if this will make you feel any better, but I'm quite the newbie myself and my page is based around 1.4 code and validates fine. I took the long route and actually downloaded the CVS code locally and then re-uploaded it to my server. Seems to work ok and validates fine. I'm using the reynolds theme and have been for a good while now. Initially it wouldn't validate but I debugged a few errors to make it validate and passed it along to Tarique to help out some. Needless to say, all I did was download the whole tree (make sure and get the SQL folder!!) and then ran the update.php file and it did everything for me. If you want to take a look, my gallery is @ http://cryogenic.doesntexist.org/gallery :)

Also, Tarique, I'm having an issue with 2bornot2b on the config page. The headers/category titles for each section are black on a charcoal background (though the text for each option is correct). I'm going to try and figure it out myself in the meantime, but if you have any suggestions on how to correct it, it would be much appreciated.

Edit: fixed! tableh2 class needs "color" changed from #000000 to anything lighter.. (e.g. #ffffff). Also, 1.5em is, in my opinion, entirely too large. I'd suggest something more moderate like 1.3. Reynolds is set @ 1em, for example. I've attatched the corrected css file.
« Last Edit: September 13, 2004, 12:08:20 pm by cryogenic »
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: New CSS based XHTML compliant themes
« Reply #67 on: September 13, 2004, 09:49:07 am »

Grab the new 2bornot2b CSS from my site
Logged
SANIsoft PHP applications for E Biz

cryogenic

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 79
    • the cynic says...
Re: New CSS based XHTML compliant themes
« Reply #68 on: September 13, 2004, 09:57:18 am »

I corrected it myself... and I forgot to attatch the corrected one, but it seems to be a moot point now.

EDIT: Tarique, you should edit the template.html near the bottom and change the xhtml 1.0 compliant banner to check referer instead of your URL. You inadvertently left your own URL hard-coded into the button link. The CSS button links properly, however.
« Last Edit: September 13, 2004, 12:07:08 pm by cryogenic »
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: New CSS based XHTML compliant themes
« Reply #69 on: September 13, 2004, 02:57:47 pm »

2bornot2b is due for a huge clean-up - yes will keep your point in mind
Logged
SANIsoft PHP applications for E Biz

cryogenic

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 79
    • the cynic says...
Re: New CSS based XHTML compliant themes
« Reply #70 on: September 14, 2004, 08:22:04 am »

2bornot2b is due for a huge clean-up - yes will keep your point in mind
cleanup as in how? I'm tempted to go through and remove all the double-spacing from the css file itself. I can't really see much of anything else that is in dire need of attention.

EDIT: I got bored and used JOE to go through and remove all the extra whitespace in style.css for 2bornot2b and while it looks better, it only saved 1KB in file size. If you want the file, I'll provide it... Basically, what I've done is single-spaced between classes and taken out all the line spacing between elements of the classes (e.g. background: and the like).
« Last Edit: September 14, 2004, 08:50:51 am by cryogenic »
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: New CSS based XHTML compliant themes
« Reply #71 on: September 14, 2004, 10:10:16 am »

You mean I have already removed all those duplicate classes and IDs scattered .... must have, now to remove the hard coded links and add the variable for language and theme selection ;)
Logged
SANIsoft PHP applications for E Biz

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: New CSS based XHTML compliant themes
« Reply #72 on: September 14, 2004, 12:29:58 pm »

Tarique,

I found that when using reynolds in admin mode the content is stretched and impedes the menu.

I have fixed this myself by placing the album admin menu in a new row under the album thumbs/description cells.
I did it by changing this code (twice);

Code: [Select]
<table width="100%" cellspacing="0" cellpadding="0">
        <tr>
                <td colspan="3" height="1" valign="top" class="tableh2">
                        <a href="{ALB_LINK_TGT}" class="alblink"><b>{ALBUM_TITLE}</b></a>
                </td>
        </tr>
        <tr>
                <td align="center" height="100%" valign="middle" class="thumbnails">
                        <a href="{ALB_LINK_TGT}" class="albums">{ALB_LINK_PIC}<br /></a>
                </td>
                <td width="100%" height="100%" valign="top" class="tableb_compact">
                        {ADMIN_MENU}
                        <p>{ALB_DESC}</p>
                        <p class="album_stat">{ALB_INFOS}</p>
                </td>
        </tr>
        </table>

To this;

Code: [Select]
<table width="100%" cellspacing="0" cellpadding="0">
        <tr>
                <td colspan="3" height="1" valign="top" class="tableh2">
                        <a href="{ALB_LINK_TGT}" class="alblink"><b>{ALBUM_TITLE}</b></a>
                </td>
        </tr>
        <tr>
                <td align="center" height="100%" valign="middle" class="thumbnails">
                        <a href="{ALB_LINK_TGT}" class="albums">{ALB_LINK_PIC}<br /></a>
                </td>
                <td width="100%" height="100%" valign="top" class="tableb_compact">
                       
                        <p>{ALB_DESC}</p>
                        <p class="album_stat">{ALB_INFOS}</p>
                </td>
        </tr>
<tr><td colspan="2" align="center" height="100%" valign="middle" class="thumbnails">{ADMIN_MENU}</td></tr>
        </table>
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

cryogenic

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 79
    • the cynic says...
Re: New CSS based XHTML compliant themes
« Reply #73 on: September 14, 2004, 02:25:47 pm »

I actually noticed the same thing, but never really bothered to fix it :P  I prefer the darker colored theme anyway and it seems to work perfectly fine on my end so far.

and @Tarique, the duplicate classes appear to be gone from what I can telll. With the whitespace removed, the css file checks in at 11KB.
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: New CSS based XHTML compliant themes
« Reply #74 on: September 14, 2004, 02:31:18 pm »

Works fine on Mozilla for me - please post more details
Logged
SANIsoft PHP applications for E Biz

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: New CSS based XHTML compliant themes
« Reply #75 on: September 14, 2004, 04:21:42 pm »

Hi tarique,

I noticed this when more than 2 columns of albums are shown, or when viewing at a lower resolution, say 800x600.

It is the index page, and cat index page this is noticable on, not the config page.  I accept that this theme is designed for use at 1024 or higher, and with just 2 columns, but as you know there will always be users who choose to do it differently, and then moan.

This is just a cosmetic fix for those occassions.  Does the 'colspan' create a problem with validating?
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

cryogenic

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 79
    • the cynic says...
Re: New CSS based XHTML compliant themes
« Reply #76 on: September 14, 2004, 11:40:50 pm »

One other suggestion for 2bornot2b. under the class .debug_text, color should be changed from #000000 to #ffffff as it's completely unreadable with the color set as 000000 (black). I have debug mode turned on in admin mode since I'm testing 1.4 and I had to change the color in the css in order to make it readable :P
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: New CSS based XHTML compliant themes
« Reply #77 on: September 15, 2004, 06:53:07 am »

@casper - at lower resolutions too many things break in reynolds anyways... So I am not in favour of just adding colspan when we cannot fix other stuff like the thumbnail display anyways
@cryogenic - will keep in mind .debug_text color when I fix 2bornot2b
Logged
SANIsoft PHP applications for E Biz

xleyba

  • Coppermine newbie
  • Offline Offline
  • Posts: 6
Re: New CSS based XHTML compliant themes
« Reply #78 on: September 15, 2004, 10:38:05 am »

Hi

Some questions:

1 - Which are the xhtml compliant themes ? Where could I found a list ?

2 - New themes are tableless or Coppermine still comes with html tables inside php code ?


Thanks in advance

Javier
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: New CSS based XHTML compliant themes
« Reply #79 on: September 15, 2004, 11:00:12 am »

You will find out if you read this thread from the very beginning to the very end. The themes mentioned here are both experimental, and the current cpg release version (cpg1.3.2) is not xhtml compliant (but the next version will be). Coppermine (any version)  is however not completely tableless.

Joachim
Logged
Pages: 1 2 3 [4] 5 6 7 8   Go Up
 

Page created in 0.032 seconds with 22 queries.