Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: 1 [2]   Go Down

Author Topic: Improper location of images after hitting next button when viewing album.  (Read 17572 times)

0 Members and 1 Guest are viewing this topic.

willstein

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 120
    • mansei
Re: Improper location of images after hitting next button when viewing album.
« Reply #20 on: October 07, 2005, 01:52:03 am »

making the anchors work on the thumbnails.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Improper location of images after hitting next button when viewing album.
« Reply #21 on: October 07, 2005, 08:15:11 am »

you'd have to come up with a mod similar to the one from mstralka above: the links that send people to the thumbnail page need to have the anchor too.
Logged

willstein

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 120
    • mansei
Re: Improper location of images after hitting next button when viewing album.
« Reply #22 on: October 07, 2005, 08:47:26 pm »

hmm.

following mstralka's original mod, I looked in displayimage.php along with thumbnails.php and theme.php.
all I could come up with is, on displayimage.php around line 92.

Code: [Select]
$thumb_tgt = "thumbnails.php?album=$album$cat_link&page=$page#picture";
But it hasn't worked. Any ideas?
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Improper location of images after hitting next button when viewing album.
« Reply #23 on: October 08, 2005, 07:13:47 am »

there are other places as well, e.g. in include/functions.inc.php, find
Code: [Select]
$link = "<a href=\"thumbnails.php?album=".$CURRENT_ALBUM_DATA['aid']."\">".$CURRENT_ALBUM_DATA['title']."</a>";
Logged

willstein

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 120
    • mansei
Re: Improper location of images after hitting next button when viewing album.
« Reply #24 on: October 08, 2005, 06:14:41 pm »

Well, after playing with that line trying to add #picture . . . I couldnt figure it out.
Then I completely tested that line, turning it into this:
Code: [Select]
$link = "<a href=\"nofile.php?noalbum=".$CURRENT_ALBUM_DATA['aid']."\">".$CURRENT_ALBUM_DATA['title']."</a>";Notice:
Code: [Select]
nofile.php?noalbum
and it had no effect on my gallery. (yes, i checked to make sure I uploaded it)

could it be somewhere else?
Logged

willstein

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 120
    • mansei
Re: Improper location of images after hitting next button when viewing album.
« Reply #25 on: October 10, 2005, 12:39:32 am »

any other suggestions?
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Improper location of images after hitting next button when viewing album.
« Reply #26 on: October 10, 2005, 08:37:59 am »

Code: [Select]
$link = "<a href=\"thumbnails.php?album=".$CURRENT_ALBUM_DATA['aid']."#picture\">".$CURRENT_ALBUM_DATA['title']."</a>";doesn't work as expected?
Logged

willstein

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 120
    • mansei
Re: Improper location of images after hitting next button when viewing album.
« Reply #27 on: October 10, 2005, 07:44:52 pm »

I tried that in the past, and tried again recently, and it doesnt seem to change the URL. (I assume if the URL does not have #picture, then it won't output)
Is it possible that "aid" is not set?
Logged

Stramm

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 6006
    • Bettis Wollwelt
Re: Improper location of images after hitting next button when viewing album.
« Reply #28 on: October 10, 2005, 11:06:17 pm »

I don't get it. What's the point in moving rating and comment box above the pic and then pacing the anchor in a way so that no one would see these page parts (in case of using prev/ next)?? Usually you scroll the page down and not up. And when I use the prev next buttons I'd like to see these buttons on the next page as well and not having to scroll up for this ??? Feels solmehow upside down
Just wondering cause this is a totally different approch of a navigation... far away from any standards

willstein

  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 120
    • mansei
Re: Improper location of images after hitting next button when viewing album.
« Reply #29 on: October 11, 2005, 12:05:48 am »

perhaps just personal preference.
Logged
Pages: 1 [2]   Go Up
 

Page created in 0.019 seconds with 19 queries.