Advanced search  

News:

CPG Release 1.6.26
Correct PHP8.2 issues with user and language managers.
Additional fixes for PHP 8.2
Correct PHP8 error with SMF 2.0 bridge.
Correct IPTC supplimental category parsing.
Download and info HERE

Pages: [1]   Go Down

Author Topic: Possible mistake in lang file?  (Read 4507 times)

0 Members and 1 Guest are viewing this topic.

tk_jkpg

  • Coppermine newbie
  • Offline Offline
  • Gender: Male
  • Posts: 1
Possible mistake in lang file?
« on: June 23, 2004, 06:36:17 pm »

While working on swedish translation for 1.3.0 i have found possible error. I think that the variable 'err_fsize_too_large' should warn about filesize and not image dimensions as both english and swedish(1.2) do. It seems to be confused/mixed with 'err_imgsize_too_large' that should be about image dimensions. Se text below.

/Tommy


Some text from the english.php file:
// ------------------------------------------------------------------------- //
// File db_input.php
// ------------------------------------------------------------------------- //

if (defined('DB_INPUT_PHP')) $lang_db_input_php = array(
.
.
  'err_fsize_too_large' => 'The size of file you have uploaded is too large (maximum allowed is %s x %s) !', //cpg1.3.0
  'err_imgsize_too_large' => 'The size of the file you have uploaded is too large (maximum allowed is %s KB) !',
.
.
Logged

Nibbler

  • Guest
Re: Possible mistake in lang file?
« Reply #1 on: June 23, 2004, 07:38:54 pm »

I agree the names are a little ambigous, but the error messages are correct.
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: Possible mistake in lang file?
« Reply #2 on: June 23, 2004, 07:49:19 pm »

I think the error messages are wrong.
Too large filesize ends '%s x %s'
Too large pixel ends '%s kb'

BUT, when are these error messages used.  upload.php uses the (correct) messages from lang_upload not lang_db_input
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Nibbler

  • Guest
Re: Possible mistake in lang file?
« Reply #3 on: June 23, 2004, 08:06:50 pm »

True, these language entries are made redundant by the new upload system.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Possible mistake in lang file?
« Reply #4 on: June 25, 2004, 01:15:40 am »

I suggest we keep them for the moment, I'll flag them in the cvs for deletion once upload.php has gone through all necessary changes.

GauGau
Logged
Pages: [1]   Go Up
 

Page created in 0.031 seconds with 19 queries.