Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: XHTML bug in functions.inc.php  (Read 9888 times)

0 Members and 1 Guest are viewing this topic.

Seth

  • Coppermine newbie
  • Offline Offline
  • Posts: 11
XHTML bug in functions.inc.php
« on: June 15, 2004, 03:22:32 am »

Not fatal, but it keeps the page from validating (as I discovered in my quest to get CopperMine to generate XHTML 1.1 Strict output :p)

Around line 1039, find
Code: [Select]
$image_size['geom'] = '" height="'.$image_size['height'].'"';change to
Code: [Select]
$image_size['geom'] = 'height="'.$image_size['height'].'"';
« Last Edit: June 15, 2004, 04:46:10 am by Tarique Sani »
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: Bug in functions.inc.php
« Reply #1 on: June 15, 2004, 04:45:51 am »

Thanks I have fixed that one - see my site http://tariquesani.net

The index and thumbnail validate as valid XHTML 1.0 Transitional am working on displayimage - I can give you those files which are Valid

BUT there are tons of errors in several themes which prevent validation - we would be very greatful if you can contribute a theme which is a valid XHTML 1.0 transitional

Oh! BTW how good are you with CSS - I also have a tableless theme (yes it can be done) which is extremely ugly in IE - can you help?

Logged
SANIsoft PHP applications for E Biz

Seth

  • Coppermine newbie
  • Offline Offline
  • Posts: 11
Re: XHTML bug in functions.inc.php
« Reply #2 on: June 15, 2004, 05:27:44 am »

Well, http://photos.sethkinast.com is now about 90% valid... still working on it. I guess I'll let that speak for my CSS ability; I'm competent, but not spectacular.
Logged

rrosalion

  • Coppermine newbie
  • Offline Offline
  • Gender: Male
  • Posts: 7
    • sobriquet.net
Re: XHTML bug in functions.inc.php
« Reply #3 on: June 27, 2004, 03:19:04 pm »

Has anyone succeeded in making an XHTML complient coppermine yet? Are they making their mods publicly available?
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: XHTML bug in functions.inc.php
« Reply #4 on: June 27, 2004, 04:01:50 pm »

checkout the necessary files from CVS - it has been committed to the devel module. However do it only if you are comfortable with CVS and don't mind the fact that the devel CVS versions are unsupported...
« Last Edit: June 27, 2004, 04:07:35 pm by Tarique Sani »
Logged
SANIsoft PHP applications for E Biz

Rodinou

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 346
  • Tournicoti, Tournicota
    • http://www.sortons.net
Re: XHTML bug in functions.inc.php
« Reply #5 on: June 27, 2004, 05:41:18 pm »

Tarique, I'm ready to help you to create Tableless theme ... even if all is tableless :)

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: XHTML bug in functions.inc.php
« Reply #6 on: June 27, 2004, 05:58:59 pm »

Tarique, I'm ready to help you to create Tableless theme ... even if all is tableless :)
OK soon I will upload a 100% table-less theme - just that it is very ugly to look at may be you can spend some time on the CSS and get it right.

Meanwhile - did you take a look at the theme with drop-down menu in the mods section?
Logged
SANIsoft PHP applications for E Biz

Rodinou

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 346
  • Tournicoti, Tournicota
    • http://www.sortons.net
Re: XHTML bug in functions.inc.php
« Reply #7 on: July 03, 2004, 03:25:29 am »

Waouhh !! I have looked the Drop Down DHTML Menu ...

You are fool !! :) too heavy : indeed, with CSS2 & XHTML, you can create simply menus very easy to customise with php ... take a look, for example, at http://www.csscreator.com/menu/multimenu.php

Very easy to understand, and a LITTLE JS ...

Send me a PM to look your tableless version ... I have a lot of hacks to create some popup layers without dhtml, javascript ... only with CSS (for example)

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: XHTML bug in functions.inc.php
« Reply #8 on: July 03, 2004, 04:27:11 am »

You are fool !! :) too heavy
I don't think in any language the above translates into a kind statement, I am well aware of the CSS based drop down menus and the limitations and advantages. I am no longer interested in sharing the tableless theme with you.
Logged
SANIsoft PHP applications for E Biz

Rodinou

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 346
  • Tournicoti, Tournicota
    • http://www.sortons.net
Re: XHTML bug in functions.inc.php
« Reply #9 on: July 03, 2004, 12:34:12 pm »

You are fool !! :) too heavy
I don't think in any language the above translates into a kind statement, I am well aware of the CSS based drop down menus and the limitations and advantages. I am no longer interested in sharing the tableless theme with you.

I don't understand why you take "bad" my reflexion. The CSS Drop Down Menu is very compatible with about 90% of the new browsers (Mozilla, Safari, Camino ...) and very easy to customize for newbies (instead of the JS).

It would be pitty not to work together in a Tableless theme, 'cause it was my wish to see Coppermine in CSS/XHTML since the beginning :(

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: XHTML bug in functions.inc.php
« Reply #10 on: July 03, 2004, 12:44:20 pm »

I don't understand why you take "bad" my reflexion.
Language barriers OR no language barriers - Calling anyone a fool is RUDE!!

You have been warned about this behaviour in the past - do it once more and you will be banned
Logged
SANIsoft PHP applications for E Biz

Rodinou

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 346
  • Tournicoti, Tournicota
    • http://www.sortons.net
Re: XHTML bug in functions.inc.php
« Reply #11 on: July 03, 2004, 01:39:10 pm »

Tarique, I think you have not the "tone" : visibly you have a "tooth" against me

When I say "fool", there is nothing bad : just (or I think, if it's not the case, say me), I think DHTML for some things (drop down menus, for example) is no longer the best solution : that's all. Like dhtml popup for infos, One CSS line = 80 JS lines ...

My apologizes if I hurt you.

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: XHTML bug in functions.inc.php
« Reply #12 on: July 03, 2004, 03:16:25 pm »

@ Rodinou,

I agree with Tarique, there is no excuse for calling someone a fool on here.  Just in case you don't fully understand what you are saying, it is the same as calling him an idiot, or dummkopf, or bébête, or adoquín, or tolo, or idiota.

Got the idea?

If you had called me it, I would also have a "tooth" against you (whatever that means).
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Rodinou

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 346
  • Tournicoti, Tournicota
    • http://www.sortons.net
Re: XHTML bug in functions.inc.php
« Reply #13 on: July 03, 2004, 03:19:51 pm »

Ok I understand : so my APOLOGIZES (there is an ABYSS between you have understood and I have thought ...)
Pages: [1]   Go Up
 

Page created in 0.023 seconds with 19 queries.