Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: I see spots before my eyes. Loosing the bullet points  (Read 6274 times)

0 Members and 1 Guest are viewing this topic.

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4679
    • Windsurf.me
I see spots before my eyes. Loosing the bullet points
« on: March 18, 2010, 07:15:07 pm »

I seem to be unable to find out how to get rid of the bullet points that are rearing their ugly head.

http://www.windsurf.me.uk/cpg133/thumbnails.php?album=61

I don't normally struggle with simple css, maybe it is lack of sleep or staring at it for so long I'm going blind.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Joe Carver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1503
  • aka 'i-imagine'
    • Home Page
Re: I see spots before my eyes. Loosing the bullet points
« Reply #1 on: March 18, 2010, 07:30:21 pm »

I could not see exactly what/which you were referring to but the W3C validation page lit up with a reference to a misplaced  </ul>.

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4679
    • Windsurf.me
Re: I see spots before my eyes. Loosing the bullet points
« Reply #2 on: March 18, 2010, 07:33:57 pm »

Hi Joe,

The theme is far from complete so the validation is not too much of a problem yet.

Take a look at all the menu items and you will see bullet points in them, the are in other places too.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Jeff Bailey

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1323
  • Fishing relaxes me.
    • Bailey Family Co.
Re: I see spots before my eyes. Loosing the bullet points
« Reply #3 on: March 18, 2010, 08:15:20 pm »

the bullet comes from
Code: [Select]
var separator = '&nbsp;&bull;&nbsp;';
in thumbnails.js

Is it possible to just edit that or do you need to hide it with css?
Logged
Thinking is the hardest work there is, which is probably the reason why so few engage in it. - Henry Ford

Joe Carver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1503
  • aka 'i-imagine'
    • Home Page
Re: I see spots before my eyes. Loosing the bullet points
« Reply #4 on: March 18, 2010, 08:26:14 pm »

the bullet comes from .......thumbnails.js

I am not too sure I agree because the artifact also shows on search.php where thumbnails.js should not have an influence. However I must say that all is just a guess from this distance.

@Phil, the stray </ul> in the Curve theme was fixed by Joachim. You might want to use that newer version of Curve as your template before you go too far (it was not was easily found by me - I was happy that he was able to find and fix it quickly)

Jeff Bailey

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1323
  • Fishing relaxes me.
    • Bailey Family Co.
Re: I see spots before my eyes. Loosing the bullet points
« Reply #5 on: March 18, 2010, 08:27:54 pm »

oops i was looking at the wrong dots.
Logged
Thinking is the hardest work there is, which is probably the reason why so few engage in it. - Henry Ford

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4679
    • Windsurf.me
Re: I see spots before my eyes. Loosing the bullet points
« Reply #6 on: March 18, 2010, 08:39:31 pm »

@Phil, the stray </ul> in the Curve theme was fixed by Joachim. You might want to use that newer version of Curve as your template before you go too far (it was not was easily found by me - I was happy that he was able to find and fix it quickly)

I'm already at rev 7319 and that was fixed at 7300 so the stray /ul must be from somewhere else.

Now back to me spots.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Jeff Bailey

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1323
  • Fishing relaxes me.
    • Bailey Family Co.
Re: I see spots before my eyes. Loosing the bullet points
« Reply #7 on: March 18, 2010, 08:46:26 pm »

In template.css
Code: [Select]
ul li {
background: url(../images/bullet.gif) no-repeat 20px 8px;
padding-left: 30px;
}

This should be the dot your seeing.
Logged
Thinking is the hardest work there is, which is probably the reason why so few engage in it. - Henry Ford

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4679
    • Windsurf.me
Re: I see spots before my eyes. Loosing the bullet points
« Reply #8 on: March 18, 2010, 09:14:34 pm »

3am last night I was looking straight at that and missed it. It is always a mare when integrating 2 templates like that. I've added a !important rule to style.css

It cures the menu bullets but the others (the ones in the image you posted) don't go away.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Jeff Bailey

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1323
  • Fishing relaxes me.
    • Bailey Family Co.
Re: I see spots before my eyes. Loosing the bullet points
« Reply #9 on: March 18, 2010, 09:16:56 pm »

The ones in the image I posted come from the javascript mentioned here:
http://forum.coppermine-gallery.net/index.php/topic,64160.msg318729.html#msg318729
Logged
Thinking is the hardest work there is, which is probably the reason why so few engage in it. - Henry Ford

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4679
    • Windsurf.me
Re: I see spots before my eyes. Loosing the bullet points
« Reply #10 on: March 18, 2010, 09:20:19 pm »

Yeah, I'm working on that. Thanks for your help, I just couldn't find them.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Joe Carver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1503
  • aka 'i-imagine'
    • Home Page
Re: I see spots before my eyes. Loosing the bullet points
« Reply #11 on: March 18, 2010, 11:17:26 pm »

I'm already at rev 7319 and that was fixed at 7300 so the stray /ul must be from somewhere else.

7139 seems to have the validation error - for the moment I will leave it to someone else to confirm + report

From W3C validation:    "end tag for "ul" which is not finished"

Shane

  • Contributor
  • Coppermine regular visitor
  • ***
  • Offline Offline
  • Posts: 76
  • Choose Again
    • The Philmont Forum
Re: I see spots before my eyes. Loosing the bullet points
« Reply #12 on: August 05, 2010, 04:40:35 am »

3am last night I was looking straight at that and missed it. It is always a mare when integrating 2 templates like that. I've added a !important rule to style.css

It cures the menu bullets but the others (the ones in the image you posted) don't go away.

Phil, can you detail the !important rule you added to style.css to get rid of the menu bullets.  I'm having the same issue and have no idea what needs to be fixed.  Sites:  http://philmontforum.com/cpg and http://philmontforum.com/15test/cpg (test bed for trying out stuff).  My sites are also bridged to Joomla via Mehdi's bridge.

Thanks!
Logged

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4679
    • Windsurf.me
Re: I see spots before my eyes. Loosing the bullet points
« Reply #13 on: August 05, 2010, 07:41:13 am »

I'll have a look when I get home this evening. If I don't respond by tomorrow morning please bump this thread.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Jeff Bailey

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1323
  • Fishing relaxes me.
    • Bailey Family Co.
Re: I see spots before my eyes. Loosing the bullet points
« Reply #14 on: August 05, 2010, 08:00:17 am »

In your themes style.css
Code: [Select]
ul li {
background:none repeat scroll 0 0 transparent !important;
}
Logged
Thinking is the hardest work there is, which is probably the reason why so few engage in it. - Henry Ford

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4679
    • Windsurf.me
Re: I see spots before my eyes. Loosing the bullet points
« Reply #15 on: August 05, 2010, 08:08:33 am »

Cheers Jeff, I was also going to attach the other adjustments I made to the integrated css but it looks like Shane is doing a great job.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Shane

  • Contributor
  • Coppermine regular visitor
  • ***
  • Offline Offline
  • Posts: 76
  • Choose Again
    • The Philmont Forum
Re: I see spots before my eyes. Loosing the bullet points
« Reply #16 on: August 06, 2010, 02:28:40 am »

You guys are great!  My spots are gone... except for the same one's still on Phil's site...

Thanks for the help!
Logged

Jeff Bailey

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1323
  • Fishing relaxes me.
    • Bailey Family Co.
Re: I see spots before my eyes. Loosing the bullet points
« Reply #17 on: August 06, 2010, 03:14:06 am »

the bullet comes from
Code: [Select]
var separator = '&nbsp;&bull;&nbsp;';
in thumbnails.js

Is it possible to just edit that or do you need to hide it with css?

just take the
Code: [Select]
&bull;
out.
Logged
Thinking is the hardest work there is, which is probably the reason why so few engage in it. - Henry Ford
Pages: [1]   Go Up
 

Page created in 0.028 seconds with 21 queries.