Advanced search  

News:

CPG Release 1.6.26
Correct PHP8.2 issues with user and language managers.
Additional fixes for PHP 8.2
Correct PHP8 error with SMF 2.0 bridge.
Correct IPTC supplimental category parsing.
Download and info HERE

Pages: 1 [2]   Go Down

Author Topic: Lost name when editing comments.  (Read 12604 times)

0 Members and 1 Guest are viewing this topic.

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Lost name when editing comments.
« Reply #20 on: October 20, 2003, 04:35:47 am »

Quote from: "lasa"
No, the actual fix should be something like this :P


NO! the name has to be editable by the admin. - thus the previous post is right

@ lasa now you are on the very fringe of being banned using the sticking tongue out emoticon is considered rude
Logged
SANIsoft PHP applications for E Biz

jdbaranger

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 169
    • Accro-Photo
Lost name when editing comments.
« Reply #21 on: October 27, 2003, 03:11:56 pm »

OK, but if the name is longer than 10 characters, it doesn't work.

I tried to change

Code: [Select]
<input type=text name=msg_author value={MSG_AUTHOR} class="textinput" size=10>

with

Code: [Select]
<input type=text name=msg_author value={MSG_AUTHOR} class="textinput" size=25>
but it's the same :

Editing Jean-Denis Baranger's comment changes Jean-Denis Baranger to Jean-Denis.

Any idea ?
Logged
Jean-Denis

jdbaranger

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 169
    • Accro-Photo
Lost name when editing comments.
« Reply #22 on: October 27, 2003, 03:17:56 pm »

In fact, the problem appears when there's a space in the username. Exemples here :
http://www.photo-parade.com/galeries/thumbnails.php?album=lastup&cat=10002
Logged
Jean-Denis

jdbaranger

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 169
    • Accro-Photo
Lost name when editing comments.
« Reply #23 on: November 09, 2003, 01:48:15 pm »

If i replace

Code: [Select]
<input type=text name=msg_author value={MSG_AUTHOR} class="textinput" size=25>

by

Code: [Select]
<textarea cols="25" rows="1" class="textinput" name="msg_author" onselect="storeCaret_f{MSG_AUTHOR}(this);" onclick="storeCaret_f{MSG_AUTHOR}(this);" onkeyup="storeCaret_f{MSG_AUTHOR}(this);" style="width: 100%;">{MSG_AUTHOR}</textarea>

The problem corrects, but i still don't understand why spaces disappear with original code.
The result is not very great with this second code, but it seems that nobody as other solution.

Jean-Denis
Logged
Jean-Denis

jdbaranger

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 169
    • Accro-Photo
Lost name when editing comments.
« Reply #24 on: November 09, 2003, 02:19:10 pm »

In fact, the solution was so simple :

Just replace

Code: [Select]
<input type=text name=msg_author value={MSG_AUTHOR} class="textinput" size=25>
with

Code: [Select]
<input type=text name=msg_author value="{MSG_AUTHOR}" class="textinput" size=25>
Logged
Jean-Denis

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Lost name when editing comments.
« Reply #25 on: November 09, 2003, 04:43:54 pm »

:lol: I fixed this yesterday OR day before in CVS
Logged
SANIsoft PHP applications for E Biz

jdbaranger

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 169
    • Accro-Photo
Lost name when editing comments.
« Reply #26 on: November 09, 2003, 07:21:29 pm »

what is CVS  :?:

Jean-Denis
Logged
Jean-Denis

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Lost name when editing comments.
« Reply #27 on: November 09, 2003, 07:51:07 pm »

CVS = Concurrent Versions System. It's an app that let's different devs work on the same code base, managing the changes each dev applies.
We chose sourceforge.net to host coppermine on basically because they offer cvs.
Devs can access it in read/write mode, non-devs can access it in read-only mode: http://cvs.sourceforge.net/viewcvs.py/coppermine/

GauGau
Logged

jdbaranger

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 169
    • Accro-Photo
Lost name when editing comments.
« Reply #28 on: November 10, 2003, 08:37:20 am »

Great ! Next time i'll go to see in CVS before searching...

Thanks!

Jean-Denis
Logged
Jean-Denis

korn

  • Coppermine newbie
  • Offline Offline
  • Posts: 8
Re: Lost name when editing comments.
« Reply #29 on: May 01, 2004, 08:52:31 am »

I have the same problem (user name disappears, when editing comment, version 1.2.1) using theme FRUITY with smilies enabled. When smilies are disabled everything works fine. Can someone help?
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: Lost name when editing comments.
« Reply #30 on: May 01, 2004, 03:06:17 pm »

Update your theme.php to the latest one (1.2.1)  This was changed some time ago.
If you have too many customised bits to do that, post here your code in the section ;

Quote
<!-- BEGIN edit_box_smilies -->
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: Lost name when editing comments.
« Reply #31 on: May 01, 2004, 04:20:58 pm »

On 2nd look, it seems this was missed during the update.

Open your themes/fruity/theme.php, and find this code;
Code: [Select]
<!-- BEGIN edit_box_smilies -->
                                <table width="100%" cellpadding="0" cellspacing="0">
                                        <tr>
                                                <form name="f{MSG_ID}" method="POST" action="db_input.php">
                                                <input type="hidden" name="event" value="comment_update">
                                                <input type="hidden" name="msg_id" value="{MSG_ID}">
                                                <td width="100%">
                                                        <textarea cols="40" rows="2" class="textinput" name="msg_body" onselect="storeCaret_f{MSG_ID}(this);" onclick="storeCaret_f{MSG_ID}(this);" onkeyup="storeCaret_f{MSG_ID}(this);" style="width: 100%;">{MSG_BODY_RAW}</textarea>
                                                </td>
                                                <td class="tableb_compact">
                                                </td>
                                                <td>
                                                        <input type="submit" class="comment_button" name="submit" value="{OK}">
                                                </td>
                                                </form>
                                        </tr>
                                        <tr>
                                                <td colspan="3"><img src="images/spacer.gif" width="1" height="2" alt="" /><br /></td>
                                        </tr>
                                </table>
                                {SMILIES}
<!-- END edit_box_smilies -->

replace it with;

Code: [Select]
<!-- BEGIN edit_box_smilies -->
                                <table width="100%" cellpadding="0" cellspacing="0">
                                        <tr>
                                                <form name="f{MSG_ID}" method="POST" action="db_input.php">
                                                <input type="hidden" name="event" value="comment_update">
                                                <input type="hidden" name="msg_id" value="{MSG_ID}">
<td>
                                                <input type=text name=msg_author value={MSG_AUTHOR} class="textinput" size=25>
                                                </td>
                                                <td width="100%">
                                                        <textarea cols="40" rows="2" class="textinput" name="msg_body" onselect="storeCaret_f{MSG_ID}(this);" onclick="storeCaret_f{MSG_ID}(this);" onkeyup="storeCaret_f{MSG_ID}(this);" style="width: 100%;">{MSG_BODY_RAW}</textarea>
                                                </td>
                                                <td class="tableb_compact">
                                                </td>
                                                <td>
                                                        <input type="submit" class="comment_button" name="submit" value="{OK}">
                                                </td>
                                                </form>
                                        </tr>
                                        <tr>
                                                <td colspan="3"><img src="images/spacer.gif" width="1" height="2" alt="" /><br /></td>
                                        </tr>
                                </table>
                                {SMILIES}
<!-- END edit_box_smilies -->
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

korn

  • Coppermine newbie
  • Offline Offline
  • Posts: 8
Re: Lost name when editing comments.
« Reply #32 on: May 02, 2004, 11:07:46 am »

Thanks  :)
Logged
Pages: 1 [2]   Go Up
 

Page created in 0.021 seconds with 18 queries.