Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1] 2   Go Down

Author Topic: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG  (Read 25023 times)

0 Members and 1 Guest are viewing this topic.

François Keller

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: fr
  • Offline Offline
  • Gender: Male
  • Posts: 9097
  • aka Frantz
    • Ma galerie
[cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« on: August 25, 2008, 10:41:41 pm »

Hey All,

I've ported the grey-style-20 wordpress theme to cpg

I've overwritten some of the configuration settings by using variables in the theme.php file and added a new variable for retrieving the album description. The reason for this is to prevent the standard settings in the Configuration tables set by you from "breaking" the theme. These changes are:

Code: [Select]
// These parameters overide what the user inputs in the Configuration setup to prevent the theme from breaking.
$CONFIG['max_film_strip_items'] = 4; //overrides the number of thumbnails.
$CONFIG['thumbcols'] = 4; //overrides the number of columns for thumbnails.
$CONFIG['main_table_width'] = '100%'; //overrides the Width of the main table (pixels or %).
$CONFIG['picture_table_width'] = '100%'; //overrides the Width of the table for file display (pixels or %).

Icons in the img folder come from http://www.vistaico.com
This theme comes with a multilingual menu title:
in the theme folder you find a lang folder with some language files (english, french, german).
feel free to add your own lang file an share it on the coppermine forum

Thank's to Gizmo for his work, it helps me to do port this theme.

new version 1.0.2 attached
« Last Edit: November 23, 2009, 09:30:25 am by Joachim Müller »
Logged
Avez vous lu la DOC ? la FAQ ? et cherché sur le forum avant de poster ?
Did you read the DOC ? the FAQ ? and search the board before posting ?
Mon Blog

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #1 on: August 25, 2008, 11:37:26 pm »

Hello Francois,

the theme looks very promising. I have uploaded the theme as-is to our demo, but imo the left column is way too wide (or the middle column to narrow) - see screenshot (taken with FF2 on Linux with 1280x800 resolution). Could you please look into this (or even get rid of the left column, since I can't see the point of it anyway)? Thanks

Joachim
Logged

François Keller

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: fr
  • Offline Offline
  • Gender: Male
  • Posts: 9097
  • aka Frantz
    • Ma galerie
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #2 on: August 26, 2008, 07:25:25 am »

Thank's Joachim,

i can't replicate your problem
see the screen shots with FF3 and IE7 on Windows XP with 1440 x 900
Logged
Avez vous lu la DOC ? la FAQ ? et cherché sur le forum avant de poster ?
Did you read the DOC ? the FAQ ? and search the board before posting ?
Mon Blog

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #3 on: August 26, 2008, 07:57:46 am »

The center column is wrapped inside a block named "content", which has a margin-left property of 195 pixels. I can not replictae why this is not the case for you. More screenshots attached. I recommend testing with 1024 or 1280 pixels screen width.
Logged

François Keller

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: fr
  • Offline Offline
  • Gender: Male
  • Posts: 9097
  • aka Frantz
    • Ma galerie
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #4 on: August 26, 2008, 09:40:36 am »

I have tested it with other screen width without problems.
But i will look into this problem this evening and hope i will find what's happend.
It would be helpfull to have other reports to see if other users have this problem
Thank's for your report
Logged
Avez vous lu la DOC ? la FAQ ? et cherché sur le forum avant de poster ?
Did you read the DOC ? the FAQ ? and search the board before posting ?
Mon Blog

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4685
    • Windsurf.me
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #5 on: August 26, 2008, 09:52:09 am »

It looks fine in IE7 on my machine with a resolution of 1024 but in FF2/3 and Safari I get the same problem as Joachim

By adjusting the margin in wp-style.css from
Code: [Select]
margin: 0 195px 20px 195px; to
Code: [Select]
margin: 0 0px 20px 0px; does seem to fix the wasted space but still leaves some display problems in FF only.

The header also displays in a different font in FF to IE7 but that could be my problem.

Great looking theme.
« Last Edit: August 26, 2008, 10:23:09 am by phill104 »
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Gizmo

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1015
    • BullsEye Photos
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #6 on: August 26, 2008, 04:26:46 pm »

Hi Francois,

After making the changes suggested by phill104 the theme started coming together. Below are my suggestions.

  • fix the visited links so they don't stay bold after clicking away from that page. It's style a:visited that's the culpert.
  • the scrollbar at the bottom is a real problem with fixed width themes in CPG. I've resorted to a script to read the pages that need the scrollbar and use a different class for those pages. These are the users and groups managers in the admin menu as they are wide tables. The code I put together with Nibbler's help is here. I resorted to this technique is because I'm tired of fighting with IE to handle scrollbars without a lot of hacks. This seems to work great and with all browsers.
  • Large images run off the screen in the intermediate display. Again I use a script to determine these large images and resize them. You can find the code in most of my WordPress themes but check the latest one here. Check for function compute_img_size_max($width, $height) and if you need help let me know and I'll add more details. It's a lot of code to type here so I could make a post detailing these instructions for all to use.
  • I can't believe this but 2 days ago I was looking for a way to remove that ugly album menu and you come up with a beautiful icon solution.  :D Can I use this in my other ports? This is really a cool solution.
  • Your language script to items not available to themers is a great idea. This will become standard issue now in my themes. You're first theme has really come out with some great ideas!  :)
I'll look at this more later today but it's a great start!

Cheers,

Billy
Logged
Did you read the manual first???? Taking 2 minutes to backup your files can save you hours of wondering what you screwed up.
Billy Bullock - BullsEyePhotos Blog of Indecision

François Keller

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: fr
  • Offline Offline
  • Gender: Male
  • Posts: 9097
  • aka Frantz
    • Ma galerie
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #7 on: August 26, 2008, 05:25:06 pm »

Hi Billy
Thank's for your suggestions, i'll have a look on this this evening...
of course you can use all my solutions for your ported themes (icons and language script)  :D
and thank's to phil104 for your suggestions
together we will do a super theme  :D
Logged
Avez vous lu la DOC ? la FAQ ? et cherché sur le forum avant de poster ?
Did you read the DOC ? the FAQ ? and search the board before posting ?
Mon Blog

François Keller

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: fr
  • Offline Offline
  • Gender: Male
  • Posts: 9097
  • aka Frantz
    • Ma galerie
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #8 on: August 26, 2008, 10:38:44 pm »

I've made few changes in the themes to fix the problem and to add Gizmo's suggestions
The new archive is attached at the very first post (version 1.0.1)
I've also an other little problem: I wanted to replace the picture admin (see sceen shot)menu with icons, but i have not found how to get ride the html_picture_menu() function who is in the displayimage.php file...
If someone has an idea...
Logged
Avez vous lu la DOC ? la FAQ ? et cherché sur le forum avant de poster ?
Did you read the DOC ? the FAQ ? and search the board before posting ?
Mon Blog

Gizmo

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1015
    • BullsEye Photos
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #9 on: August 26, 2008, 11:49:29 pm »

I forgot to add this morning that you have 1 too many </div> in your template.html file. Just remove the last one. Another thing I can't seem to figure out is why this theme won't load in my XAMPP installation. All the other themes do so I can only upload to my server space where my other test gallery is located. Strange.  ???
« Last Edit: August 26, 2008, 11:55:32 pm by Gizmo »
Logged
Did you read the manual first???? Taking 2 minutes to backup your files can save you hours of wondering what you screwed up.
Billy Bullock - BullsEyePhotos Blog of Indecision

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4685
    • Windsurf.me
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #10 on: August 27, 2008, 12:17:22 am »

Fantastic job. Love the theme.

Two tiny things (and it is probably being really picky). In FF there is a line under the gallery menu title and it vanishes in IE7. When you enable the theme chooser it is well spaced in the links menu but in IE7 it touches the coppermine gallery title.

Safari displayes everything the same as FF.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

François Keller

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: fr
  • Offline Offline
  • Gender: Male
  • Posts: 9097
  • aka Frantz
    • Ma galerie
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #11 on: August 27, 2008, 07:31:21 am »

I forgot to add this morning that you have 1 too many </div> in your template.html file. Just remove the last one.
done, thank's for reporting that
Another thing I can't seem to figure out is why this theme won't load in my XAMPP installation. All the other themes do so I can only upload to my server space where my other test gallery is located. Strange.  ???
i have no problem on my WAMP server  :-\
When you enable the theme chooser it is well spaced in the links menu but in IE7 it touches the coppermine gallery title.
corrected
In FF there is a line under the gallery menu title and it vanishes in IE7.
You're right, but i can't figure out why, i'm searching...
Thank's for your test

P.S. Corrected files in the archive on the very first post
Logged
Avez vous lu la DOC ? la FAQ ? et cherché sur le forum avant de poster ?
Did you read the DOC ? the FAQ ? and search the board before posting ?
Mon Blog

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #12 on: August 27, 2008, 09:08:03 am »

Wow (that "wow" goes for the beauty of the theme)! Thanks for looking into the issues - I think we're getting another potential candidate for the new default theme ;) (although I'm a bit concerned about the extra JS going into the core as default, but that should be discussed someplace else).

Anyway, here are the "official" links: Demo - Download

Joachim

P.S. Please don't forget to count up the zip file version number after the theme name, and please use the naming convention as per my reply to one of Gizmo's contributions:
If possible, could you rename your files when attaching to avoid confusion for end users: the naming scheme for themes is "cpgX.Y.Z_theme_ThemeName_ThemeVersion.zip" (e.g. "cpg1.4.x_theme_ocadia_v1.3.zip") - thanks.

Logged

François Keller

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: fr
  • Offline Offline
  • Gender: Male
  • Posts: 9097
  • aka Frantz
    • Ma galerie
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #13 on: August 27, 2008, 09:12:26 am »

Quote
P.S. Please don't forget to count up the zip file version number after the theme name, and please use the naming convention as per my reply to one of Gizmo's contributions:
Ok, i'll do so next time  ;)
Logged
Avez vous lu la DOC ? la FAQ ? et cherché sur le forum avant de poster ?
Did you read the DOC ? the FAQ ? and search the board before posting ?
Mon Blog

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4685
    • Windsurf.me
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #14 on: August 27, 2008, 08:09:41 pm »

I have uploaded the theme as-is to our demoJoachim

At the moment on the demo page the theme displays over the top of the theme selector. Could you sort this out as I forsee users getting stuck on this theme.
Logged
It is a mistake to think you can solve any major problems just with potatoes.

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #15 on: August 27, 2008, 08:58:12 pm »

Doesn't happen for me (using FF2): the theme selector displays just fine - see screenshot.
Logged

Phill Luckhurst

  • Administrator
  • Coppermine addict
  • *****
  • Country: gb
  • Offline Offline
  • Gender: Male
  • Posts: 4685
    • Windsurf.me
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #16 on: August 27, 2008, 09:04:48 pm »

Must be an IE (both 6 & 7 on different machines) problem as it works in FF for me too.

Logged
It is a mistake to think you can solve any major problems just with potatoes.

Gizmo

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1015
    • BullsEye Photos
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #17 on: August 27, 2008, 09:33:02 pm »

I get the messed up header on Mac with both FF & Safari.
Logged
Did you read the manual first???? Taking 2 minutes to backup your files can save you hours of wondering what you screwed up.
Billy Bullock - BullsEyePhotos Blog of Indecision

François Keller

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: fr
  • Offline Offline
  • Gender: Male
  • Posts: 9097
  • aka Frantz
    • Ma galerie
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #18 on: August 27, 2008, 10:40:33 pm »

i have the same problem with IE but it works with FF3  :-\
Logged
Avez vous lu la DOC ? la FAQ ? et cherché sur le forum avant de poster ?
Did you read the DOC ? the FAQ ? and search the board before posting ?
Mon Blog

Gizmo

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1015
    • BullsEye Photos
Re: [cpg1.4.x]: Wordpress Grey-style-20 theme ported to CPG
« Reply #19 on: August 28, 2008, 04:11:34 am »

I noticed you used the truncation function but you aren't displaying the full album description on the album page. You need to add this variable to your theme.php and then it will show the description at the top of the album page.

Code: [Select]
// HTML template for title row of the thumbnail view (album title + sort options)
$template_thumb_view_title_row = <<<EOT

                        <table width="100%" cellpadding="0" cellspacing="0">
                        <tr>
                                <td width="100%" class="alblink"><h2>{ALBUM_NAME}</h2></td>

                        </tr>
                        <tr><td>
                        <p>{$album_desc}</p>
                        </td></tr>
                        </table>

EOT;
Logged
Did you read the manual first???? Taking 2 minutes to backup your files can save you hours of wondering what you screwed up.
Billy Bullock - BullsEyePhotos Blog of Indecision
Pages: [1] 2   Go Up
 

Page created in 0.043 seconds with 20 queries.