Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: [Solved]: Guest commets ask always the "name" [1.4.17]  (Read 5630 times)

0 Members and 1 Guest are viewing this topic.

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
[Solved]: Guest commets ask always the "name" [1.4.17]
« on: May 12, 2008, 02:21:43 am »

Hello,
I have installed the 1.4.17 (upgraded to 1.4.18).

My issue is this: why always ask the guest to write their name in the comments area?

Some versions ago, the gallery only ask once and remembers (via Cookie, I think) the "name" the guest has written and automatically set it on for a new comment on the gallery

Any ideas why is this?
Is it possible to make the gallery remember the guest "name" just for new comments in the 1.4.17 like a few versions ago?

Thank you in advance for your help.
Saludos,
   pepemosca
« Last Edit: May 14, 2008, 03:48:30 pm by Joachim Müller »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Guest commets ask always the "name" [1.4.17]
« Reply #1 on: May 12, 2008, 09:08:06 am »

Post a link to your gallery for a start...
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #2 on: May 13, 2008, 12:23:53 am »

Ok, here is the link http://www.juanylu.com.ar/images/

Thank you for your reply :)
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Guest commets ask always the "name" [1.4.17]
« Reply #3 on: May 13, 2008, 08:38:43 am »

It's mandatory that you upgrade to cpg1.4.18 first for security reasons.
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #4 on: May 13, 2008, 12:22:43 pm »

It's mandatory that you upgrade to cpg1.4.18 first for security reasons.

I did the manual upgrade.
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #5 on: May 13, 2008, 11:30:39 pm »

Is not the same doing the manual replace of the mentioned file?

As saids here http://forum.coppermine-gallery.net/index.php/topic,51882.0.html
Logged

Nibbler

  • Guest
Re: Guest commets ask always the "name" [1.4.17]
« Reply #6 on: May 13, 2008, 11:48:23 pm »

That's fine. Do you still get the problem if you disable the captcha plugin, at least for comments?
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #7 on: May 14, 2008, 12:15:17 am »

That's fine. Do you still get the problem if you disable the captcha plugin, at least for comments?

Yes, still have the problem:

http://www.juanylu.com.ar/images/displayimage.php?pos=-10716

Any ideas?
Logged

Nibbler

  • Guest
Re: Guest commets ask always the "name" [1.4.17]
« Reply #8 on: May 14, 2008, 12:27:02 am »

Captcha is still enabled.

The name is not being saved to the cookie, but I don't know why.
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #9 on: May 14, 2008, 12:30:08 am »

Sorry: I'd turned back on when I saw it wasn't working without it.
Now is off.

http://www.juanylu.com.ar/images/displayimage.php?pos=-10716
Logged

Nibbler

  • Guest
Re: Guest commets ask always the "name" [1.4.17]
« Reply #10 on: May 14, 2008, 12:36:01 am »

Can you re-upload the classic theme for testing please?
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #11 on: May 14, 2008, 12:46:24 am »

Is what I'm doing.

But -is embarrassing but...- I had reupload the db_input.php and now works.

Check out my mod:

Code: [Select]
//** Modificado por Juan Pedro 11:08 15/10/2007

$result_comment = mysql_query("SELECT aid,filepath,filename FROM cpg_pictures WHERE pid = '$pid'");
list($aid,$filepath,$filename) = mysql_fetch_row($result_comment);
$result = mysql_query("SELECT title FROM cpg_albums WHERE aid = '$aid'");
list($title) = mysql_fetch_row($result);

$base = rtrim($CONFIG['ecards_more_pic_target'], '/');

// Para la tabla de historial (hay que incluirlo en $mail_body)
$mail_body_historial = " ";
$result4 = mysql_fetch_row(mysql_query("SELECT COUNT(*) FROM cpg_comments WHERE pid = '$pid'"));
if($result4[0]>1)
{
$mail_body_historial = $mail_body_historial." <br/><br/><b>Historial de comentarios:</b><br/>";
$mail_body_historial = $mail_body_historial." <table border=0 cellpadding=2><tr><td><b>Autor</b></td><td><b>Comentario</b></td><td><b>Fecha</b></td><td><b>IP</b></td></tr>";

$result5 = mysql_query("SELECT msg_author,msg_body,msg_date,msg_raw_ip FROM cpg_comments WHERE pid = '$pid' ORDER BY msg_id ASC");
while(list($r_msg_author_c,$r_msg_body_c,$r_msg_date_c,$r_msg_raw_ip_c) = mysql_fetch_row($result5))
{
$mail_body_historial = $mail_body_historial." <tr><td>$r_msg_author_c</td><td>".bb_decode(process_smilies($r_msg_body_c, $CONFIG['ecards_more_pic_target']))."</td><td>$r_msg_date_c</td><td>$r_msg_raw_ip_c</td></tr>";
}
$mail_body_historial = $mail_body_historial." </table>";
}
// Fin de la tabla de historial


$mail_subject= 'Comentario en el album "'.$title.'"'; //por '.$msg_author; //Notar como se hace el acento en la A (buscar en el SQL)
$mail_body = "<a href=\"$base/displayimage.php?pos=-$pid\"><img src=\"$base/albums/$filepath" . "thumb_$filename\" alt=\"\" border=\"0px\" /></a> <br/> <br/> <b>&#193;lbum:</b> " . $title . "<br/><b>Autor:</b> " . $msg_author . "<br/><b>Comentario:</b> " . bb_decode(process_smilies($msg_body, $CONFIG['ecards_more_pic_target'])) . "<br/><b>IP:</b> " . $raw_ip . "\n\r" . $mail_body_historial . "<br/>\n\r<br/>\n\r" . $lang_db_input_php['email_comment_body'] . " " . $CONFIG['ecards_more_pic_target'].(substr($CONFIG["ecards_more_pic_target"], -1) == '/' ? '' : '/').$redirect;

//cpg_mail('admin', $lang_db_input_php['email_comment_subject'], make_clickable($mail_body));
cpg_mail('admin', $mail_subject, make_clickable($mail_body));

//** Modificado por Juan Pedro 11:08 15/10/2007

Is for sending a better mail notification about a new comment.
Here is how:

[Edit GauGau] Replaced hotlinked image with attachment [/Edit]

Also, here is the db_input.php modded:

http://rapidshare.com/files/114715769/db_input.php.html
[Edit GauGau] Downloaded that file, renamed it from db_input.php to db_input.php.txt and attached it to this thread. Don't use external hotlinks in the future [/Edit]

Sorry! It was me :)
But any ideas what is wrong?
« Last Edit: May 14, 2008, 09:00:06 am by Joachim Müller »
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #12 on: May 14, 2008, 12:55:53 am »

yup, it's my mod to the db_input.php.
I'm stup*d :(

Now, different question: ideas why?
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #13 on: May 14, 2008, 01:05:05 am »

In a terrible way, you can see the modding over the code at page 4:

http://rapidshare.com/files/114718865/db_input.php_-_db_input.mdi.html
Logged

Nibbler

  • Guest
Re: Guest commets ask always the "name" [1.4.17]
« Reply #14 on: May 14, 2008, 01:08:51 am »

I don't know what an .mdi file is. I'd suggest you add back in parts of your mod until you find the line of code that breaks the functionality.
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #15 on: May 14, 2008, 01:15:51 am »

Sorry, an mdi is a Microsoft Office Document Image Writer.
I don't have a PDF printer.

I'll try to check the code in order to see what's happening.

But when does it make the Cookie?
Logged

pepemosca

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 25
Re: Guest commets ask always the "name" [1.4.17]
« Reply #16 on: May 14, 2008, 01:40:56 am »

Ok, this is crazy!

I just copy and pasted back the "modification over the original code" in the original db_input.php... and now works right!?

Can you check from your computers if it works?
http://www.juanylu.com.ar/images/displayimage.php?pos=-10716

Thanks!

Crazy!
Logged

Nibbler

  • Guest
Re: Guest commets ask always the "name" [1.4.17]
« Reply #17 on: May 14, 2008, 10:40:15 am »

Works fine now.
Logged
Pages: [1]   Go Up
 

Page created in 0.029 seconds with 20 queries.