Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: thumb sharpening breaking on gif files  (Read 4612 times)

0 Members and 1 Guest are viewing this topic.

nickfzx

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 285
thumb sharpening breaking on gif files
« on: November 09, 2006, 04:04:04 pm »

hi so if I turn on thumb sharpening it creates undesirable results if the images are gif files...jpegs work great and look a lot better.

here is an example of what happens:

http://amateurillustrator.com.s2734.gridserver.com/cpg/index.php

as I may be changing this link a lot here is a screenshot:

(http://amateurillustrator.com.s2734.gridserver.com/thumbs.jpg)

Any ideas?

Cheers

Nick
« Last Edit: November 10, 2006, 06:36:09 pm by Stramm »
Logged

nickfzx

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 285
Re: thumb sharpening breaking on gif files
« Reply #1 on: November 10, 2006, 02:38:02 pm »

has no one else experienced this...the two on the left are jpegs and the two on the right are gif files.
Logged

Hein Traag

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: nl
  • Offline Offline
  • Gender: Male
  • Posts: 2166
  • A, B, Cpg
    • Personal website - Spintires.nl
Re: thumb sharpening breaking on gif files
« Reply #2 on: November 10, 2006, 02:46:58 pm »

As they say... patiencie is a virtue. Give it a few days before expecting an answer from someone who knows.

Cheers!
Hein
Logged

Stramm

  • Moderator
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 6006
    • Bettis Wollwelt
Re: thumb sharpening breaking on gif files
« Reply #3 on: November 10, 2006, 02:57:28 pm »

sharping (ie the unsharpen mask) adds more detail, hence colors, to the image. Cause the number of colors in a gif image are limited, the result may look (when sharpened) poor.

The most practical solution is to not allow sharpening for gif images

in include/picmgmnt.inc.php find
Code: [Select]
            if ($sharpen==1 && $CONFIG['enable_unsharp']==1) {and replace with
Code: [Select]
            if ($sharpen==1 && $CONFIG['enable_unsharp']==1 && $imginfo[2] != GIS_GIF) {

nickfzx

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 285
Re: thumb sharpening breaking on gif files
« Reply #4 on: November 10, 2006, 04:39:49 pm »

that's great thanks
Logged
Pages: [1]   Go Up
 

Page created in 0.066 seconds with 21 queries.