Print

[dawirick]

I have created my first "presentable" Coppermine theme.

Clean, simple, elegant. 

I hope everyone enjoys it (the header picture is a panoramic I created from my own photos of my vacation to Hawaii)

See it in action (and see some family photos)

Unfortunately, do to system crash my server had to be rebuilt.  
As a result, the demo on my site is no longer available.

However, you can se it in the DEMO area of coppermine-gallery.net

[Joachim Müller]

Thanks for your readiness to contribute your custom theme. However, there are some flaws that need to be ironed out first before we can label this theme as fit for the theme contribution section:

• Don't use surplus function and variable definitions in theme.php
  You appear to have copied the entire content of themes/sample/theme.php into themes/cos/theme.php, then you started modifying the sections you wanted to see changed. That's not a bright idea nor the recommended method: definitions that exist in your custom theme will override the defaults. Subsequently, if your definition equals the default definition, it just adds surplus garbage data. I went through themes/cos/theme.php and removed the surplus definitions - please refer to the attached, reviewed copy.
• You had a nesting error in themes/cos/template.html (missing </td>).
  I added it, see attachment
• You're using deprecated HTML tags (the notorious <font>-tag), which is a no-no
  Review template.html
• Your stylesheet is missing definitions for a lot of coppermine's classes.
  Review your stylesheet!

I'm looking forward to your reviewed theme.

Joachim

[dawirick]

AH!  I see what you mean about the redundant code.  I'm new to php too.

I didn't include the definitions in the CSS because I didn't want any additional formatting.  Guess I forgot to take out thier references in the theme.php.

I'll clean things up and reattach...or should I start a new topic?

[Joachim Müller]

I didn't include the definitions in the CSS because I didn't want any additional formatting.  Guess I forgot to take out thier references in the theme.php.

Don't remove references in theme.php, as others might want to use your theme as a base for their own edits. I suggested to just define the CSS classes with no formatting, e.g. like this:

Code: [Select]

body {
        font-size: 10px;
        color: #000000;
        text-align: left;
        font-family: "Times New Roman", Times, serif;
}

a {
        font-size: 12px;
        font-weight: bolder;
        color: #0000FF;
        text-decoration: none;
}

a:hover {
        font-size: 14px;
        font-style: italic;
        font-weight: bolder;
        text-transform: capitalize;
        color: #666666;
        text-decoration: underline;
}

li.left {
        list-style-type: none;
        text-align: center;
        display: block;
        clear: both;
        padding-top: 5px;
        padding-bottom: 5px;
        border: thin double #000000;
        position: relative;
        width: 50%;
        margin-top: 5px;

}

li.syslvl {
        text-align: center;
        display: inline;
        padding: 2px 5px;
        clear: both;
        margin-left: 5px;
        border: thin double #000000;
        list-style-type: none;
        position: relative;
}
.img-shadow {
  float:left;
  background: url(images/shadow.gif) no-repeat bottom right;
  margin: 5px 0 0 5px;
}

.img-shadow img {
  display: block;
  position: relative;
  border: 5px ridge #a9a9a9;
  margin: -5px 5px 5px -5px;
}
ul.admin {
        border: thin solid #CCCCCC;
        padding: 10px;
        clear: both;
}

table {

}

h1{
}

h2 {
}

h3 {
}

p {
}

ul {
}

li {
}

.textinput {
}

.listbox {
}

.button {
}

.comment_button {
}

.radio {
        font-family: Verdana, Arial, Helvetica, sans-serif;
        font-size: 100%;
        vertical-align : middle;
}

.checkbox {
}

.bblink a {
}

.bblink a:hover {
}

.maintable {
}

.tableh1 {
}

.tableh1_compact {
}

.tableh2 {
}

.tableh2_compact {
}

.tableb {
}

.tableb_compact {
}

.tablef {
}

.catrow_noalb {
}

.catrow {
}

.album_stat {
}

.thumb_filename {
}

.thumb_title {
}

.thumb_caption {
}

.thumb_caption a {
}

.thumb_num_comments {
}

.user_thumb_infobox {
}

.user_thumb_infobox th {
}

.user_thumb_infobox td {
}

.user_thumb_infobox a {
}

.user_thumb_infobox a:hover {
}

.sortorder_cell {
}

.sortorder_options {
}

.navmenu {
}

.navmenu img {
}

.navmenu a {
}

.navmenu a:hover {
}

.admin_menu_thumb {
}

.admin_menu_thumb a {
}


.admin_menu_thumb a:hover {
}

.admin_menu {
}

.admin_menu a {
}

.admin_menu a:hover {
}

td #admin_menu_anim {
}

.comment_date{
}

.image {
}

.imageborder {
}

.display_media {
}

.thumbnails {
}

.footer {
}

.footer a {
}

.footer a:hover {
}

.statlink {
}

.statlink a {
}

.statlink a:hover {
}

.alblink a {
}

.alblink a:hover {
}

.catlink {
}

.catlink a {
}

.catlink a:hover {
}

.topmenu {
}

.topmenu a {
}

.topmenu a:hover  {
}

.img_caption_table {
}

.img_caption_table th {
}

.img_caption_table td {
}

.debug_text {
}

.clickable_option {
}

.listbox_lang {
}

#vanity a {
}
#vanity img {border:0}
#v_php {float:left;background-image:url(../../images/powered-php.gif);}
#v_php:hover {background-image:url(../../images/h_powered-php.gif);}
#v_mysql {float:left;background-image:url(../../images/powered-mysql.gif);}
#v_mysql:hover  {background-image:url(../../images/h_powered-mysql.gif);}
#v_xhtml {float:right;background-image:url(../../images/valid-xhtml10.gif);}
#v_xhtml:hover {background-image:url(../../images/h_valid-xhtml10.gif);}
#v_css {float:right;background-image:url(../../images/valid-css.gif);}
#v_css:hover{background-image:url(../../images/h_valid-css.gif);}

I'll clean things up and reattach...or should I start a new topic?

Please stick to this thread - leave it for discussion and review. Once your theme is ready for public release, we can still decide if we want a separate thread or move the existing one. Imo it doesn't hurt if other potential theme contributors can review this discussion and maybe even learn from it.

Joachim

[dawirick]

Okay!

I think I'm ready to try this again

Please see attachment...

[Joachim Müller]

This is a great improvement: you removed the surplus wrapper that you originally introduced, which subsequently makes modification of many sections in theme.php not needed any longer. Your theme is now as slim as it is suppossed to be and qualifies as a valid theme contribution. I have added it to the demo and downloads section and moved this thread accordingly.
Thanks for your contribution.

Demo - Download

[littlewing1112]

Hello,
I m using the last release of firefox under GNU/LINUX ( Ubuntu gutsy ) and it seems your theme is not working very well. I guess the bug is in the background description (css ?)

If you want, i m available to test any patch under this platform

The desktop screenshot is in attachment

Thanks in advance !!!

Regards,
Alexandre

 

[littlewing1112]

Hello,
I m using the last release of firefox under GNU/LINUX ( Ubuntu gutsy ) and it seems your theme is not working very well. I guess the bug is in the background description (css ?)

If you want, i m available to test any patch under this platform

The desktop screenshot is in attachment

Thanks in advance !!!

Regards,
Alexandre

 

Sorry
I m confused with an other thread.
....
I m going to post on the right topic :-)

Regards