Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Quick feature request - No scroll on popup  (Read 4459 times)

0 Members and 1 Guest are viewing this topic.

rphMedia

  • Contributor
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 515
  • ***muvipix.com***
    • muvipix - Music | Video | Pictures
Quick feature request - No scroll on popup
« on: September 21, 2006, 10:29:24 pm »

Also a quick mod :)

If the popup from the intermediate image is larger than the current screen resolution, scrollbars are definitely needed - no question.  But if the popup is smaller than the display res, there shouldn't be the ugly (vertical) scroll bar positioning in the browser.  This tiny hack will take care of that and also, just requesting that maybe this be implemented in the future?  If it breaks validation somehow, then I totally understand.  I just think the popup looks neater (for lack of a better word).

In themes.inc.php find
Code: [Select]
<body>
and replace with

Code: [Select]
<body scroll="auto">
It's that simple. 
« Last Edit: September 21, 2006, 10:39:07 pm by Nibbler »
Logged

Nibbler

  • Guest
Re: Quick feature request - No scroll on popup
« Reply #1 on: September 21, 2006, 10:34:31 pm »

It's not valid XHTML.
Logged

rphMedia

  • Contributor
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 515
  • ***muvipix.com***
    • muvipix - Music | Video | Pictures
Re: Quick feature request - No scroll on popup
« Reply #2 on: September 21, 2006, 10:38:16 pm »

I had a feeling ....... eh, quick 'hack' if they want it :)

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Quick feature request - No scroll on popup
« Reply #3 on: September 22, 2006, 09:53:03 pm »

In cpg1.5.x, there will be two additional options in coppermine's config that will allow you to specify the x and y offset in the pop-up, allowing standards-compliant pop-ups that don't have scroll-bars.
Logged

rphMedia

  • Contributor
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 515
  • ***muvipix.com***
    • muvipix - Music | Video | Pictures
Re: Quick feature request - No scroll on popup
« Reply #4 on: September 23, 2006, 01:48:54 am »

Looking forward to it, thanks, GauGau.
Pages: [1]   Go Up
 

Page created in 0.015 seconds with 20 queries.