Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Table header should not be used for areas the size of paragraphs or lists  (Read 2570 times)

0 Members and 1 Guest are viewing this topic.

silly_walk

  • Contributor
  • Coppermine newbie
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 14

The tags that include "tableh" and its variants are not only used for headers (Sort my Albums, as an example), which makes it hard to skin properly, because the headers look great until you run into a part of the gallery where there is not actually a header but that uses the header tag (the screen where you place uploaded pics is another example). These areas should be re-I.D.ed / re-classed.
« Last Edit: September 01, 2006, 08:44:32 am by GauGau »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Table header should not be used for areas the size of paragraphs or lists
« Reply #1 on: September 01, 2006, 08:44:20 am »

Valid request. Could you come up with some code examples, where the tablehX classes are being used in places they're not suppossed to?
Logged

silly_walk

  • Contributor
  • Coppermine newbie
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 14
Re: Table header should not be used for areas the size of paragraphs or lists
« Reply #2 on: September 01, 2006, 05:21:41 pm »

From upload.php:
Code: [Select]
    // Create image tag and echo it to the output buffer.
    echo "<tr><td class=\"tableh2\"><img class=\"image\" src=\"".$path_to_preview."\"  /></td>";

    // Echo instructions.
    echo "<td class=\"tableh2\">{$lang_upload_php['picture']} - {$file_set[0]}<br /><br />{$lang_upload_php['place_instr_1']}<br /><br />";

From groupmgr.php:
Code: [Select]
    while ($group = mysql_fetch_array($result)) {
        $group['group_name'] = $group['group_name'];
        $row_counter++;
        if ($row_counter == 1 ) {$table_background = 'tableb';}else{$table_background = 'tableh2';$row_counter = 0;}
Logged
Pages: [1]   Go Up
 

Page created in 0.024 seconds with 21 queries.