Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: file CAPTION vs. file DESCRIPTION vs. album DESCRIPTION  (Read 8882 times)

0 Members and 1 Guest are viewing this topic.

tomaash

  • Coppermine newbie
  • Offline Offline
  • Posts: 5
file CAPTION vs. file DESCRIPTION vs. album DESCRIPTION
« on: August 11, 2006, 02:49:38 pm »

ok. so as I am going through the coppermine code and config some of new questions are coming up.
(I've tried to search for the answers...)

This issue is all about the terms as I am getting a little bit confused.

We have got an album defined with TITLE and DESCRIPTION.
Than there is a file defined with TITLE and DESCRIPTION.

but

Admin Mode - Config - Thumbnail view - Display file CAPTION (in addition to TITLE) below the thumbnail
in this option we can see two terms - CAPTION and TITLE, but setting NO will actually hide DESCRIPTION of the file

and

after looking in the code - $template_thumbnail_view, we see this

Code: [Select]
// HTML template for thumbnails display
$template_thumbnail_view = <<<EOT

<!-- BEGIN header -->
        <tr>
<!-- END header -->
<!-- BEGIN thumb_cell -->
        <td valign="top" class="thumbnails" width ="{CELL_WIDTH}" align="center">
                <table width="100%" cellpadding="0" cellspacing="0">
                        <tr>
                                <td align="center">
                                        <a href="{LINK_TGT}">{THUMB}<br /></a>
                                        {CAPTION}
                                        {ADMIN_MENU}
                                </td>
                        </tr>
                </table>
        </td>
<!-- END thumb_cell -->

where token {CAPTION} is actually the TITLE and DESCRIPTION of the file together.

And I don't really understand to the option
Admin Mode - Config - Thumbnail view - Display album description (Toggles the display of the album description below each album thumbnail.)

Whatever I do (Yes or No) dosn't do any difference. What does it actully show/hide and where?

I suppose would be handy to explain us this options.

It's easy to hide 'file description' through the config option, but what if someone wants to display 'file title' above thumbnail and 'file description' under it? Don't think it's possible without something extra.

It's also easy to hide 'file title' just removing {CAPTION} token from $template_thumbnail_view.

So there is just one question in this thread, maybe a little bit to explain and possible some ideas for next release (more intuitive texts in config, dividing token {CAPTION} to {FILE_TITLE} and {FILE_DESC}).

Please let me know if I missed something.

Thank you
« Last Edit: August 25, 2007, 01:41:31 pm by GauGau »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: file CAPTION vs. file DESCRIPTION vs. album DESCRIPTION
« Reply #1 on: August 11, 2006, 03:16:05 pm »

The config option "Display file caption below thumbnail" should make it quite obvious: it refers to the file caption, not the album caption.
The code snippet from your custom theme that you refered to relates to the thumbnail that represents the album. It is not related to what you're looking for.
Logged

tomaash

  • Coppermine newbie
  • Offline Offline
  • Posts: 5
Re: file CAPTION vs. file DESCRIPTION vs. album DESCRIPTION
« Reply #2 on: August 11, 2006, 04:35:39 pm »

Quote
The config option "Display file caption below thumbnail" should make it quite obvious: it refers to the file caption, not the album caption.

Of course it doesn't refer to the album caption. I didn't say that. I say it doesn't refer to the file title but to the file description. There is no way to hide file title with config option.
You have to modify theme.php - $template_thumbnail_view. That template really controls thumbnails page not thumbnail that represents the album (that is in $template_album_list).

But the only question was about config option Display album description.
What does it actully show/hide and where?

Thank you

Logged

Nibbler

  • Guest
Re: file CAPTION vs. file DESCRIPTION vs. album DESCRIPTION
« Reply #3 on: August 11, 2006, 10:18:41 pm »

It doesn't appear to actually do anything. It is a mythical feature. Moving to bugs board for investigations.

tarique ?
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: file CAPTION vs. file DESCRIPTION vs. album DESCRIPTION
« Reply #4 on: August 12, 2006, 07:44:18 am »

As far as I remember it is a not-implemented feature. There used to be plans to have the album description displayed on displayimage.php, but it never was implemented afaik. So the option in coppermine's config simply will do nothing. As this is related to the language file, it's hard to come up with a fix wthat doesn't have an impact on all translations. I suggest marking it as "known issue" and adding reference to it in coppermine's docs for cpg1.4.9
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: file CAPTION vs. file DESCRIPTION vs. album DESCRIPTION
« Reply #5 on: August 25, 2007, 01:41:16 pm »

From the other thread that deals with the same issue:
For cpg1.4.x: committed a change to most languages that will keep the option from being displayed, as it doesn't do anything. Will be in cpg1.4.13

For cpg1.5.0: set status of option to "hidden" in include/admin.inc.php. No change of language file needed. Will be in cpg1.5.0.

Marking thread as fixed.
Marking this thread as "fixed" as well.
Logged
Pages: [1]   Go Up
 

Page created in 0.017 seconds with 21 queries.