Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: mod for zipdownload.php  (Read 7079 times)

0 Members and 1 Guest are viewing this topic.

sjordan

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 52
mod for zipdownload.php
« on: August 02, 2006, 01:11:40 am »

Hello,

My users and I were having trouble with the zipdownload feature on macs. The downloaded zip file opened successfully on linux and Windows, but mac users trying to use Stuffit to open the generated zip files were getting errors.

I tracked this down to archive.php in include folder.

Devin Doucette, the creator of the archive functionality upon which CPG's archive.php is built has a new version of his code out, Copyright (c) 2005.

I replaced the current version of archive.php and modified zipdownload.php to work with it.

Things seem to now work for linux, Windows and mac users.

I've included both files in the attached zip. I've alse included the original readme from Devin Doucette's new code.

If it helps you, please have at it. (Remember to back up your current files)

Moderators/Devs, feel free to move this to mods if you find it worthy and you can confirm that ...

1. It helps mac users.
2. Doesn't break the experience for anyone else.

Cheers.

CPG v. 1.4.8
« Last Edit: December 27, 2006, 09:25:39 am by GauGau »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: mod for zipdownload.php
« Reply #1 on: August 02, 2006, 07:25:21 am »

@sjordan: thanks for sharing

@devs: should this go into stable and devel or only into devel?
Logged

sjordan

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 52
Re: mod for zipdownload.php
« Reply #2 on: August 02, 2006, 08:27:57 am »

@Gaugau: My pleasure. I've got a lot from CPG. I've now given something back.
Logged

Abbas Ali

  • Administrator
  • Coppermine addict
  • *****
  • Country: in
  • Offline Offline
  • Gender: Male
  • Posts: 2165
  • Spread the PHP Web
    • Ranium Systems
Re: mod for zipdownload.php
« Reply #3 on: August 02, 2006, 10:47:34 am »

Imo, should go in both as it is not a new feature.
Logged
Chief Geek at Ranium Systems

sjordan

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 52
Re: mod for zipdownload.php
« Reply #4 on: August 30, 2006, 07:52:19 pm »

Hello,

It seems this mod did not make it into the recent release v 1.4.9

Did it fail your QA testing? I would like to know if my code changes didn't work so that I can improve them.

As reported to me, mac users were having difficulty prior to the upgrade in archive.php I included with this mod.

Hope it helps.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: mod for zipdownload.php
« Reply #5 on: August 31, 2006, 05:52:22 am »

Threads on the bugs board that are not labelled as "fixed" haven't made it into the subversion repository and subsequently not into a release. It's the sheer number of workload that kept the devs from adding it to the core in time for the release of cpg1.4.9.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: mod for zipdownload.php
« Reply #6 on: December 27, 2006, 09:25:20 am »

Committed suggested fix to devel and stable banch. Subsequently, the updated code will be in cpg1.5.0 and cpg1.4.11. Marking thread as "fixed". Mac users: please confirm.
Logged
Pages: [1]   Go Up
 

Page created in 0.019 seconds with 19 queries.