Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1] 2   Go Down

Author Topic: Last uploaded/random pictures still shows in main, even if album is protected  (Read 16268 times)

0 Members and 1 Guest are viewing this topic.

trex_daemon

  • Coppermine newbie
  • Offline Offline
  • Posts: 13

I have a problem, and i don't know how to solve it.

I am running cpg1.4.6. (latest release so far) and i have set up a few albums. Some of them are public, some of them are password protected.
The problem is, if i pasword protect an album, the thumbnails are still shown in main for last uploaded pic, or random pic.  It's true, when i click on it, it asks for password, so the normal image can't be viewed. But is there a possibility to show on the main page only the thumbnails of the last modified pictures/random pictures etc. for the unprotected albums only ??

« Last Edit: June 04, 2006, 11:24:17 pm by Paver »
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149

I was unable to replicate. I created a password protected album and uploaded a file. While logged in as admin, I saw the thumb and was not asked for the password when I clicked on it.

When logged out, I did not see the thumb under Last Uploaded. I can't confirm Random because I have too many files for that one thumb to randomly show up.
Logged

trex_daemon

  • Coppermine newbie
  • Offline Offline
  • Posts: 13

It's quite interesting.
I've created the album as root, and password protected it. I've uploaded a few pictures (batch upload) and then i've logged out.
Now, being unlogged, there is a public album, that is visible to all users, the other albums (including the one created above) are all private and password protected. However, in the "Last Addtions" tab, i can see the new thumbnails of the newly uploaded pictures to the private album. When i click on the thumbnail, it gives me an error message: "The selected album/file does not exist !".
But it's still showing the thumbnail.
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149

I tried again, using batch upload, and I still can't replicate. :-\

Could you post a link to your gallery and point out/describe the problem thumbs?
Logged

trex_daemon

  • Coppermine newbie
  • Offline Offline
  • Posts: 13

deleted
« Last Edit: June 01, 2006, 02:17:40 pm by trex_daemon »
Logged

trex_daemon

  • Coppermine newbie
  • Offline Offline
  • Posts: 13

deleted
« Last Edit: June 01, 2006, 02:17:56 pm by trex_daemon »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de

Unfortunatly, currently it's not up between  00:00 (GMT+2) and 09:00 (GMT+2)
Get decent webspace - it's cheap. I won't look into issues that can only be observed on a webserver that is only available at random times.
Logged

trex_daemon

  • Coppermine newbie
  • Offline Offline
  • Posts: 13

It's a webserver for a small company, and it's under developement. When all the services will be available, then  the server will be up 24h/24h.
It's not available at random times, it's not available  between 00:00 (GMT+2) and 09:00 (GMT+2).
And i don't think that availability time affects the functionality of Coppermine Photo Gallery.
I've observed an issue, and i thought it's a  good idea  to announce to the developement team, to help improve your product.
Anyways, thank you for your reply. I'll wait then for a bigger "company" to discover this issue, and maybe then it will be fixed in future releases.




Logged

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1609
  • Paul V.

There's no reason to get personal.  You explained your situation and I think it's reasonable.  There are other supporters in the community if some are unwilling to address certain issues.  Remember, we are all individuals here - even when we are working as a community, we each still have individual personalities that define us as persons instead of an automated support system.  We all want to investigate possible problems and help support issues users are having.

Please don't delete your posts.  If something changes, make a note in a further post.  If something is confusing in a past post, go ahead and edit it with a note at the end of the modified post saying what was changed - that way posts below make sense to people reading later.  All threads & posts are kept for historical reasons to help others who might run into the same issues.  Please respect this by using care in modifying past posts.

That being said, please post a link to your site again.  It's difficult for supporters to help if we cannot replicate the problem on our testbeds. 
Logged

Shazilk

  • Coppermine newbie
  • Offline Offline
  • Gender: Male
  • Posts: 9
    • Lady Cougar

First I would like to say hi and thanks for a brilliant script  ;)

I have tried several other photo progs, one I even purchased a licence for. Non compete with this, the install and help hints everywhere are excellent.... keep up the great work.

However I do have a small problem similar to what I think is being described above. I have just installed 1.4.6
I have both private and non private albums. When I am logged out and look at the random files I can see some thumbnails that are from within the private album, when clicked upon I get error: The selected album/file does not exist !

Any Suggestions please??
Logged
If only i could!!

Nibbler

  • Guest

Can we get a link ?
Logged

Shazilk

  • Coppermine newbie
  • Offline Offline
  • Gender: Male
  • Posts: 9
    • Lady Cougar
« Last Edit: June 02, 2006, 10:34:47 pm by Nibbler »
Logged
If only i could!!

Nibbler

  • Guest

Please don't post adult sites without warning.

This is a bug, but only appears when the private icon option is enabled.
Logged

Nibbler

  • Guest

Paver, please could you look into any possible side effects of http://forum.coppermine-gallery.net/index.php?topic=30894.0 in relation to this apparently  new bug ?
Logged

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1609
  • Paul V.

Yikes, I was wondering what may be the cause of this new series of bug reports.  The possibility that it was my commit is embarrassing and even more so that it was for fixing a notice message.  I thought I had tested the fix thoroughly, but right now, I'm not so sure.  I'll take a look at it tonight or at the latest this weekend.

I'm thinking for the future that notice fixes should only be committed to devel.  Sorry about that.
Logged

Shazilk

  • Coppermine newbie
  • Offline Offline
  • Gender: Male
  • Posts: 9
    • Lady Cougar

Please don't post adult sites without warning.

My Apologies, I wish no one any offence and certainly will not be offended if you remove that link.

So from current response I assume this is a bug and not something I have done  :-[

I will watch here carefully for any further response or advice.





Logged
If only i could!!

Nibbler

  • Guest

For now you can reverse the code change mentioned in the bug thread I linked to above. Adult links are fine so long as you post a warning.
Logged

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1609
  • Paul V.

Ok.  As far as I can tell, this bug is due to a mis-used $cpg_show_private_album in the function I modified here.  This variable is set in index.php:
Code: [Select]
$cpg_show_private_album = ($CONFIG['allow_private_albums'])?($CONFIG['show_private']):(true);
It's meant to allow private albums to show up in the index list but not be accessible any further.  So it should not be used as a bypass in setting $META_ALBUM_SET which is used by the last-uploaded and random blocks.

So, replace this line in function get_meta_album_set() in functions.inc.php:
Code: [Select]
if (($cpg_show_private_album || $USER_DATA['can_see_all_albums']) && $cat == 0) {with this line:
Code: [Select]
if ($USER_DATA['can_see_all_albums'] && $cat == 0) {
Although not necessary functionally (but will be done in the commit), you can also remove $cpg_show_private_album from the global line in the same function to restore it to what it was before my misguided fix, as shown:
Code: [Select]
global $USER_DATA, $FORBIDDEN_SET_DATA, $CONFIG;
So, before the misguided fix, $cpg_show_private_album was not available to get_meta_album_set() function and that was a good thing because it should not have been there.

For those who have this problem, please try the 2-line fix and report your results.
Logged

Shazilk

  • Coppermine newbie
  • Offline Offline
  • Gender: Male
  • Posts: 9
    • Lady Cougar

Excellent..... you are a star sir  :)

I changed the 2 lines as you stated and it looks good to me.

Thank You both Nibbler & Paver
Logged
If only i could!!

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1609
  • Paul V.

A star after being a goat - I guess that's better than never being a star . . .  :-X
Logged
Pages: [1] 2   Go Up
 

Page created in 0.025 seconds with 20 queries.