Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Fixed 2 bugs in Fruity theme - option color and dropshadow placement  (Read 5590 times)

0 Members and 1 Guest are viewing this topic.

flar

  • Coppermine newbie
  • Offline Offline
  • Posts: 13

I've been using the fruity theme as it fits in fairly well with the rest of my web site.  Unfortunately I ran into 2 bugs in the theme, one problematic, and the other minor.

The first bug is that the color used for the radio button options in forms matches the background color behind it on the admin tools screen.  The result is that you see the radio buttons, but no text for the options.  The color chosen (green) works OK on the backgrounds used on the other screens with radio buttons, but the admin tools section has some options appearing on the same green background.  It would be nice if the util.php file used a different style for these options since they appear in a different context than the other options used elsewhere, but I wanted to isolate my changes to the theme so I chose the following modification (in "diff -u" format):

Code: [Select]
--- ../fruity.orig/style.css       Sat Apr 22 00:22:56 2006
+++ ./style.css Sat Apr 22 01:00:38 2006
@@ -22,6 +22,7 @@
 /* #000000 = RBG   0,  0,  0 = (black)         */
 /* #FFA600 = RGB 255,166,  0 = (orange)        */
 /* #6BBE10 = RGB 107,190, 16 = (green)         */
+/* #1B2D04 = RGB  27, 45,  4 = (dark green)    */
 /* #FFFF00 = RGB 255,255,  0 = (yellow)        */
 /* #D1D7DC = RGB 209,215,220 = (light grey)    */
 /* #F7F37B = RGB 247,243,123 = (light yellow)  */
@@ -589,7 +590,7 @@
 }
 
 .clickable_option {
-        color: #6BBE10;
+        color: #1B2D04;
         font-weight: bold;
 }


The other problem was that the dropshadow of the border was not lining up on all screens.  Some of the screens seemed to allow the bottom left corner of the border decorations to abbreviate the curvy border images.  The following changes to the template file (again in diff -u format) fixed the problem:

Code: [Select]
--- ../fruity.orig/template.html   Sat Apr 22 00:22:56 2006
+++ ./template.html     Sat Apr 22 01:01:14 2006
@@ -78,34 +78,20 @@
       <td id="m41">
         <table border="0" cellspacing="0" cellpadding="0" width="100%">
           <tr>
-            <td style="background-color:#6BBE10">&nbsp;
-            </td>
+            <td style="background-color:#6BBE10">&nbsp;</td>
             <td style="background-image:url(themes/fruity/images/lb_left.gif);background-repeat:no-repeat" width="126">
-              <img src="themes/fruity/images/blind.gif" width="1" height="55" border="0" alt="" />&nbsp;
-            </td>
+              <img src="themes/fruity/images/blind.gif" width="126" height="59" border="0" alt="" /></td>
           </tr>
-        </table>
-      </td>
-      <td id="m42" style="background-image:url(themes/fruity/images/lb_right.gif);background-repeat:no-repeat">
-      </td>
-      <td id="m43">
-      </td>
-    </tr>
-    <tr>
-      <td id="m51">
-        <table border="0" cellspacing="0" cellpadding="0" width="100%">
           <tr>
-            <td style="background-image:url(themes/fruity/images/left_bottom_left.gif);background-repeat:repeat-x">&nbsp;
-            </td>
+            <td style="background-image:url(themes/fruity/images/left_bottom_left.gif);background-repeat:repeat-x">&nbsp;</td>
             <td style="background-image:url(themes/fruity/images/lb_bottom.gif);background-repeat:no-repeat" width="126">
-              <img src="themes/fruity/images/blind.gif" width="1" height="6" border="0" alt="" />&nbsp;
-            </td>
+              <img src="themes/fruity/images/blind.gif" width="126" height="6" border="0" alt="" /></td>
           </tr>
         </table>
       </td>
-      <td id="m52">
+      <td id="m42" style="background-image:url(themes/fruity/images/lb_right.gif);background-repeat:no-repeat">
       </td>
-      <td id="m53">
+      <td id="m43">
       </td>
     </tr>
   </table>

Hope that helps others.  Let me know if I can express these modifications in a better format...
« Last Edit: May 13, 2006, 11:03:54 am by GauGau »
Logged

flar

  • Coppermine newbie
  • Offline Offline
  • Posts: 13
Re: Fixed 2 bugs in Fruity theme - option color and dropshadow placement
« Reply #1 on: April 23, 2006, 08:07:43 am »

Here is the first fix in the style that is used in other fixes found on this forum:

In themes/fruity/style.css, find (near line 590):
Code: [Select]
.clickable_option {
        color: #6BBE10;
        font-weight: bold;
}
and replace it with:
Code: [Select]
.clickable_option {
        color: #1B2D04;
        font-weight: bold;
}
(note that only the "color:" line changed)

You may or may not want to also add the following line near the top of the file in the "Colors used" section (near line 25):
Code: [Select]
/* #1B2D04 = RGB  27, 45,  4 = (dark green)    */
Logged

flar

  • Coppermine newbie
  • Offline Offline
  • Posts: 13
Re: Fixed 2 bugs in Fruity theme - option color and dropshadow placement
« Reply #2 on: April 23, 2006, 08:12:26 am »

Here is the second fix also in the format used elsewhere on this forum:

Find these lines near line 78 in themes/fruity/template.html:
Code: [Select]
      <td id="m41">
        <table border="0" cellspacing="0" cellpadding="0" width="100%">
          <tr>
            <td style="background-color:#6BBE10">&nbsp;
            </td>
            <td style="background-image:url(themes/fruity/images/lb_left.gif);background-repeat:no-repeat" width="126">
              <img src="themes/fruity/images/blind.gif" width="1" height="55" border="0" alt="" />&nbsp;
            </td>
          </tr>
        </table>
      </td>
      <td id="m42" style="background-image:url(themes/fruity/images/lb_right.gif);background-repeat:no-repeat">
      </td>
      <td id="m43">
      </td>
    </tr>
    <tr>
      <td id="m51">
        <table border="0" cellspacing="0" cellpadding="0" width="100%">
          <tr>
            <td style="background-image:url(themes/fruity/images/left_bottom_left.gif);background-repeat:repeat-x">&nbsp;
            </td>
            <td style="background-image:url(themes/fruity/images/lb_bottom.gif);background-repeat:no-repeat" width="126">
              <img src="themes/fruity/images/blind.gif" width="1" height="6" border="0" alt="" />&nbsp;
            </td>
          </tr>
        </table>
      </td>
      <td id="m52">
      </td>
      <td id="m53">
      </td>

and replace them with:

Code: [Select]
      <td id="m41">
        <table border="0" cellspacing="0" cellpadding="0" width="100%">
          <tr>
            <td style="background-color:#6BBE10">&nbsp;</td>
            <td style="background-image:url(themes/fruity/images/lb_left.gif);background-repeat:no-repeat" width="126">
              <img src="themes/fruity/images/blind.gif" width="126" height="59" border="0" alt="" /></td>
          </tr>
          <tr>
            <td style="background-image:url(themes/fruity/images/left_bottom_left.gif);background-repeat:repeat-x">&nbsp;</td>
            <td style="background-image:url(themes/fruity/images/lb_bottom.gif);background-repeat:no-repeat" width="126">
              <img src="themes/fruity/images/blind.gif" width="126" height="6" border="0" alt="" /></td>
          </tr>
        </table>
      </td>
      <td id="m42" style="background-image:url(themes/fruity/images/lb_right.gif);background-repeat:no-repeat">
      </td>
      <td id="m43">
      </td>
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Fixed 2 bugs in Fruity theme - option color and dropshadow placement
« Reply #3 on: April 24, 2006, 02:37:26 pm »

thanks for posting this in alternative notation as well - most end users are not familiar with diffs, so the second one is better for this board. Will look into this asap.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de

applied suggested fixes to stable and devel branch of svn. Thanks for spotting.
Logged
Pages: [1]   Go Up
 

Page created in 0.028 seconds with 19 queries.