Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Two bugs that i found...  (Read 3459 times)

0 Members and 1 Guest are viewing this topic.

tempzerg

  • Coppermine newbie
  • Offline Offline
  • Posts: 2
Two bugs that i found...
« on: January 12, 2004, 05:26:01 am »

When i choose Turkish as my language i get this error
Code: [Select]
Parse error: parse error, expecting `')'' in /home/groups/c/co/coppermine/htdocs/demo/lang/turkish.php on line 328
this is the error from your demo.

also when i list my photos by rating, a photo with 3.5 rating comes before a photo with rating 4 but with less votes.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Two bugs that i found...
« Reply #1 on: January 12, 2004, 10:29:41 am »

Quote from: "tempzerg"
When i choose Turkish as my language i get this error
Code: [Select]
Parse error: parse error, expecting `')'' in /home/groups/c/co/coppermine/htdocs/demo/lang/turkish.php on line 328
this is the error from your demo.

Thanks for letting us know - has been fixed in the demo, will go into the next release. I uploaded a fixed turkish language version to the download area. To solve this issue for you, edit /lang/turkish.php with a plain text editor (notepad will do), find the line starting with
Quote
'date_d' =>
and remove the last ","

--------------------------------

Quote from: "tempzerg"
also when i list my photos by rating, a photo with 3.5 rating comes before a photo with rating 4 but with less votes.
Please provide a deep link, so we can take a look.

GauGau

P.S. next time, please post two separate threads for different issues
Logged

tempzerg

  • Coppermine newbie
  • Offline Offline
  • Posts: 2
Two bugs that i found...
« Reply #2 on: January 12, 2004, 03:25:32 pm »

i had already corrected the bug with the turkish language file...

about the secound bug

http://coppermine.sourceforge.net/demo/thumbnails.php?album=toprated&cat=-6

the first photo has a rating of 3.5 and the second 4, so ranking is wrong...

i changed
Code: [Select]
ORDER BY ROUND((pic_rating+1)/2000) DESC
on line 647 in functions.inc.php
with
Code: [Select]
ORDER BY pic_rating DESC

now the ratings work fine for me...

while sorting the script shouldn't round the rating...
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Two bugs that i found...
« Reply #3 on: January 13, 2004, 05:06:46 am »

created tracker #875865 on this issue.

GauGau
Logged
Pages: [1]   Go Up
 

Page created in 0.017 seconds with 14 queries.