Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: $extra_info var if used by a plugin repeats for other plugins that come after it  (Read 6357 times)

0 Members and 1 Guest are viewing this topic.

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray

$extra_info var if used by a plugin repeats for other plugins that come after it in pluginmgr.php.

I also think $extra should only be displayed for installed plugins. That would allow for plugin related links so we wouldn't have to usurp space on the admin menu, unless we really wanted to.

the var should be changed to $extra to match the other vars allowed in configuration.php, and it should be cleared as the $author var is.

There is no official documentation for the $extra_info var, and it's not used in any of the samples, I think we can safely change its behavior in a maintenance release.

If another dev has time or inclination your more than welcome to tackle it, otherwise I'll tackle it when I get a chance.
« Last Edit: August 13, 2006, 08:27:53 pm by donnoman »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de

*bump*
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de

Bumping thread to top once more.
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray

There are actually two variables that have this broken behavior.

$extra_info and $install_info

The variables weren't being cleared as coppermine looped through the configurations.

The intent of these optional strings appears to be to allow plugin writers to add extra content with the plugin entry on pluginmgr.php.

I've committed a fix that includes some cosmetic changes and a sample implementation of these strings with the sample plugin into devel. 

If there's no objection I can commit the same changes to stable. This is a bugfix and some minor cosmetic changes, not a new feature.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de

Yes, please go ahead.
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray

stable comitted.
Logged
Pages: [1]   Go Up
 

Page created in 0.022 seconds with 20 queries.