Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Checkbox "Read EXIF info again" Not Implemented  (Read 4771 times)

0 Members and 1 Guest are viewing this topic.

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1609
  • Paul V.
Checkbox "Read EXIF info again" Not Implemented
« on: November 24, 2005, 02:32:49 am »

I think I've exhaustively searched for this, but maybe the issue is that most people don't need this function.  In "editOnePic.php", the checkbox for "Read EXIF info again" is not implemented.  I've checked the latest CVS versions of both 1.3 and 1.4 and in both, the variable $read_exif is assigned to the checkbox value but then nothing is done with it.  Since the traditional EXIF operation is to grab the data only when viewing the normal image for the first time (and not on upload unless you are using the "sort by EXIF date" mod), I assume the implementation would be to remove the relevant record from the cpg_exif table and then let the data be grabbed again next time the image is viewed.  But maybe since the checkbox is "Read EXIF info again", the EXIF info should be read immediately in the editOnePic.php script.  I can write up the fix if necessary but I figured the developers should decide first how a feature not implemented but clearly intended to be implemented should be implemented ... if that makes any sense.
« Last Edit: February 22, 2006, 04:43:07 pm by Paver »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Checkbox "Read EXIF info again" Not Implemented
« Reply #1 on: February 20, 2006, 08:14:16 am »

for the stable branch I suggest commenting the box out, a possible "real" fix should go into the devel banch imo, as any implementation would be a new feature that needs testing.
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: Checkbox "Read EXIF info again" Not Implemented
« Reply #2 on: February 20, 2006, 08:19:19 am »

Commit it in the devel
Logged
SANIsoft PHP applications for E Biz

Paver

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 1609
  • Paul V.
Re: Checkbox "Read EXIF info again" Not Implemented
« Reply #3 on: February 22, 2006, 04:48:36 am »

As GauGau suggested, I commented out the checkbox and variable in stable.  I haven't touched devel yet.

edit: Marking 'fixed' here, will add to to-do list for 1.5.
« Last Edit: February 22, 2006, 04:43:47 pm by Paver »
Logged
Pages: [1]   Go Up
 

Page created in 0.015 seconds with 20 queries.