As I worked on a style for my homepage I recognized some things that should get under your consideration (incomplete list ... those I can remember right now
).
- Admin Menu -> Settings -> Last row (where the annotation are written down: "(*) Felder, die" and so on):
class tableh2 isn't the best, if you're using a background image for this css class. I would set a new class for this instead.
- ... same for Admin Menu -> Groups -> Head row (class tableh1) - not the best with background image
- function $template_display_picture -> {ADMIN_MENU}:
class admin_menu is set for the <a> tag instead of making a tag with the class admin_menu around the <a> tags (like it should be). Currently you have to modified the style.css (i.e. adding a.admin_menu) or the theme.php to have a similar look with the other admin menues.
- function $template_album_list_cat, $template_album_list:
The class maintable as a standard table class around these functions greatly harms the "designing freedom" (english' not my foreign lang). I would prefer a new class for this. I had to close the table to realize the things I want but the disadvantage by doing this is that Opera draws horizontal lines of the closed tables (bug in Opera that displays also empty tags)
The part (c_)empty_cell is unnecessary.
The row
<tr>
<td colspan="3">
<img src="images/spacer.gif" width="1" height="1" alt=""><br />
</td>
</tr>
is unnecessary and appears wrong in IE (spacing is too big in height).
[/list]
Furthermore it would be wonderful if
- the image info box could be edited (what is shown there) within the theme.php
- and if the theme-scripter could set the order of navmenu, info box, comment box and the image itself.
I should add that I didn't wanted to change anything on the php functions "outside" the theme.php. Maybe you should heed this by reading the annotations.
