Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: 1 [2]   Go Down

Author Topic: Spaces in filenames issue  (Read 11356 times)

0 Members and 1 Guest are viewing this topic.

Aditya Mooley

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 781
    • My Sweet Home
Re: Spaces in filenames issue
« Reply #20 on: September 22, 2005, 07:29:42 am »

Why sorry Dennis? I am rather thankful to you that you are testing the code thoroghly.
I will try to fix this as soon as possible.
Logged
--- "Its Nice 2 BE Important but its more Important 2 Be NICE" ---
Follow Coppermine on Twitter

Aditya Mooley

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 781
    • My Sweet Home
Re: Spaces in filenames issue
« Reply #21 on: September 22, 2005, 08:36:02 am »

Wasn't actually a bug in the code, but this was causing due to the extra security we give to variables from GET, POST.
Added a fix for this and committed to CVS.
Logged
--- "Its Nice 2 BE Important but its more Important 2 Be NICE" ---
Follow Coppermine on Twitter

artistsinhawaii

  • VIP
  • Coppermine addict
  • ***
  • Country: us
  • Offline Offline
  • Gender: Male
  • Posts: 856
    • evj art and photography
Re: Spaces in filenames issue
« Reply #22 on: September 22, 2005, 11:32:33 am »

Aditya,

Downloaded all files and tested again

1) tested renaming illegal characters during file batch add process
           test upload name                        converted name.
        Copy of Pan_001.jpg    => Copy_of_Pan_001.jpg     (success)
        Copy of Pan_001.jpg    => Copy_of_Pan_001~01.jpg  (success)
     1 2&3;4'Copy of Pan_001.jpg  => 1_2_3;4_Copy_of_Pan_001.jpg    (success ? ";")
 
 2) tested file renaming under edit picture properties.

original name                                  typed in name                      result
Copy_of_Pan_001.jpg > 1 Copy_of_Pan_001.jpg             > 1_Copy_of_Pan_001.jpg
Copy_of_Pan_001.jpg > 1 2&3;4'5 Copy_of_Pan_001.jpg  > 1_2_3;4_5_Copy_of_Pan_001.jpg

       Results are succesful ..for expected forbidden characters as long as ";"(semi-colons)   "," (commas) and "." (periods) are acceptable characters in filenames.  If ";"(semi-colons)   "," (commas) and "." (periods) are not acceptable then these need to be addressed.

Otherwise.  It all looks good.  All other forbidden characters were converted to spaces, or returned an error message if a duplicate filename existed when illegal character was converted to a space.

Great job!

Dennis


Logged
Learn and live ... In January of 2011, after a botched stent attempt, the doctors told me I needed a multiple bypass surgery or I could die.  I told them I needed new doctors.

Aditya Mooley

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 781
    • My Sweet Home
Re: Spaces in filenames issue
« Reply #23 on: September 22, 2005, 01:09:47 pm »

"." (periods) cannot be a forbidden character as it serves as the extension for the filename.
I tested ";"(semi-colons) and "," (commas) and it worked for me as always  ;D
Logged
--- "Its Nice 2 BE Important but its more Important 2 Be NICE" ---
Follow Coppermine on Twitter

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Spaces in filenames issue
« Reply #24 on: September 22, 2005, 03:35:58 pm »

Good work, all of you (both devs and tester)! Thanks. Marking as "fixed".
Logged
Pages: 1 [2]   Go Up
 

Page created in 0.018 seconds with 20 queries.