Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: comments/views/votes admin-settable  (Read 4491 times)

0 Members and 1 Guest are viewing this topic.

eke

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 42
comments/views/votes admin-settable
« on: November 28, 2003, 02:49:03 pm »

i'd like to point out that some might have the "views" number switched off and wouldn't those end up with a trailing "-" behind the caption?

if so, maybe the "-" should be moved to the language file
-> $lang_get_pic_data['n_views']) seems predestined for this.
That way everyone can format the "viewed" number the way they want...

remember, keep it flexible. having to search for and edit scripts to get rid of just one "-" is silly, isnt it.

btw: my lang vars look like this:
Code: [Select]

        'n_comments' => ' ',
        'n_views' => ' ',
        'n_votes' => ' '


since there's no way to disable these features in any config setting (would be nice if those find their way into the settings panel in a future version, i.e. default on/off for voting and comments)

cheers
eke.
Logged

eke

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 42
comments/views/votes admin-settable
« Reply #1 on: November 28, 2003, 03:05:13 pm »

oh btw:
the thumb_caption is used in two places.
in album view and in thumbnail view (if the option to display thumb_caption underneath thumbnails is turned on).

not a problem per se but from a layout point of view a bad idea since in these 2 views can have quite a different layout and then having one class both instances might well clash.
eg. in album view you want to contain the caption inside a div tag the height of the actual thumbnail and have it scroll instead of making the cell larger than the thumbnail (which would look eke). So the thumb_caption in album view would have a height: 100px; in the css and when in thumb view the thumb cell would be 100px larger than it should be since now the caption is displayed underneath the thumb.
basically having a #thumb_caption master class
and a #tumb_caption div.album subclass would be the most elegant solution for such layout issues.

Code: [Select]

#thumb_caption {
        font-size: 9px;
        padding: 3px;
        font-family: Verdana, Arial, Helvetica, sans-serif;
}
#thumb_caption div.album {
        display: block;
        position:relative;
        overflow:auto;
        height:100px;
}
#thumb_caption div.thumb {

}
#thumb_caption a {...
...


that way you give the user absolute control over the layout.
which is good :D (course that would mean to remove a lot of hardcoded layout stuff from the scripts first and add some div tags instead).

cheers
eke.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
comments/views/votes admin-settable
« Reply #2 on: November 28, 2003, 05:44:36 pm »

above two postings have originally been posted as reply to the thread
http://forum.coppermine-gallery.net/index.php?topic=1869
I split them, as they deal with a different issue.

@eke: you have good ideas, but please start a new thread for new issues (limiting thread drift to a minimum). Thanks.

GauGau
Logged

eke

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 42
comments/views/votes admin-settable
« Reply #3 on: November 28, 2003, 07:05:08 pm »

will keep it in mind, thanks for the split.

cheers
eke.
Logged

chyne

  • Coppermine newbie
  • Offline Offline
  • Posts: 2
comments/views/votes admin-settable
« Reply #4 on: December 01, 2003, 07:19:05 am »

This is how I dealt with removing the views from the captions:

http://forum.coppermine-gallery.net/viewtopic.php?p=9518#9518
Logged
Pages: [1]   Go Up
 

Page created in 0.02 seconds with 21 queries.