Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Uppercase HTML tags to lowercase  (Read 6027 times)

0 Members and 1 Guest are viewing this topic.

kaptainkory

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Posts: 51
Uppercase HTML tags to lowercase
« on: August 05, 2005, 10:42:09 pm »

Bringing some of the tags into XHTML compliance.  CVS from today.

In addfav.php, FIND (line 76):

Code: [Select]
pageheader($lang_info, "<META http-equiv=\"refresh\" content=\"1;url=$location\">");
REPLACE WITH (and also notice a change to the end bracket...):

Code: [Select]
pageheader($lang_info, "<meta http-equiv=\"refresh\" content=\"1;url=$location\" />");
In db_input.php, FIND (line 93):

Code: [Select]
            pageheader($lang_info, "<META http-equiv=\"refresh\" content=\"1;url=$redirect\">");
REPLACE WITH (and also notice a change to the end bracket...):

Code: [Select]
            pageheader($lang_info, "<meta http-equiv=\"refresh\" content=\"1;url=$redirect\" />");
In forgot_passwd.php, FIND (line 65):

Code: [Select]
        pageheader($lang_forgot_passwd_php['forgot_passwd'], "<META http-equiv=\"refresh\" content=\"3;url=login.php\">");
REPLACE WITH (and also notice a change to the end bracket...):

Code: [Select]
        pageheader($lang_forgot_passwd_php['forgot_passwd'], "<meta http-equiv=\"refresh\" content=\"3;url=login.php\" />");
In login.php, FIND (line 39):

Code: [Select]
        pageheader($lang_login_php['login'], "<META http-equiv=\"refresh\" content=\"3;url=$referer\">");
REPLACE WITH (and also notice a change to the end bracket...):

Code: [Select]
        pageheader($lang_login_php['login'], "<meta http-equiv=\"refresh\" content=\"3;url=$referer\" />");
In logout.php, FIND (line 36):

Code: [Select]
pageheader($lang_logout_php['logout'], "<META http-equiv=\"refresh\" content=\"3;url=$referer\">");
REPLACE WITH (and also notice a change to the end bracket...):

Code: [Select]
pageheader($lang_logout_php['logout'], "<meta http-equiv=\"refresh\" content=\"3;url=$referer\" />");
In mode.php, FIND (line 46):

Code: [Select]
pageheader($lang_info, "<META http-equiv=\"refresh\" content=\"1;url=$referer\">");
REPLACE WITH (and also notice a change to the end bracket...):

Code: [Select]
pageheader($lang_info, "<meta http-equiv=\"refresh\" content=\"1;url=$referer\" />");
In ratepic.php, FIND (line 120):

Code: [Select]
pageheader($lang_info, "<META http-equiv=\"refresh\" content=\"1;url=$location\">");
REPLACE WITH (and also notice a change to the end bracket...):

Code: [Select]
pageheader($lang_info, "<meta http-equiv=\"refresh\" content=\"1;url=$location\" />");
In init.inc.php, FIND (line 402):

Code: [Select]
    pageheader($lang_info, "<META http-equiv=\"refresh\" content=\"1;url=$referer\">");
REPLACE WITH (and also notice a change to the end bracket...):

Code: [Select]
    pageheader($lang_info, "<meta http-equiv=\"refresh\" content=\"1;url=$referer\" />");
In catmgr.php, FIND (line 456):

Code: [Select]
                        <textarea name="description" ROWS="5" COLS="40" SIZE="9"  WRAP="virtual" STYLE="WIDTH: 100%;" class="textinput">{$current_category['description']}</textarea>
REPLACE WITH:

Code: [Select]
                        <textarea name="description" rows="5" cols="40" size="9" wrap="virtual" style="width: 100%;" class="textinput">{$current_category['description']}</textarea>
In ecard.php, FIND (line 273):

Code: [Select]
                        <textarea name="message" class="textinput" ROWS="8" COLS="40" WRAP="virtual" onselect="storeCaret_post(this);" onclick="storeCaret_post(this);" onkeyup="storeCaret_post(this);" STYLE="WIDTH: 100%;">$message</textarea><br /><br />
REPLACE WITH:

Code: [Select]
                        <textarea name="message" class="textinput" rows="8" cols="40" wrap="virtual" onselect="storeCaret_post(this);" onclick="storeCaret_post(this);" onkeyup="storeCaret_post(this);" style="width: 100%;">$message</textarea><br /><br />
In editpics.php, FIND (line 356):

Code: [Select]
                        <textarea name="$name" ROWS="5" COLS="40" WRAP="virtual"  class="textinput" STYLE="WIDTH: 100%;" onKeyDown="textCounter(this, $max_length);" onKeyUp="textCounter(this, $max_length);">$value</textarea>
REPLACE WITH:

Code: [Select]
                        <textarea name="$name" rows="5" cols="40" wrap="virtual"  class="textinput" style="width: 100%;" onKeyDown="textCounter(this, $max_length);" onKeyUp="textCounter(this, $max_length);">$value</textarea>
In report_file.php, FIND (line 297):

Code: [Select]
<textarea name="message" class="textinput" ROWS="8" COLS="40" WRAP="virtual" onselect="storeCaret_post(this);" onclick="storeCaret_post(this);" onkeyup="storeCaret_post(this);" STYLE="WIDTH: 100%;">$message</textarea><br /><br />
REPLACE WITH:

Code: [Select]
<textarea name="message" class="textinput" rows="8" cols="40" wrap="virtual" onselect="storeCaret_post(this);" onclick="storeCaret_post(this);" onkeyup="storeCaret_post(this);" style="width: 100%;">$message</textarea><br /><br />
In usermgr.php, FIND (line 614):

Code: [Select]
                <textarea name="{$element[1]}" ROWS="7" WRAP="virtual"  class="textinput" STYLE="WIDTH: 100%">$value</textarea>
REPLACE WITH:

Code: [Select]
                <textarea name="{$element[1]}" rows="7" wrap="virtual"  class="textinput" style="width: 100%">$value</textarea>
Thanks.
« Last Edit: August 07, 2005, 09:31:42 am by GauGau »
Logged

kaptainkory

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Posts: 51
Re: Uppercase HTML tags to lowercase
« Reply #1 on: August 06, 2005, 12:45:08 am »

More...

There are a few more places in ecard.php and report_file.php that I didn't catch before.  Just search these files for "WIDTH" (case sensitive) to find them.

Thanks.
Logged

kaptainkory

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Posts: 51
Re: Uppercase HTML tags to lowercase
« Reply #2 on: August 06, 2005, 12:54:07 am »

I guess while some of the <textarea> tags are being looked at anyway...

These are proprietary attributes for that tag:

size
wrap

Maybe a style should be used instead?

Thanks.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Uppercase HTML tags to lowercase
« Reply #3 on: August 07, 2005, 09:31:20 am »

committed to cvs
Logged
Pages: [1]   Go Up
 

Page created in 0.021 seconds with 19 queries.