Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Invalid "id" attribute values in <input> tags in search.php  (Read 3815 times)

0 Members and 1 Guest are viewing this topic.

kaptainkory

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Posts: 51
Invalid "id" attribute values in <input> tags in search.php
« on: August 02, 2005, 03:47:20 am »

The characters [ and ] are not allowed in id values.

In search.php, FIND (line 78):

Code: [Select]
                                                <td><input type="checkbox" name="params[title]" id="params[title]" class="checkbox" checked="checked" /><label for="params[title]" class="clickable_option">{$lang_adv_opts['title']}</label></td>
FIND (line 82):

Code: [Select]
                                                <td><input type="checkbox" name="params[caption]" id="params[caption]" class="checkbox" checked="checked" /><label for="params[caption]" class="clickable_option">{$lang_adv_opts['caption']}</label></td>
FIND (line 86):

Code: [Select]
                                                <td><input type="checkbox" name="params[keywords]" id="params[keywords]" class="checkbox" checked="checked" /><label for="params[keywords]" class="clickable_option">{$lang_adv_opts['keywords']}</label></td>
FIND (line 91):

Code: [Select]
                                                <td><input type="checkbox" name="params[owner_name]" id="params[owner_name]" class="checkbox" /><label for="params[owner_name]" class="clickable_option">{$lang_adv_opts['owner_name']}</label></td>
FIND (line 98):

Code: [Select]
                                                <td><input type="checkbox" name="params[filename]" id="params[filename]" class="checkbox" /><label for="params[filename]" class="clickable_option">{$lang_adv_opts['filename']}</label></td>

Not knowing the code too well, I'll not suggest a fix at the risk of breaking something else.

Thanks.
« Last Edit: August 09, 2005, 09:07:17 am by GauGau »
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: Invalid "id" attribute values in <input> tags in search.php
« Reply #1 on: August 03, 2005, 07:15:13 am »

can another dev look into this, they also litter upload.php.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Invalid "id" attribute values in <input> tags in search.php
« Reply #2 on: August 03, 2005, 09:35:44 am »

committed a fix for the square brackets issue in search.php (files modified: search.php, thumbnails.php, include/search.inc.php). Please confirm fix.

Joachim

Please start a new thread for the issues in upload.php, as they require a different fix.
Logged
Pages: [1]   Go Up
 

Page created in 0.017 seconds with 20 queries.