Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Minor - nested emphasis in themes.inc.php  (Read 7468 times)

0 Members and 1 Guest are viewing this topic.

kaptainkory

  • Tester
  • Coppermine regular visitor
  • *
  • Offline Offline
  • Posts: 51
Minor - nested emphasis in themes.inc.php
« on: August 02, 2005, 02:56:41 am »

In themes.inc.php, FIND (line 242):

Code: [Select]
                <td colspan="3" class="tableh1" align="center"><span class="statlink"><b>{STATISTICS}</b></span></td>
REPLACE WITH:

Code: [Select]
                <td colspan="3" class="tableh1" align="center"><span class="statlink">{STATISTICS}</span></td>
This change avoids a nested emphasis warning.

Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: Minor - nested emphasis in themes.inc.php
« Reply #1 on: August 02, 2005, 04:58:57 am »

That must be a tidy warning, because that code is valid XHTML.

I did look at trying to clean that up a while back, but it happens all over the place, it's inherited from the orignal codebase and it's throughout user supported themes as well.

In addition it also requires changes to every style.css if you want to maintain the same look and feel, so I had decided to leave it as-is.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Minor - nested emphasis in themes.inc.php
« Reply #2 on: August 02, 2005, 09:01:44 am »

I agree with donnoman: with the <b> tag being on the list of tags that are suppossed to vanish anyway, let's do this in the next version. I moved this thread from "CPG 1.4 Testing/Bugs" to "Feature requests: Scheduled for cpg1.5.x"
Logged
Pages: [1]   Go Up
 

Page created in 0.022 seconds with 18 queries.