Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Comment notification emails  (Read 4779 times)

0 Members and 1 Guest are viewing this topic.

Owdy

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 46
    • My gallery
Comment notification emails
« on: March 13, 2005, 08:01:36 pm »

I dont want emails about my own comments. It doesnt make sense  :)
« Last Edit: April 10, 2005, 10:50:04 am by GauGau »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Comment notification emails
« Reply #1 on: March 14, 2005, 07:17:02 am »

You're right - this doesn't make sense. There has to be an additional check in the comment notification routine. I consider this a bug, not a feature request, so I moved this accordingly (from "feature requests" to "bugs").

Joachim
Logged

Nibbler

  • Guest
Re: Comment notification emails
« Reply #2 on: March 14, 2005, 03:21:38 pm »

This is harder than it looks btw.
Logged

nol33t

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 244
  • Exploring Coppermine in every directions
    • tieum's pics
Re: Comment notification emails
« Reply #3 on: March 14, 2005, 04:37:08 pm »

this problem doesn't apply for the admin only, i mean adding a check for USER_IS_ADMIN wouldn't be enough?

db_input.php
Code: [Select]
// Registered users, we can use Location to redirect
            $insert = cpg_db_query("INSERT INTO {$CONFIG['TABLE_COMMENTS']} (pid, msg_author, msg_body, msg_date, author_md5_id, author_id, msg_raw_ip, msg_hdr_ip) VALUES ('$pid', '" . addslashes(USER_NAME) . "', '$msg_body', NOW(), '', '" . USER_ID . "', '$raw_ip', '$hdr_ip')");
            $redirect = "displayimage.php?pos=" . (- $pid);
            if ($CONFIG['email_comment_notification']&& !USER_IS_ADMIN ) {

etc..

-matt-

Nibbler

  • Guest
Re: Comment notification emails
« Reply #4 on: March 14, 2005, 04:53:23 pm »

You have to allow for multiple admins, so all admins need to get the notification other than the admin who posted the comment.
Logged

nol33t

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 244
  • Exploring Coppermine in every directions
    • tieum's pics
Re: Comment notification emails
« Reply #5 on: March 14, 2005, 04:55:57 pm »

harder than it looks then ;)

--edit: depends the way you see the use of comment notification actually..if it's a way to check each comments content, i guess admins can trust each others..
« Last Edit: March 14, 2005, 05:09:31 pm by nol33t »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Comment notification emails
« Reply #6 on: March 14, 2005, 08:28:37 pm »

yes, I agree with nol33t: let's not make this too complicated and just add the simple check if a user is admin and that's it. Imo 95% of all coppermine installs do only have one admin user anyway.

Joachim
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Comment notification emails
« Reply #7 on: April 03, 2005, 02:00:14 pm »

*bump*: any dev care to assign this to himself/herself?

Joachim
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Comment notification emails
« Reply #8 on: April 10, 2005, 10:49:42 am »

comitted Matt's fix to devel branch. Marking as "fixed".

Joachim
Logged
Pages: [1]   Go Up
 

Page created in 0.059 seconds with 19 queries.