Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: [FIXED] Favorite Album Link option: Bug fixed report  (Read 4196 times)

0 Members and 1 Guest are viewing this topic.

ttn

  • Coppermine newbie
  • Offline Offline
  • Posts: 5
[FIXED] Favorite Album Link option: Bug fixed report
« on: November 14, 2003, 12:19:05 pm »

Description: In Config set option Picinfo display fav album link to NO, the whole Picture information block under the picture disappears without a trace.
The fix is very simple, in coppermine/displayimage.php, around line 300, replace this
Code: [Select]

            if ($CONFIG['picinfo_display_favorites']) {
                if (!in_array($CURRENT_PIC_DATA['pid'], $FAVPICS)) {
                    $info[$lang_picinfo['addFavPhrase']] = '<a href="' . $CPG_URL . '&file=addfav&pid=' . $CURRENT_PIC_DATA['pid'] . '" >' . $lang_picinfo['addFav'] . '</a>';
                } else {
                    $info[$lang_picinfo['addFavPhrase']] = '<a href="' . $CPG_URL . '&file=addfav&pid=' . $CURRENT_PIC_DATA['pid'] . '" >' . $lang_picinfo['remFav'] . '</a>';
                }
                if (USER_ID or $CONFIG['allow_anon_fullsize'] or USER_IS_ADMIN) {
                    return theme_html_picinfo($info);
                }
            }

with this
Code: [Select]

            if ($CONFIG['picinfo_display_favorites']) {
                if (!in_array($CURRENT_PIC_DATA['pid'], $FAVPICS)) {
                    $info[$lang_picinfo['addFavPhrase']] = '<a href="' . $CPG_URL . '&file=addfav&pid=' . $CURRENT_PIC_DATA['pid'] . '" >' . $lang_picinfo['addFav'] . '</a>';
                } else {
                    $info[$lang_picinfo['addFavPhrase']] = '<a href="' . $CPG_URL . '&file=addfav&pid=' . $CURRENT_PIC_DATA['pid'] . '" >' . $lang_picinfo['remFav'] . '</a>';
                }
            }
            if (USER_ID or $CONFIG['allow_anon_fullsize'] or USER_IS_ADMIN) {
                return theme_html_picinfo($info);
            }


Hardly see the difference? Well, just a tiny bracket got misplaced  :)
No need to copy/paste, just move the last bracket "}" at line 308 up 3 lines, that's it.

Coppermine is great. My warm regards to Nuke Dev Team: gtroll, DJMaze, kegobeer, ...

Cheers,
TTN
Logged
ThichTN

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
[FIXED] Favorite Album Link option: Bug fixed report
« Reply #1 on: November 14, 2003, 01:07:33 pm »

Hmmm.... I wonder  when was this implemented :?:  and who is to blame  :wink:
Logged
SANIsoft PHP applications for E Biz

ttn

  • Coppermine newbie
  • Offline Offline
  • Posts: 5
[FIXED] Favorite Album Link option: Bug fixed report
« Reply #2 on: November 14, 2003, 09:13:02 pm »

No blaming, or I won't report any more issue :-)
Just kidding. You guys have done a great job, Tarique, GauGau et al, for supporting Coppermine community. Keep up the good work.

Best Regards,
TTN
Logged
ThichTN
Pages: [1]   Go Up
 

Page created in 0.033 seconds with 18 queries.