Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: IP address showing in Last Viewed meta album  (Read 3997 times)

0 Members and 1 Guest are viewing this topic.

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
IP address showing in Last Viewed meta album
« on: March 09, 2005, 01:42:50 am »

Was it intentional to show the IP address of the latest visitors in the Last Viewed meta album?

I can understand if it's displayed for an admin but I don't think it should be displayed to regular users. I think it would also bring up support requests and privacy complaints.
« Last Edit: March 09, 2005, 10:21:57 pm by TranzNDance »
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: IP address showing in Last Viewed meta album
« Reply #1 on: March 09, 2005, 04:18:49 am »

probably wasn't intentional.

1.32 Just shows date/time.

It seems to make sense to me to make that admin only.  I don't see a lot of value for other folks to see that.

I'll take a look at making that happen.
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: IP address showing in Last Viewed meta album
« Reply #2 on: March 09, 2005, 04:56:20 am »

I caught a second problem with thumbnail captions in the last comment block; the body wasn't being bb_decoded and was being shown raw.

I was hesitant to just bb_decode comments on thumbnails in the caption since these are user contributed items and could be malicious. I didn't want them to be displayed without the report to admin function being readily available. So I run it through a strip_tags after bb_decode to hamstring any fancy stuff and hrefs.

This means just text will display on the thumbnails. It will be fully bb_decoded the other places it's displayed.

IP address display is now dependent on being in "Gallery_Admin_Mode".

fixes comitted.
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: IP address showing in Last Viewed meta album
« Reply #3 on: March 09, 2005, 10:21:45 pm »

Thanks, donnoman. :)
Logged
Pages: [1]   Go Up
 

Page created in 0.016 seconds with 19 queries.