Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: HTML-Errors in keyword_select.php  (Read 4602 times)

0 Members and 1 Guest are viewing this topic.

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
HTML-Errors in keyword_select.php
« on: February 18, 2005, 09:05:16 am »

Andi posted this in another thread - I separated it for better trackability:
Few HTML-Errors in this file:
  $Source: /cvsroot/coppermine/devel/keyword_select.php,v $
  $Revision: 1.5 $
  $Author: gaugau $
  $Date: 2004/12/30 06:59:00 $

- missing </head> end-Tag
- missing <body></body> Tag (start and end)
- missing doctype declaration
-Form and Table Tags are not closed in this else-part:
Code: [Select]
} else {
    echo "<b><font color='red'><b>Sorry, No keywords available !</b></font> ";
- Missing end-quote in this link: <a href='keyword_create_dict.php'>Regenerate Dictionary</a>
Hmm, and hole file is not multilingual... ;)

This needs fixing before the language files go out, someone please self-assign and fix.

Joachim
« Last Edit: February 21, 2005, 05:52:37 pm by GauGau »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: HTML-Errors in keyword_select.php
« Reply #1 on: February 18, 2005, 03:43:43 pm »

assigning this to myself, will commit asap.

Joachim
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: HTML-Errors in keyword_select.php
« Reply #2 on: February 19, 2005, 07:40:02 am »

committed to cvs. Please confirm fix.

Joachim
Logged

Andi

  • VIP
  • Coppermine regular visitor
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 85
  • Join the Future
    • www.pragmamx.org
Re: HTML-Errors in keyword_select.php
« Reply #3 on: February 19, 2005, 02:01:12 pm »

uups:
Quote
Parse error: parse error, unexpected T_STRING in D:\Localhost\dev-Coppermine\devel\keyword_select.php on line 95
  $Source: /cvsroot/coppermine/devel/keyword_select.php,v $
  $Revision: 1.6 $
  $Author: gaugau $
  $Date: 2005/02/19 06:39:16 $

EDIT:
And one additional error:
Quote
Notice: Undefined index: keywordId in D:\Localhost\dev-Coppermine\devel\keyword_select.php on line 43

changes see in attached file  ;)
« Last Edit: February 19, 2005, 02:24:32 pm by Andi »
Logged
hope, I could help you... :)

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: HTML-Errors in keyword_select.php
« Reply #4 on: February 21, 2005, 07:49:38 am »

committed your changes as suggested. Please confirm.

Joachim
Logged

Andi

  • VIP
  • Coppermine regular visitor
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 85
  • Join the Future
    • www.pragmamx.org
Re: HTML-Errors in keyword_select.php
« Reply #5 on: February 21, 2005, 04:01:37 pm »

Ok, now it's perfect ;)
Logged
hope, I could help you... :)
Pages: [1]   Go Up
 

Page created in 0.015 seconds with 20 queries.