Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: & in URL changing to & when logging in  (Read 3999 times)

0 Members and 1 Guest are viewing this topic.

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
& in URL changing to & when logging in
« on: February 16, 2005, 02:27:06 am »

Let's say I'm viewing an image in an album and decide to log in.

I get redirected to a URL where the & was changed to & and so the link is invalid and get the following message:
Quote
The selected album/file does not exist !

If I edit the & in the URL, it will work.

Just ran a CVS update today.
« Last Edit: February 23, 2005, 07:33:58 am by TranzNDance »
Logged

nol33t

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 244
  • Exploring Coppermine in every directions
    • tieum's pics
Re: & in URL changing to & when logging in
« Reply #1 on: February 23, 2005, 04:44:01 am »

That bug was starting to tickle me on my dev gallery, so in case nobody had the time to fix it yet ( checked at the CVS, don't look like ):

in login.php,

before to call
Code: [Select]
pageheader($lang_login_php['login'], "<META http-equiv=\"refresh\" content=\"3;url=$referer\">");

$referer has to have "&amp;" replaced by "&"

the nice way is to add before
Code: [Select]
$referer=html_entity_decode($referer);
however that function is for php >= 4.3

an every php version working fix is to add before the line
Code: [Select]
$referer=preg_replace("'&amp;'","&",$referer);

hope that helps
-matt-

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: & in URL changing to &amp; when logging in
« Reply #2 on: February 23, 2005, 06:09:42 am »

committed fix as suggested, please confirm.

Joachim
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: & in URL changing to &amp; when logging in
« Reply #3 on: February 23, 2005, 07:33:44 am »

Thanks, it worked in IE, FF, Opera.
Logged
Pages: [1]   Go Up
 

Page created in 0.118 seconds with 18 queries.