Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Keywords from images in private albums visible  (Read 4297 times)

0 Members and 1 Guest are viewing this topic.

musikalg

  • Translator
  • Coppermine newbie
  • **
  • Offline Offline
  • Gender: Male
  • Posts: 17
Keywords from images in private albums visible
« on: February 06, 2005, 02:24:36 am »

I have enabled clickable keywords in search. If I use the seach function without logging in I can  still see keywords from pictures in private albums. If I click on them I just get "No image to display".
« Last Edit: March 01, 2005, 10:02:10 am by GauGau »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Keywords from images in private albums visible
« Reply #1 on: February 24, 2005, 10:30:31 am »

assigning this issue to me.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Keywords from images in private albums visible
« Reply #2 on: March 01, 2005, 07:45:33 am »

this is what I have come up with, although I don't think it is correct (notice the silly "WHERE" statement) - please review.
In include/keyword.in.php, I changed
Code: [Select]
$result = mysql_query("select keywords from {$CONFIG['TABLE_PICTURES']}");to
Code: [Select]
$result = mysql_query("select keywords FROM {$CONFIG['TABLE_PICTURES']} WHERE 1=1 $ALBUM_SET");It does what it is suppossed to do, but it doesn't look very elegant.

Joachim
« Last Edit: March 01, 2005, 09:56:27 am by GauGau »
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Keywords from images in private albums visible
« Reply #3 on: March 01, 2005, 08:25:19 am »

It seems to work.
Logged

nol33t

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 244
  • Exploring Coppermine in every directions
    • tieum's pics
Re: Keywords from images in private albums visible
« Reply #4 on: March 01, 2005, 08:29:17 am »

Quote
it doesn't look very elegant
i think it does ;)
didn't check the rest of the code but imho that's how album_set / forbidden_set etc.. should also be called/used, it's not silly at all

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Keywords from images in private albums visible
« Reply #5 on: March 01, 2005, 10:01:47 am »

OK, so I'm marking this as "fixed" then.

Joachim
Logged
Pages: [1]   Go Up
 

Page created in 0.038 seconds with 18 queries.