Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: 1 [2]   Go Down

Author Topic: Image Viewer  (Read 39533 times)

0 Members and 1 Guest are viewing this topic.

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Image Viewer
« Reply #20 on: January 26, 2005, 04:53:13 am »

Thanks everyone for all your help...seems to work ok in I.E. but unfortunetly not in Firefox ???
Really? I tested in Firefox and it worked fine until I checked in IE. Could you please post a link to your site?

by the way nice looking site TranzNDance-very clean and well thought out... ;)
Thank you. :)
Logged

dondo521

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 24
Re: Image Viewer
« Reply #21 on: January 26, 2005, 05:25:20 am »

Well it's not much of a site right now but here it is:
so the bots wont get this: just do the usual www thing and then
oceanwalkphotographers and then the dot com and then /owo

The only time it works in Firefox is when I refresh the page-but not when I move back and forth with the arrows

dondo521
Logged

rvblog

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 62
Re: Image Viewer
« Reply #22 on: January 26, 2005, 06:35:08 am »

@kegobeer:


In response to the question:

Quote
Verify you have this line in your theme.php file, in the pageheader function:
Code:
$template_vars = array('{LANG_DIR}' => $lang_text_dir,

Yes, the code that I have in the pageheader function section in the theme.php file is identical to that.


In response to this question:

Quote
I don't know if this is related, but if I view source on your page, this is displayed:
<html dir="{lang_dir}">

but it should be this:
<html dir="ltr">



The code that you refer to:

Code: [Select]
<html dir="{lang_dir}">
is located at the top of the template.html file - that piece of code was in there in the original hardwired theme, so I just left it there.

Should I remove it ?

Or, replace it with this:

Code: [Select]
<html dir="ltr">



Thanks

Logged

rvblog

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 62
Re: Image Viewer
« Reply #23 on: January 26, 2005, 06:39:25 am »

By the way,

I'm still getting the javascript error - any ideas why ??


On another note:

My content section (div class="content") is a long page under Firefox and a much shorter page under IE - is there a way to have the page appear as equal depth in both browsers ?
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Image Viewer
« Reply #24 on: January 26, 2005, 06:52:08 am »

Probably not related, but there were some errors in the code elsewhere:
Code: [Select]
themes/ardwired/images/buttoncenter.gif
Code: [Select]
<meta http-equiv="content-type" content="text/html; charset={charset}" />
If you correct the charset one, you can use W3C to validate the page and it could help pinpoint the issue. http://forum.coppermine-gallery.net/index.php?topic=13604.0
Logged

kegobeer

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 4637
  • Beer - it does a body good!
    • The Kazebeer Family Website
Re: Image Viewer
« Reply #25 on: January 26, 2005, 12:53:43 pm »

For some reason, {lang_dir} and {charset} aren't being parsed.  I'm not sure why, but the culprit is most likely your modified theme.  I think you'll have to compare it line-by-line with another theme to see where the problem may be.
Logged
Do not send me a private message unless I ask for one.  Make your post public so everyone can benefit.

There are no stupid questions
But there are a LOT of inquisitive idiots

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Image Viewer
« Reply #26 on: January 26, 2005, 01:04:10 pm »

It's because the parsing function is case-sensitive. If {lang_dir} and {charset} are made all uppercase, it will work. I tried it on my gallery, except went from upper to lower case and got the parsing failure.
Logged

rvblog

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 62
Re: Image Viewer
« Reply #27 on: January 26, 2005, 02:44:38 pm »

I went to W3C to use the validation feature there.

I checked out my site: www.rvadventure.ca/photos - and got all kinds of validation errors - wow !!


So, I  turned off my theme and turned on the original hardwired theme in the config panel - and W3C showed all kinds of errors as well

So, thinking it was an issue with the hardwired theme itself, I changed over to coppermine's eyeball theme - and guess what? - got all kinds of errors with that theme as well.

Then I changed to cpooermine's classic theme - and the same thing happened.

So, it appears that all of the theme templates that coppermine uses all have problems regarding validation at the W3C site

So what do I do now as far as a theme template - just ignore it ??

I've spent so much time on coppermine - I would hate to have to change to another gallery program.
Logged

rvblog

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 62
Re: Image Viewer
« Reply #28 on: January 26, 2005, 03:08:30 pm »

I spent some time checking other themes out

In all the packaged themes in coppermine, the template is this kind of doc type:

Code: [Select]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
So I went outside of the included themes and checked out other themes like reynolds, forest, 2bornot2b, etc and those templates has this kind of doc type:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

So, I uploaded those themes, selected each of them in the config panel - and all three themes only got 4 minor errors at the W3C validation site.

So I guess I'll have to change the base for my theme and see what happens.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Image Viewer
« Reply #29 on: January 26, 2005, 04:46:18 pm »

validation issues have been discussed elsewhere already. Just a short statement: both the cpg1.3.x core code as well as the themes that come with it will not validate, and it would take a huge effort to make them validate - I wouldn't recommend that. When you try validating some sites of "the big boys" (try MSN for a start ;)), the same thing happens: currently, there are only very few pages that actually validate properly. However, they stil are correctly displayed in most browsers. Some of the code that keeps them from validating even is in there to provide cross-browser compatibility. The next version of coppermine (the current devel version cpg1.4.x) will be standards compliant by default and will validate (xhtml transitional) - you're welcome to test it.
Bottom line is: I wouldn't worry to much about valid html for now - you will hardly find another gallery app that will actually produce valid code.

Joachim
Logged

kegobeer

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 4637
  • Beer - it does a body good!
    • The Kazebeer Family Website
Re: Image Viewer
« Reply #30 on: January 26, 2005, 04:58:49 pm »

@rvblog:

The hardwired template.html has {lang_dir} and {charset} - change them to {LANG_DIR} and {CHARSET} as Tranz suggests.
Logged
Do not send me a private message unless I ask for one.  Make your post public so everyone can benefit.

There are no stupid questions
But there are a LOT of inquisitive idiots

rvblog

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 62
Re: Image Viewer
« Reply #31 on: January 26, 2005, 05:23:21 pm »

OK then

I'll use what I have with the changes that have been suggested


When 1.4 comes out, will it I have to build a new theme again - or will it be a smooth transition from 1.3.2 to 1.4 ?


Any idea when 1.4 will be ready?

Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Image Viewer
« Reply #32 on: January 26, 2005, 05:44:30 pm »

When 1.4 comes out, will it I have to build a new theme again - or will it be a smooth transition from 1.3.2 to 1.4 ?
There will be instructions on how to update your custom theme to make it work with the new versions.

Any idea when 1.4 will be ready?
No. It currently is in beta stage. No telling when it will be ready as stable.

Joachim
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Image Viewer
« Reply #33 on: January 26, 2005, 06:48:34 pm »

Sorry, I wasn't saying the whole page should validate. I just thought the validation process could point out an error in the javascript that could help with troubleshooting.
Logged

rvblog

  • Coppermine regular visitor
  • **
  • Offline Offline
  • Posts: 62
Re: Image Viewer
« Reply #34 on: January 28, 2005, 02:53:36 am »

Second try:

The #topimage code was acting up every now and then, so I dropped that idea and decided to eliminate my header pic in order to move the imageviewer higher up on the screen.

I also dropped "hardwired" as a base for my theme and used the classic theme as my new base - but I stayed with and modified the hardwired template and I used part of the admin_menu layout and css that was in a theme called "forest" (don't remember where I found that theme).

I also got rid of the javascript error (don't ask me what I did - but after some trial and error it disappeared.

Anyways, I wanted my theme to be very simple and easy on the eyes - I also added my site navbar to easy navigation back and forth.

This is the new result: http://www.rvadventure.ca/photos/index.php

Now I can start uploading my photo files this weekend.

Thanks for everyone's help getting me this far.
Logged

snork13

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 260
  • Internet! Is that thing still around?
    • Gallery
Re: Image Viewer
« Reply #35 on: January 28, 2005, 02:56:28 am »

Looks nice. great work ;D
Logged

danjam

  • Coppermine newbie
  • Offline Offline
  • Posts: 1
Re: Image Viewer
« Reply #36 on: September 25, 2006, 12:40:06 pm »

You could always use a pure-JavaScript solution:

Here is an image viewer, in object-oriented, cross-browser JavaScript. Very easy to plug and play, with "slide show" feature, and fully customisable in CSS and HTML:

http://www.webonweboff.com/widgets/js/image_viewer.aspx

Article includes a demo, source code, explanations.

Hope this helps...
Logged

popersman

  • Coppermine novice
  • *
  • Offline Offline
  • Posts: 20
Re: Image Viewer
« Reply #37 on: November 26, 2006, 07:03:42 am »

Hi guys,
sorry to bump such an old thread, but I'm having issues with this workaround.
I'm no coder, even less of a designer, and i have a very basic understanding of how a script work.
I am using CPG 1.4.10 with a them called Avalanche.
The theme.php file included in the Avalanche theme is nearly empty, and doesn't contain all the lines of code that have been mentioning.
As an alternative, i tried to modify the theme.inc.php that can be found in the include folder, with no success.
Any idea on how to fix this?

Link to my gallery: http://ed.roquette.free.fr/photo/

Thanks!
Logged

Sami

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 3686
  • BMossavari
    • My Project
Re: Image Viewer
« Reply #38 on: November 26, 2006, 07:25:41 am »

I am using CPG 1.4.10 with a them called Avalanche.
Then create a new thread on proper board (cpg1.4 themes/skins/templates)

This one is locked...
Logged
‍I don't answer to PM with support question
Please post your issue to related board
Pages: 1 [2]   Go Up
 

Page created in 0.025 seconds with 20 queries.