Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Remove the styleguide theme from 1.4  (Read 4716 times)

0 Members and 1 Guest are viewing this topic.

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Remove the styleguide theme from 1.4
« on: March 06, 2005, 05:31:57 pm »

Styleguide currently isn't XHTML Valid, it is the only core theme that isn't.

I'm not really interested in making it XHTML Valid since I think its value is somewhat dubious to amature theme modifiers and it's quite complex.

I prefer to send people to one of the developer browser toolbars that do the same job and include a lot of other useful functions.

« Last Edit: March 09, 2005, 09:28:47 am by GauGau »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Remove the styleguide theme from 1.4
« Reply #1 on: March 07, 2005, 08:23:12 am »

I voted yes, as it is not standards compliant, hardly ever used and available (if everything else fails) on the demo page.

Joachim
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Remove the styleguide theme from 1.4
« Reply #2 on: March 07, 2005, 11:04:12 pm »

I agree. It's one less thing to maintain, too.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Remove the styleguide theme from 1.4
« Reply #3 on: March 08, 2005, 05:44:47 am »

OK, this is obvious: everybody wants it out - I'll remove it (since I was the one who introduced it in the first place) and make it a downloadable theme instead, with a disclaimer that the toolbars for the major browsers are recommended instead.

Joachim
« Last Edit: March 09, 2005, 09:29:01 am by GauGau »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Remove the styleguide theme from 1.4
« Reply #4 on: March 09, 2005, 09:31:43 am »

did as suggested and remove the styleguide files from the devel branch of the cvs. It is available for download instead: http://prdownloads.sourceforge.net/coppermine/cpg1.4.x_theme_styleguide.zip?download (with a section in the readme that explains why it has been removed and what we recommend to use instead).
However, I was not able to delete the styleguide folder within "themes", could anyone (who is more experienced in CVS usage) delete it for me? Thanks.

Joachim

P.S. unstickied this thread, marked it as "done" and locked the poll
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: Remove the styleguide theme from 1.4
« Reply #5 on: March 09, 2005, 09:39:31 am »

The styleguide folder isn't in my themes folder.
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: Remove the styleguide theme from 1.4
« Reply #6 on: March 09, 2005, 03:35:09 pm »

Mine is gone too Joachim, I think your dealing with a local issue, CVS appears to be fine.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Remove the styleguide theme from 1.4
« Reply #7 on: March 09, 2005, 05:09:00 pm »

k, thanks to both of you for your replies. Deleted the files locally, everything seems to be working as expected.

Joachim
Logged
Pages: [1]   Go Up
 

Page created in 0.048 seconds with 19 queries.