Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: Core.php in 1.4  (Read 2742 times)

0 Members and 1 Guest are viewing this topic.

Rodinou

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 346
  • Tournicoti, Tournicota
    • http://www.sortons.net
Core.php in 1.4
« on: January 12, 2005, 05:02:27 pm »

if you go to http://www.sortons.net/photos, you can see tables are not in the design (in displayimage.php ...)

But the big problem is to have "this", a lot of core php files are everywhere ...

the question is : in 1.4 the dev team would be release AN UNIQUE core php containing, like LANGUAGE file, all the possibilities of customization ?

Or it's planned for 2.0 ?!

The problem of this actual version is too many codes are everywhere to create ONE customization ... some {code} like this don't work if you don't declare in the right place core which is missing ...

I know I wrote it before, but it's too hard
« Last Edit: January 13, 2005, 09:26:49 am by GauGau »
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: Core.php in 1.4
« Reply #1 on: January 13, 2005, 12:23:26 am »

I "think" what you are saying is that the html templates are spread out into the code, and not all of them are in theme.php ready to be "themed"?

For example the ones in displayimage.php.

In particular several templates from displayimage.php have been moved into theme.php for 1.4.

We've also incorporated function and template fallback actions when processing themes. So that if a theme does not need to modify the new displayimage templates, they don't have to be added to that specific theme.php.

Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Core.php in 1.4
« Reply #2 on: January 13, 2005, 09:26:39 am »

anyway: cpg1.4 (aka the devel version) is currently under heavy construction, maybe you're just using an outdated cvs checkout (as the name "core.inc.php" you're refering to has changed as well). As you know, there's no support for it anyway, so I'm taking this to be a sort of "general discussion".
There can not be one core file that holds all possible modifications (theming, languages, code tweaks) - not with an app as complex as coppermine.

Joachim
Logged

Rodinou

  • Contributor
  • Coppermine frequent poster
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 346
  • Tournicoti, Tournicota
    • http://www.sortons.net
Re: Core.php in 1.4
« Reply #3 on: January 13, 2005, 12:55:51 pm »

We are ok on this point Gaugau

But for example TODAY, if you want to have page 1, 2, 3, 4, 5, 6 ... on the top of your page, you have to modify theme.php + displayimage.php ... are we OK ?!

The idea is ... to create our OWN displayimage ... for example ...

of my displayimage.php I don't want top menu ... perfect, I don't put it

I want my menu navigation is right on the pic (like me : and believe me, it's quite hard to do it !!! :) :) :)) ok I do it.

Coppermine is simply powerful. It's sure. But for designers, it's an incredible hell. For a lot of you, "a theme" is only change colors, font, size, numbers of the pic per page ... but I think if a core contains all possibilities of layout design .. I think everybody will win time : you because you are fed up with these questions like "where do I modifiy this line to change the width of the menu ?" .... and WE because one file controls the layout.

I'm OK a BIG MEGA GIGA core.php containing theme + layout + language is impossible (and even if it was possible, it would be not really readable !!!), but the only thing is to change a theme AS WE want, ONLY one file is needed (actually, several are needed, theme.php + displayimage.php + some others ...)

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47844
  • aka "GauGau"
    • gaugau.de
Re: Core.php in 1.4
« Reply #4 on: January 14, 2005, 12:16:05 am »

a different approach on theme engines is being discussed for cpg2.0. It's a pity for you that you can't participate in this discussion, but you left the dev team, remember :-[?

Joachim
Logged
Pages: [1]   Go Up
 

Page created in 0.027 seconds with 20 queries.