Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: small php-syntax errors  (Read 7484 times)

0 Members and 1 Guest are viewing this topic.

Andi

  • VIP
  • Coppermine regular visitor
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 85
  • Join the Future
    • www.pragmamx.org
small php-syntax errors
« on: December 24, 2004, 01:23:14 am »

Hi :)

in
searchnew.php,v 1.39 2004/12/12 10:24:05 gaugau
and
picmgr.php,v 1.11 2004/12/19 03:43:07 nibbler999

are some small syntax-errors like this sample:
Code: [Select]
$listArray[$list_count][cat] = $lang_search_new_php['albums_no_category'];
$listArray[$list_count][aid] = $row['aid'];
$listArray[$list_count][title] = $row['title'];
correct is:
Code: [Select]
$listArray[$list_count]['cat'] = $lang_search_new_php['personal_albums'];
$listArray[$list_count]['aid'] = $row['aid'];
$listArray[$list_count]['title'] = $row['title'];

EDIT:

and this:
Code: [Select]
        foreach ($listArray as $val) {
            if ($val[cat] != $alb_cat) {
          if ($alb_cat) $select .= "</optgroup>\n";
                $select .= '<optgroup label="' . $val[cat] . '">' . "\n";
                $alb_cat = $val[cat];
            }
            $select .= '<option value="' . $val[aid] . '"' . ($val[aid] == $sel_album ? ' selected' : '') . '>   ' . $val[title] . "</option>\n";

::: $val['cat'] / $val['aid']  /  $val['title']
« Last Edit: December 28, 2004, 06:48:42 am by GauGau »
Logged
hope, I could help you... :)

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: small php-syntax errors
« Reply #1 on: December 28, 2004, 06:48:28 am »

fixed in searchnew.php v1.41 and picmgr.php v1.12. As usual: well spotted, thanks for your hard work squashing those bugs :D.

Joachim
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: small php-syntax errors
« Reply #2 on: December 28, 2004, 07:07:46 am »

Seriously... I'm in awe of Andi's meticulousness. :) (http://tu2.net/forums/images/smiles/icon_thumbs_up.gif)
« Last Edit: January 15, 2006, 06:56:32 pm by TranzNDance »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: small php-syntax errors
« Reply #3 on: December 28, 2004, 07:18:21 am »

@Thu: hehe, had to look this word up ;)
@Andi: meticulousness means "Akribie", "(peinliche) Genauigkeit"

 ;D GauGau
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: small php-syntax errors
« Reply #4 on: December 28, 2004, 07:37:20 am »

I struggled to find just the right word to describe Andi's amazing ability so that was what came to mind. :)
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: small php-syntax errors
« Reply #5 on: December 28, 2004, 07:43:53 am »

Yes, Andi is indeed being really meticulous - Thanks Andi
Logged
SANIsoft PHP applications for E Biz

Andi

  • VIP
  • Coppermine regular visitor
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 85
  • Join the Future
    • www.pragmamx.org
Re: small php-syntax errors
« Reply #6 on: January 22, 2005, 07:28:42 pm »

Quote
@Andi: meticulousness means "Akribie", "(peinliche) Genauigkeit"

hehe :)

thx for this translation, i don't know this word  ::)
You know, my english is very bad....

But it's true, in this point i'm very meticulous.
That comes from the Coppermine transformation to vkpMx. I must compare every lines in a file when a new version comes from CVS. And i'm coding with php-setting error_reporting(E_ALL) to see and fix all the small errors....


ps. somewhat late
Happy New Year and best whishes to the Coppermine Team
Logged
hope, I could help you... :)
Pages: [1]   Go Up
 

Page created in 0.02 seconds with 18 queries.