Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: small typo errors in several files  (Read 5136 times)

0 Members and 1 Guest are viewing this topic.

Andi

  • VIP
  • Coppermine regular visitor
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 85
  • Join the Future
    • www.pragmamx.org
small typo errors in several files
« on: December 15, 2004, 06:31:34 pm »

Hi :)

I've found some very small typo errors:


in several theme.php's

------
false:
$template_tab_display = array('left_text' => '<td width="100%%" align="left" ....
ok:
$template_tab_display = array('left_text' => '<td width="100%" align="left" ....

------
sample in eyeball\theme.php at line #413
false:
<td>&nbsp&nbsp</td>
ok:
<td>&nbsp;&nbsp;</td>

------
theme.php,v 1.52 2004/12/13 14:21:10 nibbler999 line #544
theme.php,v 1.54 2004/12/13 14:21:11 nibbler999 line #541
theme.php,v 1.58 2004/12/13 14:21:17 nibbler999 line #607
theme.php,v 1.38 2004/12/13 14:21:22 nibbler999 line #519

false:
.... witdh="100%"....
ok:
.... width="100%".....


i know, this are not the actualy CVS-Versions but the errors are in all versions ;)



---------------------------------------------------------
usermgr.php,v 1.30 2004/12/12 10:24:05 gaugau
line #83
false:
$tab_tmpl = array('left_text' => '<td width="100%%" align="left" .......
ok:
$tab_tmpl = array('left_text' => '<td width="100%" align="left" .......

---------------------------------------------------------


And here are some "mystical" Links, don't know if they works correct in all situations?

keywordmgr.php,v 1.5 2004/12/12 10:24:05 gaugau

line #129 & #162
header("Location: ?page=display");

line #65
$word .= '<td class="tableb"><a href="?page=delete&remov='.$single_word......

line #84
<form name="keywordForm" action="?page=changeword" method="post">
« Last Edit: January 18, 2005, 08:41:33 am by GauGau »
Logged
hope, I could help you... :)

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: small typo errors in several files
« Reply #1 on: December 15, 2004, 07:30:06 pm »

false:
$template_tab_display = array('left_text' => '<td width="100%%" align="left" ....
ok:
$template_tab_display = array('left_text' => '<td width="100%" align="left" ....

This has been removed when doing the xhtml compliance, so only those not yet done still have this.

sample in eyeball\theme.php at line #413
false:
<td>&nbsp&nbsp</td>
ok:
<td>&nbsp;&nbsp;</td>

Thanks, I will fix.

false:
.... witdh="100%"....
ok:
.... width="100%".....

As first item, already fixed in compliant themes, rest done when they are prepared.

usermgr.php,v 1.30 2004/12/12 10:24:05 gaugau
line #83
false:
$tab_tmpl = array('left_text' => '<td width="100%%" align="left" .......
ok:
$tab_tmpl = array('left_text' => '<td width="100%" align="left" .......

Thanks, I will fix.

The others I don't know about.
« Last Edit: December 15, 2004, 07:46:02 pm by Casper »
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: small typo errors in several files
« Reply #2 on: December 15, 2004, 07:45:14 pm »

Items 2 and 4 above fixed and commited.  i found the &nbsp&nbsp error in 3 themes, thanks.

Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: small typo errors in several files
« Reply #3 on: December 28, 2004, 06:55:28 am »

@Casper: case closed?

Joachim
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: small typo errors in several files
« Reply #4 on: December 28, 2004, 01:18:41 pm »

Joachim,

Hi :)
And here are some "mystical" Links, don't know if they works correct in all situations?

keywordmgr.php,v 1.5 2004/12/12 10:24:05 gaugau

line #129 & #162
header("Location: ?page=display");

line #65
$word .= '<td class="tableb"><a href="?page=delete&remov='.$single_word......

line #84
<form name="keywordForm" action="?page=changeword" method="post">



I'm not exactly sure about what this above is reporting.  The first 4 items of the first post are fixed or being done with the theme changes
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: small typo errors in several files
« Reply #5 on: January 18, 2005, 08:41:20 am »

Started a follow-up thread on this particular issue Andi was reporting, marking this one as "fixed".

Joachim
Logged
Pages: [1]   Go Up
 

Page created in 0.018 seconds with 20 queries.