Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1] 2   Go Down

Author Topic: Sort my pictures  (Read 8865 times)

0 Members and 1 Guest are viewing this topic.

Nibbler

  • Guest
Sort my pictures
« on: November 28, 2004, 04:19:04 pm »

There seems to be no restrictions on pic sorting, any user can change the order of pics anywhere in the gallery.
« Last Edit: April 04, 2005, 07:21:41 am by GauGau »
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: Sort my pictures
« Reply #1 on: December 08, 2004, 10:47:28 am »

Is this a bug - this is feature - any user can change sorting BUT it is for that user / browser only
Logged
SANIsoft PHP applications for E Biz

Nibbler

  • Guest
Re: Sort my pictures
« Reply #2 on: December 08, 2004, 05:56:58 pm »

I mean the actual 'sort my pictures' section. This alters the `position` in the db so is a global re-ordering.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Sort my pictures
« Reply #3 on: December 14, 2004, 07:53:48 am »

Nibbler is right, this actually is a bug: there has to be an additional check in picmgr.php that only allows access to the album the user is owner of.

Joachim
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Sort my pictures
« Reply #4 on: December 16, 2004, 09:27:50 am »

Fixed in picmgr.php v1.9 - regular users can only change sorting order of their personal gallery, not of the public galleries. Applied frogfoot's advanced album dropdown to picmgr.php as well.
Someone please confirm fix.

Joachim
Logged

Nibbler

  • Guest
Re: Sort my pictures
« Reply #5 on: December 16, 2004, 03:25:04 pm »

That mod does not seem to support bridging, it references the user table directly so I get a db error.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Sort my pictures
« Reply #6 on: December 17, 2004, 01:17:18 am »

k, so I will have to look into it once more (sigh, why didn't I check bridging as well?)...

Joachim
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Sort my pictures
« Reply #7 on: December 17, 2004, 08:17:32 am »

k, managed to fix this for gallery admin when bridged. I have no clue how to fix this for regular users when using the bridge without adding queries/functions to all bridge files, so the script just dies gracefully at the moment (picmgr.php v1.10). There are three options now:
1) We leave things as they are and flag this a "known issue" ::)
2) We remove the "sort my pictures" feature for regular users (at least when bridged)
3) Someone can come up with an idea how to make the mod work for regular users when bridged

I'd go for the easy option (No. 2) for now, as I'm currently busy with another project, so I don't have time to look into this in detail. Your feedback please.

Joachim
Logged

Tarique Sani

  • VIP
  • Coppermine addict
  • ***
  • Offline Offline
  • Gender: Male
  • Posts: 2712
    • http://tariquesani.net
Re: Sort my pictures
« Reply #8 on: December 17, 2004, 09:23:02 am »

Go with option 2 for now
Logged
SANIsoft PHP applications for E Biz

Nibbler

  • Guest
Re: Sort my pictures
« Reply #9 on: December 17, 2004, 11:57:40 am »

Can we not simply do this ?

Code: [Select]
        // albums in user's personal galleries
        if (defined('UDB_INTEGRATION')) {
            if (GALLERY_ADMIN_MODE) {
                $sql = udb_get_admin_album_list();
            } else {
$sql = "SELECT aid, title FROM {$CONFIG['TABLE_ALBUMS']} WHERE category = ".(FIRST_USER_CAT + USER_ID);
                //cpg_die(ERROR, $lang_errors['access_denied'], __FILE__, __LINE__);
            }
        } else {
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Sort my pictures
« Reply #10 on: December 17, 2004, 06:24:52 pm »

guess you're right, didn't think of the easy solution (I was fiddling with another query in the bridge files instead - very silly thing :-X). Could you commit?

Joachim
Logged

Nibbler

  • Guest
Re: Sort my pictures
« Reply #11 on: December 19, 2004, 04:43:53 am »

Committed.

new revision: 1.11;
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Sort my pictures
« Reply #12 on: December 28, 2004, 06:33:47 am »

fix confirmed. Changing status of thread accordingly.

Joachim
Logged

Nibbler

  • Guest
Re: Sort my pictures
« Reply #13 on: March 15, 2005, 01:07:05 pm »

This issue is back for bridged installs.
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: Sort my pictures
« Reply #14 on: April 03, 2005, 02:02:01 pm »

Does anyone from the dev team care to look into this?

Joachim
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: Sort my pictures
« Reply #15 on: April 03, 2005, 07:30:44 pm »

I don't mind delving into it, but I'm having trouble replicating it.

I've setup a bridged install with SMF, have a public album, login as a bridged registered user, click 'sort my pictures' on the users admin menu, it does not show any of the public albums.

As far as I can tell, thats the behaviour we are after isn't it?

Could the problem be with a specific bridge?  What forum were you experiencing this on Nibbler?
Logged

Nibbler

  • Guest
Re: Sort my pictures
« Reply #16 on: April 03, 2005, 07:36:53 pm »

Yes, it doesn't show public albums but it does now show everyone else's user galleries. It was on my local test gallery with an smf bridge which has sadly succumbed to disk failure, but you can see the same thing on my main site http://www.ic-gallery.com if you login as visitor/visitor.
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: Sort my pictures
« Reply #17 on: April 03, 2005, 08:21:27 pm »

Thanks Nibbler for the clarification, I've been able to reproduce the problem.  Looking into the fix.

[edit]This affects non-bridged installs as well, I reproduced this in a regular install[/edit]
« Last Edit: April 03, 2005, 08:39:31 pm by donnoman »
Logged

donnoman

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 1615
  • From donovanbray.com
    • Donovan Bray
Re: Sort my pictures
« Reply #18 on: April 03, 2005, 10:50:38 pm »

Fix committed to picmgr.php   $Revision: 1.17 $

Tested: Normal and Bridged with SMF.

Can someone confirm, and mark this thread fixed.
Logged

Nibbler

  • Guest
Re: Sort my pictures
« Reply #19 on: April 03, 2005, 11:29:11 pm »

Can you attach it here ? I'll have to wait for the webcvs otherwise.
Logged
Pages: [1] 2   Go Up
 

Page created in 0.019 seconds with 18 queries.