Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: centered file information in Classic theme  (Read 12086 times)

0 Members and 1 Guest are viewing this topic.

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
centered file information in Classic theme
« on: November 16, 2004, 08:37:45 pm »

In Internet Explorer and Opera (not in Firefox), the file information would be centered, instead of left aligned, when on the displayimage page using Classic theme. Strangely, the page looks OK in my local copy of the gallery, and I made sure that the file I uploaded was the same by adding test text. Also, I don't have this problem when viewing the same page in other themes. Since I see this problem in one server and not another, I'm wondering if anyone else has seen this. All files were updated with the latest CVS version.

Here is an example:
http://cpg.thu.lunarpages.com/displayimage.php?album=5&pos=11

So, to recap, the local and remote versions look fine in Firefox. The remote versions are centered in IE and opera.
« Last Edit: November 20, 2004, 07:34:50 am by TranzNDance »
Logged

Nibbler

  • Guest
Re: centered file information in Classic theme
« Reply #1 on: November 16, 2004, 08:44:34 pm »

The powered by coppermine footer is in the wrong place, are you sure that is an unmodified CVS version ?
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: centered file information in Classic theme
« Reply #2 on: November 16, 2004, 09:09:30 pm »

I ran a CVS update on everything:

Quote
M .cvsignore
M displayimage.php
M images/vote.jpg
M lang/english.php

Success, CVS operation completed

I edited displayimage.php for the ecard mod. But if that's the problem it would show for every theme.

I uploaded my local files and overwrote the server version.
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: centered file information in Classic theme
« Reply #3 on: November 16, 2004, 10:03:20 pm »

I can't see this page in IE.  It works fine in ff, but I get this error in IE;

Quote
Template error
Failed to find block 'ecard_button'(#(<!-- BEGIN ecard_button -->)(.*?)(<!-- END ecard_button -->)#s) in :

        <tr>
                <td align="center" valign="middle" class="navmenu" width="48">
                        <a href="{THUMB_TGT}" class="navmenu_pic" title="{THUMB_TITLE}"><img src="images/folder.gif" width="16" height="16" align="absmiddle" border="0" alt="{THUMB_TITLE}" /></a>
                </td>
                <td align="center" valign="middle" class="navmenu" width="48">
                        <a href="javascript:;" onClick="blocking('picinfo','yes', 'block'); return false;" title="{PIC_INFO_TITLE}"><img src="images/info.gif" width="16" height="16" border="0" align="absmiddle" alt="{PIC_INFO_TITLE}" /></a>
                </td>
                <td align="center" valign="middle" class="navmenu" width="48">
                        <a href="{SLIDESHOW_TGT}" title="{SLIDESHOW_TITLE}"><img src="images/slideshow.gif" width="16" height="16" border="0" align="absmiddle" alt="{SLIDESHOW_TITLE}" /></a>
                </td>
                <td align="center" valign="middle" class="navmenu" width="100%">
                        {PIC_POS}
                </td>
                <td align="center" valign="middle" class="navmenu" width="48">
                        <a href="{ECARD_TGT}" title="{ECARD_TITLE}"><img src="images/ecard.gif" width="16" height="16" border="0" align="absmiddle" alt="{ECARD_TITLE}"></a>
                </td>
                <td align="center" valign="middle" class="navmenu" width="48">
                        <a href="{PREV_TGT}" class="navmenu_pic" title="{PREV_TITLE}"><img src="images/prev.gif" width="16" height="16" border="0" align="absmiddle" alt="{PREV_TITLE}" /></a>
                </td>
                <td align="center" valign="middle" class="navmenu" width="48">
                        <a href="{NEXT_TGT}" class="navmenu_pic" title="{NEXT_TITLE}"><img src="images/next.gif" width="16" height="16" border="0" align="absmiddle" alt="{NEXT_TITLE}" /></a>
                </td>
        </tr>

Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: centered file information in Classic theme
« Reply #4 on: November 16, 2004, 10:07:30 pm »

Should have put that on the other thread, sorry.

The centred info is due to my changes to xhtml compliance.  I will fix.  Thanks.
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: centered file information in Classic theme
« Reply #5 on: November 16, 2004, 10:29:14 pm »

Sorry, about that, I edited displayimage per Nibbler's suggestion in another thread, but didn't touch Classic theme lest there is another issue with it. Here's a theme that works with displayimage: http://cpg.thu.lunarpages.com/displayimage.php?album=1&pos=1&theme=classic_thu
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: centered file information in Classic theme
« Reply #6 on: November 16, 2004, 11:07:00 pm »

Your theme still does not show the footer, although like mine, it is in the source code.
I have fixed the centred text, and will commit shortly.
We are already aware there are 1 or 2 issues with this theme when in displayimage.php

I have also noticed the admin.php is centred in this theme, when viewing in IE.


Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: centered file information in Classic theme
« Reply #7 on: November 16, 2004, 11:13:54 pm »

OK, this is the code I've changed.  Could you please test.

Code: [Select]
$html .= "        <tr><td colspan=\"2\" class=\"tableh2_compact\"><b>{$lang_picinfo['title']}</b></td></tr>\n";
    $template = "        <tr><td class=\"tableb_compact\" valign=\"top\" >%s:</td><td class=\"tableb_compact\">%s</td></tr>\n";
    foreach ($info as $key => $value) $html .= sprintf($template, $key, $value);

Is changed to this;

Code: [Select]
$html .= "        <tr><td colspan=\"2\" class=\"tableh2_compact\"><b>{$lang_picinfo['title']}</b></td></tr>\n";
    $template = "        <tr><td align=\"left\" class=\"tableb_compact\" valign=\"top\" >%s:</td><td align=\"left\" class=\"tableb_compact\">%s</td></tr>\n";
    foreach ($info as $key => $value) $html .= sprintf($template, $key, $value);

it still does not show the footer.
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: centered file information in Classic theme
« Reply #8 on: November 16, 2004, 11:37:47 pm »

The footer is at the top of the page. :D

I'm trying to figure the report mod so I'll have to try your fix later. Thanks.
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: centered file information in Classic theme
« Reply #9 on: November 16, 2004, 11:53:15 pm »

I know what causes this, but don't know how to fix without losing xhtml validity.

The comments function does not have an if/else function that determines if the comments are to be displayed etc.  So if they are turned off in either groups or the album properties, the starttable and endtable are still parsed into html, but they are empty, which causes xhtml failure.

To get validity, I hardcoded the table start and end into the html template, and removed the 'starttable();' and 'endtable();' from the around the 'echo $comments;'.  What I missed was that upset the footer.

So what is needed is to make not just the comments not show if turned off, but also the starttable etc.  Then we can remove the hard coded <table> from the template.

I have got it to show and maintain validity, by placing the comments above the fileinfo, but this is more of a workaround than a proper fix.
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: centered file information in Classic theme
« Reply #10 on: November 17, 2004, 12:13:02 am »

Could you just have the table with &nbsp; so it won't be empty?
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: centered file information in Classic theme
« Reply #11 on: November 17, 2004, 01:35:22 am »

re the centred problem, forget all above, it's a simple error in template.html.

Please try with template.html version 1.10.

.
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: centered file information in Classic theme
« Reply #12 on: November 17, 2004, 02:16:57 am »

Excellent. That did the trick. :)
Logged

Nibbler

  • Guest
Re: hide ecard in menu when not allowed to send
« Reply #13 on: November 18, 2004, 07:15:36 pm »

File info box is appearing below comments for me and not respoding to the (i) toggle button with classic theme, not sure if it is related though.
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: hide ecard in menu when not allowed to send
« Reply #14 on: November 18, 2004, 07:41:48 pm »

Here's the reason: http://forum.coppermine-gallery.net/index.php?topic=11816.msg53191#msg53191

The changes I made should not affect the info button. I basically implemented your suggestion and commented out the last 2 lines in the else statement. The info button doesn't work for me in FF or IE either.
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: hide ecard in menu when not allowed to send
« Reply #15 on: November 18, 2004, 07:42:19 pm »

@ Nibbler, No, that's related to my changes to the classic theme, sorry.  I missed the toggle not working.  Working on it.

It seems to me Thu has not committed the ecard menu change yet anyway.

Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Nibbler

  • Guest
Re: centered file information in Classic theme
« Reply #16 on: November 18, 2004, 07:47:19 pm »

sorry, merged.
Logged

Casper

  • VIP
  • Coppermine addict
  • ***
  • Country: 00
  • Offline Offline
  • Gender: Male
  • Posts: 5231
Re: centered file information in Classic theme
« Reply #17 on: November 18, 2004, 09:18:45 pm »

OK, I think I've got it this time.

The file info toggle is working, the comments are back under the info, and it all validates xhtml (providing the language and theme selection is turned off).

Committed to dev.
Logged
It has been a long time now since I did my little bit here, and have done no coding or any other such stuff since. I'm back to being a noob here

Nibbler

  • Guest
Re: centered file information in Classic theme
« Reply #18 on: November 18, 2004, 09:50:44 pm »

Confirmed.
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: centered file information in Classic theme
« Reply #19 on: November 20, 2004, 07:34:31 am »

Looks good.
Logged
Pages: [1]   Go Up
 

Page created in 0.022 seconds with 18 queries.