Advanced search  

News:

cpg1.5.48 Security release - upgrade mandatory!
The Coppermine development team is releasing a security update for Coppermine in order to counter a recently discovered vulnerability. It is important that all users who run version cpg1.5.46 or older update to this latest version as soon as possible.
[more]

Pages: [1]   Go Down

Author Topic: style changes for font consistency  (Read 7192 times)

0 Members and 1 Guest are viewing this topic.

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
style changes for font consistency
« on: September 19, 2004, 11:41:04 pm »

When I looked at the group manager, the alternating rows had different font sizes, which threw off the vertical alignment of the radio buttons. It turned out that since my theme is based on Project, which is similar to MacOS, I found the same styling settings that caused the issue.

In Project vii's style.css, .tableb needed the font-family attribute for it to match .tableh2.
Code: [Select]
.tableb {
        font-family:  Verdana, Geneva, Arial, sans-serif;
        background: #FFFFFF ;
        padding-top: 3px;
        padding-right: 10px;
        padding-bottom: 3px;
        padding-left: 10px;
}

The strange thing with MacOS theme is that the styles difference has nothing to do with font, but with the image background. When I added font-family to both tableh2 and tableb, things lined up.
Code: [Select]
.tableh2 {
        font-family:  Verdana, Geneva, Arial, sans-serif;
        padding-top: 3px;
        padding-right: 10px;
        padding-bottom: 3px;
        padding-left: 10px;
        background-image: url(images/tableh2_bg.gif);
}

.tableb {
        font-family:  Verdana, Geneva, Arial, sans-serif;
        padding-top: 3px;
        padding-right: 10px;
        padding-bottom: 3px;
        padding-left: 10px;
}

« Last Edit: September 22, 2004, 01:49:59 am by TranzNDance »
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: new "groups manager" in cpg1.4
« Reply #1 on: September 20, 2004, 07:26:06 am »

You're right, they appear in different fonts, but your solution is not a good alternative imo, as the font-families are already defined somewhere else in Mac_ox_x:
Code: [Select]
.tableh1, .tableh1a, .catlink, .tableh2 { font-family: Verdana, Geneva, Arial, sans-serif; }My suggestion would be to replace all instances of the font-family definitions and only use one for the body section (removing the line I posted completely, along with all other lines defining font-family except the one defining the body).
The same thing applies to the Project VII theme.
I committed my suggested changes to the devel version (mac and project), please take a look into it and post your feedback (if it doesn't work, we could easily roll this change back). Thanks.

Joachim
Logged

Joachim Müller

  • Dev Team member
  • Coppermine addict
  • ****
  • Offline Offline
  • Gender: Male
  • Posts: 47843
  • aka "GauGau"
    • gaugau.de
Re: style changes for font consistency
« Reply #2 on: September 20, 2004, 07:27:51 am »

see my reply to your posting in the groups manager thread: http://forum.coppermine-gallery.net/index.php?topic=8075.msg45628#msg45628

Joachim

[edit GauGau]
split/merged my reply to be part of this thread
[/edit]
« Last Edit: September 20, 2004, 09:10:00 am by GauGau »
Logged

Tranz

  • Dev Team member
  • Coppermine addict
  • ****
  • Country: 00
  • Offline Offline
  • Gender: Female
  • Posts: 6149
Re: style changes for font consistency
« Reply #3 on: September 22, 2004, 01:49:47 am »

Thanks, it looks fine now.
Logged
Pages: [1]   Go Up
 

Page created in 0.015 seconds with 18 queries.