forum.coppermine-gallery.net
Dev Board => cpg1.4 Testing/Bugs => cpg1.4 Testing/Bugs: FIXED/CLOSED => Topic started by: kegobeer on September 12, 2004, 03:48:44 am
-
There are a bunch of unset variables requested:
$remove_head = $_REQUEST['remove_head'];
$remove_stylesheet = $_REQUEST['remove_stylesheet'];
$remove_to_top = $_REQUEST['top'];
$header = $_REQUEST['h'];
$text = $_REQUEST['t'];
$style = $_REQUEST['style'];
$close = $_REQUEST['close'];
$base = $_REQUEST['base'];
And then a few if-then statements for some of them. While it doesn't cause any problems (unless you have error reporting turned on in php) I was wondering if this for future use, or maybe no longer used at all.
-
I only introduced showdoc.php a short while ago, will have to look into this. I was planning to add more functionality by implementing code related to those vars. I will do a clean-up of the code (assigning this task to me).
Moving this thread to bugs section, so I won't forget about it.
Joachim
-
you were right, so I removed the unneeded vars from showdoc.php.
Joachim
-
Has this been committed to devel yet? I still get the same undefined index errors.
-
OK, finally even I got the point ;)
I added a check for existance for every var that might get used. Committed to devel.
Joachim