forum.coppermine-gallery.net
Support => cpg1.3 Themes/Skins/Templates => cpg1.3.x Support => Older/other versions => cpg1.3 theme contributions => Topic started by: Tarique Sani on June 28, 2004, 10:41:56 am
-
2B or not 2B - Demo http://tariquesani.net/?theme=2bornot2b Download: http://tariquesani.net/themes/2bornot2b.tar.gz 24Kb
Reynolds - Demo http://tariquesani.net/?theme=reynolds Download: http://tariquesani.net/themes/reynolds.tar.gz 24Kb
Notable Features:
Only the CSS is different between the two themes - Designers will better knowledge of CSS than me will be able to work wonders
The pages generated will be valid XHTML 1.0 Transitional if you use the code from devel CVS (or you can wait till the release of version 1.4)
P.S. These themes will not display the Theme and Lang picker drop-downs - this a part of deliberate design - if anyone wants to hack and add them - they are welcome to
-
Great work... definitely gonna modify these to use them on my site.
It might also be a good idea to change the standard + and - in the sorting row we all know very well:
TITLE + -
FILE NAME + -
DATE + -
with the characters
▲ filled vertical triangle &# 9650;
▼ filled triangle pointing down &# 9660;
(source: http://llizard.crosswinds.net/cwc/charactmap.html)
I do think this is set by the theme... right?
-
Quoting from the URL you posted
"geometric shapes
mathematical symbols . geometric shapes . Greek alphabet . card suits . more common extended characters
please note that these characters may not be displayed on some OS"
So the + and - stay :)
-
Okay okay... but then at least put in the images/ascending.gif and images/descending.gif that come standardly along with coppermine. Who knows, those things could still prove a purpose! (are they even being used anywhere else??)
TITLE (http://coppermine.sourceforge.net/demo/images/ascending.gif)(http://coppermine.sourceforge.net/demo/images/descending.gif)
FILE NAME (http://coppermine.sourceforge.net/demo/images/ascending.gif)(http://coppermine.sourceforge.net/demo/images/descending.gif)
DATE (http://coppermine.sourceforge.net/demo/images/ascending.gif)(http://coppermine.sourceforge.net/demo/images/descending.gif)
There's one thing I change as a constant thing whenever I get a theme from coppermine -- and that's those darn + and -'s...
In a world where everybody uses the arrows as an indicator for sorting, you guys just have to all use a + and a -?
I want people to recognize the meaning of a button in less than a second, so they won't have to think about what they're doing for very long..
But anyway... do as you please :D
-
the little arrows are being used in db_ecard.php right now, that's why I added them. Feel free to replace the +/- with the arrows on your install, we'll consider your proposal in the themes that come with coppermine for the future...
GauGau
-
why do you have duplicate entries?
example:
line 637 .navmenu {
font-family: Verdana, Arial, Helvetica, sans-serif;
color: #F6F364;
font-size: 100%;
font-weight: bold;
background : #292929 ;
border-style: none;
}
LINE 1335 .navmenu {
font-family: Verdana, Arial, Helvetica, sans-serif;
color: #F6F364;
font-size: 100%;
font-weight: bold;
background : #737A82 ;
border-style: none;
}
-
why do you have duplicate entries?
Ugh - my bad - had to be be consolidated and removed.... never got around to doing it. do post it here if you get around to doing it :)
-
I'm currently using reynolds as the theme on my gallery, but cannot get it to validate for the LIFE of me... 2 errors are keeping it from valiidating and they appear to be from the empty cells. Here's the link to the validator results page: http://validator.w3.org/check?verbose=1&uri=http%3A//s94358842.onlinehome.us/gallery/index.php
and here's the URL for my actual gallery
http://cryogenic.doesntexist.org/gallery.
It's throwing up the following error: "end tag for "tr" which is not finished" for a closing tr tag. From looking at the source, it's outputting blank TR's with no TD's inside it, which is against xhtml spec. I have no clue why it's doing this because in the actual theme.php file, it makes the TR's and then puts TD's inside it which contain non-breaking spaces. For some reason it's being ignored, though.
EDIT: found the offending code...
<!-- BEGIN c_album_cell -->
<td width="{COL_WIDTH}%" height="100%" valign="top">
<table width="100%" cellspacing="0" cellpadding="0">
<tr>
<td colspan="3" height="1" valign="top" class="tableh2">
<a href="{ALB_LINK_TGT}" class="alblink"><b>{ALBUM_TITLE}</b></a>
</td>
</tr>
*** <tr> ***
*** </tr> ***
<tr>
<td align="center" height="100%" valign="middle" class="thumbnails">
<a href="{ALB_LINK_TGT}" class="albums">{ALB_LINK_PIC}<br /></a>
</td>the asterisked lines need to be removed... after removing those, the page validated just fine.
Now if I can just get rid of those hideous white filler boxes in my tables... Anyone have any ideas on that one?
-
Thanks the packages have been updated with your fix, the CSS has also been cleaned up a bit an probably also has the fix for those hideous white filler boxes in your tables
-
It took me a good hour or so to find that stupid piece of code in there! I couldn't quite figure out what part of the code corresponded to where I needed to look since there were so many tables in there... I eventually found that area on complete ACCIDENT, having scrolled down too far and saw it. I'll download the new packages to see if the cleaned up css helps matters any. :) Thanks a million for the great theme, though. The other one just didn't quite look right, so I didn't bother trying to fix it.
EDIT: Still seeing the ugly white boxes there... My guess is that the "empty cells" are getting set to a white background instead of a transparent one. That's the only thing that I can see even possibly causing a problem.
-
The other one 2bornot2b has been designed for my personal site and looks good only on 1280x1024 with 32bit colours onwards BUT like I said only the CSS is different in the two.
Oh! BTW I fixed only Reynolds and not 2bornot2b
[edit]
Find maintable class and set the color as #eff3f6
[/edit]
-
I'm using reynolds anyway... I like it better as it fits in a LITTLE better with my existing theme for my blog.
I found the offending piece of code...
<td width="50%" height="100%" valign="top">
<table width="100%" cellspacing="0" cellpadding="0">
<tr>
<td height="1" valign="top" class="tableh2">
<b> </b>
</td></tr>
<tr>
<td width="100%" height="100%" valign="top" class="tableb_compact">
<b> </b>
</td></tr>
</table>
</td>
I'm still trying to figure out what's wrong with it, though.
-
Just saw your edit... and yeah... maintable was set as pure white, which since there's no content, it gets shown. Changed the color to #eff3f6 and works perfectly now. Thanks! I couldn't be happier.
-
I'm using reynolds anyway... I like it better as it fits in a LITTLE better with my existing theme for my blog.
I have a matching WordPress theme if you would want - ask :)
-
Your CSS doesn't validate...
1) under #menu ul {... you need 10px instead of just 10 as your "margin left"
2) cursor:hand is apparently not valid... I removed the line entirely and had no problems at all (it's under "clickable option")
3) css validator thinks #a89daa is not a valid color under .alblink a {... I replaced the line with color: rgb(168,157,170) and it validated just fine... go figure.. same color, different declaration. I replaced this in the .alblink a:hover as well.. validated fine now.
http://s94358842.onlinehome.us/gallery/themes/reynolds/style.css
There's the css file that properly validates. Not sure whether it's a huge deal to you or not given that the 3 errors it found were incredibly minor.
-
I"d love a wordpress version... thats what i was working on... almost have it toooo
www.osterbrink.org/pictures
www.osterbrink.org/blog
let me know what you think!
-
is there any reason that you can think of that i can no longer click the image to bring it up in it's own window at full resolution? It works fine in other skins.... weird... I may just start over with your new cleaned up version
-
Use the cleaned up versions anyway... they now completely validate as xhtml 1.0 transitional. Also the css file is almost 6KB smaller. If you want the css to validate, use the version linked above as I had to change a few things to make it validate. Reynolds works fine on my end if I click a larger picture to view... so I'm not sure what could be causing the problem. Make sure you're using the latest dev code from cvs. It doesn't work too well with 1.3.x. I tried it myself and it didn't look very good.
-
have updated the package with the new CSS - thanks a lot for your efforts.
-
Just to let you know... the Reynolds theme is VERY close to validating as XHTML 1.1... it's only due to the table alignment present in the actual code (and not in css) that's causing it to not validate.
-
I realised that - but since it was decided that Coppermine in general has to validate XHTML 1.0 transitional I did not bother
BTW I am working on a style switcher series of CSS based themes Forest, Ocean, Tundras and Desert, Forest is nearing completions and you can see it at http://tariquesani.net/?theme=forest
Your corrected CSS will help me there as well
-
http://www.developingwebs.net/html/hexgen.php
That page is awesome for color codes and such.. My own personal opinion is that I prefer rgb color codes to hex. That particular site gives them to you every which way but upside-down.. haha.. I've never seen a css validator complain about an rgb color code. Also, forest's css doesn't validate... same errors as before. cursor: hand is not a valid option... a89daa also isn't a recognized color code.. just use the same one from before. And apparently "all" is not an acceptable value of "clear" under #menu ul
-
is there any reason that you can think of that i can no longer click the image to bring it up in it's own window at full resolution? It works fine in other skins.... weird... I may just start over with your new cleaned up version
Don't ry to hijack a thread with your unrelated question...
If the pop-up doesn't open, you probably have removed<script type="text/javascript" src="scripts.js"></script>from template.html
GauGau
-
think i could get that wordpress theme from you?
thanks much!
-
think i could get that wordpress theme from you?
Snag the CSS for WP Reynolds theme from http://www.swatisani.net
-
it doesn't validate... 7 errors, mostly in the lists to the right. I also didn't find the download link for it...
-
it doesn't validate... 7 errors, mostly in the lists to the right. I also didn't find the download link for it...
There is no link for download - like I said - snag it
-
I have installed yesterday Coppermine 1.3.1 and I wanted to download Reynold's theme by Tarique to erase all TABLE code and ad some CSS hacks (like popup) ...
OK, installation well ...
but When I go to config admin, and want to change theme, ALL the themes = Hardwire !!! :( The same theme I have used in CPG 1.2.0 ...
What's wrong ??? I have erased all themes to put the 1.3.1 themes ...
:(
-
Rod,
merged your posting with the thread dealing about the theme you're refering to. Please post a link!
GauGau
-
Gaugau ...
My link = the signature
http://www.sortons.net/photos
It's weird in fact
When I try to change theme, it takes only some things (menu for example) but ALL THE REST of the template is Hardwire
I don't understand
Futhermore, I have erased my OLD Hardwire (I have done some modifications on it) and replace by the Hardwire 1.3.1 : and I see the OLD hardwire ... X files for me, really.
-
I don't understand at all.
GauGau
-
You seem to have copied your html code to all themes.
I tried your site in a variety of themes, see pics beloww, but the source code for them all points to;
<link rel="stylesheet" href="themes/hardwired/style.css" />
This of course will ruin the other themes.
-
You seem to have copied your html code to all themes.
I tried your site in a variety of themes, see pics beloww, but the source code for them all points to;
<link rel="stylesheet" href="themes/hardwired/style.css" />
This of course will ruin the other themes.
OK Casper ... thanx for this "beginning" of answer ... but where is the file should I modified ?? I don't remember ... but where it's weird, I have uploaded 1.3.1 : only files I have kept are include/config.inc.php and anywhere.php ... I don't understand ... But thanx !
-
Waouh ok !!!! :) what's a great "bug" !!!
In fact, I have uploaded by error template.htm in the root directory ... and surprise : this was THIS template.html which had control of all templates ...
-
.........
what f i customize it for RTL view ( arabic )
will it be cute as it is now :O?
???
-
will it be cute as it is now :O?
try and let us know
-
Hi Tarique,
I was working on the Reynolds theme, to add the theme selector and to change the filmstrip tile.gif (the one thing which does not fit, imho) when I realised your theme.php is ponting to the images directory of the 2bornot2b theme for this file.
This means anyone who has not installed both themes will get no filmstrip edging displayed.
I used one of the smaller, nicer filmstrip gifs supplied by b6gm6n, and available attached to this post, http://forum.coppermine-gallery.net/index.php?topic=8076.msg35697#msg35697, and I think it looks so much better.
-
Attach your theme.php and the gif here - I will upgrade my package - thanks a lot
-
Here is the gif I used, and the modified theme.php.
-
Thanks again, updated the tarball.
-
Hi Tarique,
The updated theme.php I attached the other day cured the problem of the filmstrip gif, but I just realised I did not replace all instances of '2bornot2b' in the file, so other images are affected, such as the ratings.
Attached file has removed all reliance on the 2bornot2b theme being present.
-
Thanks updated the zip
-
This is a great theme but I had a problem with netscape and firefox when the image caption was lengthy. The text failed to wrap causing the main body to shift under the right hand menu (using Reynold). It appeared to be inheriting the white space attribute of the image above it. IE did not do this.
I added "white-space: normal" to ".img_caption_table td" class which fixed the problem.
Thanks
-
Reynolds: Demo (http://coppermine.sourceforge.net/demo/?theme=reynolds) - Download (http://prdownloads.sourceforge.net/coppermine/cpg1.3.0_theme_reynolds.tar.gz?download)
2bornot2b: Demo (http://coppermine.sourceforge.net/demo/index.php?theme=2bornot2b) - Download (http://prdownloads.sourceforge.net/coppermine/cpg1.3.0_theme_2bornot2b.tar.gz?download)
Hint: both themes don't have the language and theme selectors all cpg1.3.x themes are suppossed to have - please add them for future versions:<p align="center">
{LANGUAGE_SELECT_FLAGS}<br />
{LANGUAGE_SELECT_LIST}{THEME_SELECT_LIST}
</p>
GauGau
-
P.S. These themes will not display the Theme and Lang picker drop-downs - this a part of deliberate design - if anyone wants to hack and add them - they are welcome to
I have added them on my shop demo, but they cause the themes to lose their css and xhtml compliance, which is why I did not add them to the downloads.
-
please post the errors from the validator, so they can be fixed.
GauGau
-
You can see the reports as below;
2bornot2b, here (http://validator.w3.org/check?uri=http%3A%2F%2Fwww.hsocuk.com%2Fgalleries%2Findex.php%3Ftheme%3D2bornot2b)
Reynolds, here (http://validator.w3.org/check?uri=http%3A%2F%2Fwww.hsocuk.com%2Fgalleries%2Findex.php%3Ftheme%3Dreynolds)
-
Hello. I'm new to coppermine, and am still configuring my gallery. Powerful piece of software. I've been plowing through a lot of the code using one of Tarique Sani's xhtml css theme as a base to create my own super simple xhtml valid theme. I just noticed however that a picture's Title does not display in Opera (7.51). It doesn't display in the page title at the top of the browser, in the thumbnail view (even with the option set to display in the config section), or on the actual page of the picture. This is irrelevant of which theme is used, as it even occurs with the default theme. Thought I'd point it out, as I'm pretty clueless with php and I thought that there may be some bad code in there somewhere.
/edit.. The descriptions don't display either. Everything works fine in Firefox and IE6 though.
actually, I just checked out this gallery http://www.newtek.com/products/lightwave/lw-gallery/thumbnails.php?album=17 and their titles display fine for me in opera. I can't really tell what version they're using so I'm unsure if this is a problem with 1.3.2 or if it's just mine for some reason.
-
please post a link and what version of Opera you are running, so we are able to check.
GauGau
-
I can't post a link, as I'm running this locally for testing while I'm developing. I can post my theme.php file if you'd like though. Also kind of curious as to why with the 2bornot2b theme, a index.php file is included. So far I haven't done anything with that as it seems to be an old version based on the comments at the top of the file.
-
without looking into it I guess it's just there to prevent people from browsing the folder it is in. Check the contents of the file - if it is blank, it's just there for this purpose.
Please post at least what version of Opera you are using.
GauGau
-
Opera 7.51. It was in my first post.. The index.php file that's included in the 2bornot2b theme I downloaded from the sourceforge site is a full-on index file (I thought maybe the theme's author meant for that to overwrite the index.php file in the main coppermine folder). I didn't do that as this file starts with " Coppermine Photo Gallery 1.2.0" at the top. It's a little confusing. I'm new to cpg so I'm not sure whether or not I'm supposed to even mess with that file. I assumed I could do all my tweaking with the style.css, theme.php, and template.html file. Hopefully I'm right there.
-
I downloaded from the sourceforge site is a full-on index file (I thought maybe the theme's author meant for that to overwrite the index.php file in the main coppermine folder).
There should not be an index.php in that download - if it is please disregard. Also the Reynolds theme is a more complete theme than 2borno2b
-
Thanks, I checked out your reynolds theme. Nice too and I'll see which to base mine off. I want it to be xhtml valid, so these are the only two I see really digging into. I'd use them stock, but of course I've got to customize and customize to my heart's content. I redownloaded the 2bornot2b.tar.gz theme, and there is an index.php file and a file called DEADJOE with no extension. You may want to update it so as not to confuse :-\\ Thanks for the hard work though, your gallery looks really nice.
/edit.. please disregard my comments about opera's handling of the titles. I have no idea what was going on yesterday, but today when I fired up my computer and server, it all looks fine.
-
P.S. These themes will not display the Theme and Lang picker drop-downs - this a part of deliberate design - if anyone wants to hack and add them - they are welcome to
Tarique, the language and theme selectors can/should be switched on/off in coppermine config. For the sake of standards compliance and less questions asked on the support board I suggest putting them in - won't hurt you, as you have the selectors disabled in your config afaik.
I have added them on my shop demo, but they cause the themes to lose their css and xhtml compliance, which is why I did not add them to the downloads.
erm, the selectors cause 2 of the 110 errors reported by the validator. That's rather nothing imo. Anyway, I have updated the devel branch to get rid of some of the most trivial errors from the validator. I won't look into the stable branch to do a similar thing - it's just to much work, not worth the effort (hopefully cpg1.3.2 has been the last release based on the current stable branch code). Could you check out and test with your cpg1.4 install - should be significantly less.
If we want real standards compliance, we will have to get rid of the ampersand in the urls. As most servers don't come with support for ";" instead of "&" as delimiter in urls, we'll have to code a routine similar to the one I just paste for reference from an older yabbse version:<?php
if (strlen($QUERY_STRING) > 0)
{
$str = (substr($QUERY_STRING, 0, 5) == 'url=/' ? $HTTP_SERVER_VARS["REDIRECT_QUERY_STRING"] : $QUERY_STRING);
$query_strings = split('[;&]', URLdecode($str));
foreach ($query_strings as $tmp)
if (preg_match("/^([^=]+)[=](.*)/", $tmp, $parts))
$GLOBALS[$parts[1]] = htmlspecialchars($parts[2]);
}
if (!empty($_SERVER['HTTP_CLIENT_IP']))
{
$ip_expl = explode('.', $_SERVER['HTTP_CLIENT_IP']);
$referer = explode('.', $REMOTE_ADDR);
if($referer[0] != $ip_expl[0])
{
$ip = array_reverse($ip_expl);
$REMOTE_ADDR = implode('.', $ip);
}
else
$REMOTE_ADDR = $_SERVER['HTTP_CLIENT_IP'];
}
elseif (!empty($_SERVER['HTTP_X_FORWARDED_FOR']))
{
if(strstr($_SERVER['HTTP_X_FORWARDED_FOR'], ','))
{
$ip_expl = explode(',', $_SERVER['HTTP_X_FORWARDED_FOR']);
$REMOTE_ADDR = end($ip_expl);
}
else
$REMOTE_ADDR = $_SERVER['HTTP_X_FORWARDED_FOR'];
}
?>
Joachim
-
@Gaugau - I want the *theme* to be XHTML compliant not just my site - I will work on how to get the Lang and Theme selectors to play properly, actually non inclusion of those was the precise reason I had not added the themes to the downloads at SF
@kevito - thanks for the heads up will update my tarball. Am very keen on seeing what you come up with - the future of coppermine themes has to be standards based :)
-
@Tarique: what do you think about the code snippet I posted - something along this should go into init.inc.php and we should be fine.
Joachim
-
replacing all the & with & in the URLs is fine for XHTML 1.1 transitional, we need not use ;
-
Using ; as delimiter in URLs is recommended by the W3C, but I have hardly come across any server that is configured to use it - most webservers are still configured to use & instead. For more XHTML compliance (as a goal), we should definitely go for ";" instead of "&".
Maybe I didn't make myself clear, or I'm missing something: The code snippet I posted has been taken from YaBB SE and exists in SMF as well. That's why an url like http://forum.coppermine-gallery.net/index.php?topic=9304.40 works on this server, but http://coppermine.sourceforge.net/demo/displayimage.php?album=1;pos=0 doesn't - it has to be http://coppermine.sourceforge.net/demo/displayimage.php?album=1&pos=0
Fumbling in the code with & instead of & (see http://www.w3.org/TR/xhtml1/#C_12 ) makes the code messy and more difficult to understand for users, and it won't solve the initial issue: the delimiter has to be ";" afaik.
Joachim
-
http://www.w3.org/TR/xhtml1/#C_12 says use &
For example, when the href attribute of the a element refers to a CGI script that takes parameters, it must be expressed as http://my.site.dom/cgi-bin/myscript.pl?class=guest&name=user rather than as http://my.site.dom/cgi-bin/myscript.pl?class=guest&name=user
IMHO messing with every query string once while programming is simpler than messing with it in every execution of code
I am surely missing something here....
-
Hi,
in another thread, Tarique Sani wrote (about theme Reynolds and standards compliancy):
Like Gaugau said - the theme is - the code for 1.3.2 is still not
See the latest one at http://validator.w3.org/check?uri=http%3A%2F%2Ftariquesani.net%2Findex.php
You will need the code from CVS to make it work
Wow, it is the first time I have seen a CPG site which validates. Congratulations! Could you perhaps be a little specific explaining which files from the CVS I would need to implement a standard compliant CPG theme in my site?
Thanks in advance
Jĝrgen Peter Kjeldsen
-
The files which need to be changed are index.php, thumbnail.php, displayimage.php and functions.inc.php BUT if you take just these files from the CVS and not the entire package - your install of coppermine is likely to break.
If you are comfortable with Alpha code then you can download the entire CVS devel and run the update.php. Currently the devs are not aware of any show stopping bugs in the CVS devel, so that way it is almost Beta...
-
If you are comfortable with Alpha code then you can download the entire CVS devel and run the update.php. Currently the devs are not aware of any show stopping bugs in the CVS devel, so that way it is almost Beta...
Well, as I am not at all familiar with Alpha code, I think I will follow the advice in your signature: "Don't! just Don't!!"
I'll be patient and wait till there will be an official Beta... When do you expect that to happen?
Thanks for your answer, anyway!
Jorgen Peter Kjeldsen
-
When do you expect that to happen?
Well the official line is "When it is ready" but a Beta can be expected in a couple of weeks
-
When I try to uncompress the Reynolds theme, it only gives me three images.
-
Where did you get the download from. It sounds as if it is corrupt, please download a new copy.
-
If you are comfortable with Alpha code then you can download the entire CVS devel and run the update.php. Currently the devs are not aware of any show stopping bugs in the CVS devel, so that way it is almost Beta...
Well, as I am not at all familiar with Alpha code, I think I will follow the advice in your signature: "Don't! just Don't!!"
I'll be patient and wait till there will be an official Beta... When do you expect that to happen?
Thanks for your answer, anyway!
Jorgen Peter Kjeldsen
Don't know if this will make you feel any better, but I'm quite the newbie myself and my page is based around 1.4 code and validates fine. I took the long route and actually downloaded the CVS code locally and then re-uploaded it to my server. Seems to work ok and validates fine. I'm using the reynolds theme and have been for a good while now. Initially it wouldn't validate but I debugged a few errors to make it validate and passed it along to Tarique to help out some. Needless to say, all I did was download the whole tree (make sure and get the SQL folder!!) and then ran the update.php file and it did everything for me. If you want to take a look, my gallery is @ http://cryogenic.doesntexist.org/gallery :)
Also, Tarique, I'm having an issue with 2bornot2b on the config page. The headers/category titles for each section are black on a charcoal background (though the text for each option is correct). I'm going to try and figure it out myself in the meantime, but if you have any suggestions on how to correct it, it would be much appreciated.
Edit: fixed! tableh2 class needs "color" changed from #000000 to anything lighter.. (e.g. #ffffff). Also, 1.5em is, in my opinion, entirely too large. I'd suggest something more moderate like 1.3. Reynolds is set @ 1em, for example. I've attatched the corrected css file.
-
Grab the new 2bornot2b CSS from my site
-
I corrected it myself... and I forgot to attatch the corrected one, but it seems to be a moot point now.
EDIT: Tarique, you should edit the template.html near the bottom and change the xhtml 1.0 compliant banner to check referer instead of your URL. You inadvertently left your own URL hard-coded into the button link. The CSS button links properly, however.
-
2bornot2b is due for a huge clean-up - yes will keep your point in mind
-
2bornot2b is due for a huge clean-up - yes will keep your point in mind
cleanup as in how? I'm tempted to go through and remove all the double-spacing from the css file itself. I can't really see much of anything else that is in dire need of attention.
EDIT: I got bored and used JOE to go through and remove all the extra whitespace in style.css for 2bornot2b and while it looks better, it only saved 1KB in file size. If you want the file, I'll provide it... Basically, what I've done is single-spaced between classes and taken out all the line spacing between elements of the classes (e.g. background: and the like).
-
You mean I have already removed all those duplicate classes and IDs scattered .... must have, now to remove the hard coded links and add the variable for language and theme selection ;)
-
Tarique,
I found that when using reynolds in admin mode the content is stretched and impedes the menu.
I have fixed this myself by placing the album admin menu in a new row under the album thumbs/description cells.
I did it by changing this code (twice);
<table width="100%" cellspacing="0" cellpadding="0">
<tr>
<td colspan="3" height="1" valign="top" class="tableh2">
<a href="{ALB_LINK_TGT}" class="alblink"><b>{ALBUM_TITLE}</b></a>
</td>
</tr>
<tr>
<td align="center" height="100%" valign="middle" class="thumbnails">
<a href="{ALB_LINK_TGT}" class="albums">{ALB_LINK_PIC}<br /></a>
</td>
<td width="100%" height="100%" valign="top" class="tableb_compact">
{ADMIN_MENU}
<p>{ALB_DESC}</p>
<p class="album_stat">{ALB_INFOS}</p>
</td>
</tr>
</table>
To this;
<table width="100%" cellspacing="0" cellpadding="0">
<tr>
<td colspan="3" height="1" valign="top" class="tableh2">
<a href="{ALB_LINK_TGT}" class="alblink"><b>{ALBUM_TITLE}</b></a>
</td>
</tr>
<tr>
<td align="center" height="100%" valign="middle" class="thumbnails">
<a href="{ALB_LINK_TGT}" class="albums">{ALB_LINK_PIC}<br /></a>
</td>
<td width="100%" height="100%" valign="top" class="tableb_compact">
<p>{ALB_DESC}</p>
<p class="album_stat">{ALB_INFOS}</p>
</td>
</tr>
<tr><td colspan="2" align="center" height="100%" valign="middle" class="thumbnails">{ADMIN_MENU}</td></tr>
</table>
-
I actually noticed the same thing, but never really bothered to fix it :P I prefer the darker colored theme anyway and it seems to work perfectly fine on my end so far.
and @Tarique, the duplicate classes appear to be gone from what I can telll. With the whitespace removed, the css file checks in at 11KB.
-
Works fine on Mozilla for me - please post more details
-
Hi tarique,
I noticed this when more than 2 columns of albums are shown, or when viewing at a lower resolution, say 800x600.
It is the index page, and cat index page this is noticable on, not the config page. I accept that this theme is designed for use at 1024 or higher, and with just 2 columns, but as you know there will always be users who choose to do it differently, and then moan.
This is just a cosmetic fix for those occassions. Does the 'colspan' create a problem with validating?
-
One other suggestion for 2bornot2b. under the class .debug_text, color should be changed from #000000 to #ffffff as it's completely unreadable with the color set as 000000 (black). I have debug mode turned on in admin mode since I'm testing 1.4 and I had to change the color in the css in order to make it readable :P
-
@casper - at lower resolutions too many things break in reynolds anyways... So I am not in favour of just adding colspan when we cannot fix other stuff like the thumbnail display anyways
@cryogenic - will keep in mind .debug_text color when I fix 2bornot2b
-
Hi
Some questions:
1 - Which are the xhtml compliant themes ? Where could I found a list ?
2 - New themes are tableless or Coppermine still comes with html tables inside php code ?
Thanks in advance
Javier
-
You will find out if you read this thread from the very beginning to the very end. The themes mentioned here are both experimental, and the current cpg release version (cpg1.3.2) is not xhtml compliant (but the next version will be). Coppermine (any version) is however not completely tableless.
Joachim
-
Tables are still xhtml compliant and they work best for this particular purpose. The only thing keeping it from 1.1 compliance is the presence of align, height, width, and border attributes in the table code itself. Apparently all that stuff is supposed to be moved to the css file in xhtml 1.1? Both themes validate XHTML 1.0 transitional when used with CPG 1.4.
-
Grab the new 2bornot2b CSS from my site
@Tarique: Where can I get this CSS as your site looks like mine insomuch that it uses the eyeball template. I'd like to get mine to be XHTML compliant if at all possible... :)
My gallery is at: http://cgi.martinhart.force9.co.uk/ if you want to take a look :-[
-
@martina - you will probably need the complete theme Eyeball is very different from 2bornot2b
-
@Tarique: I use the theme Eyeball at the moment. How have you managed to validate it OK for XHTML when mine does not seem to work? I have made little or no changes from that supplied under 1.3.2 (or do I need v1.4)?
-
Tarique is not using the eyeball theme. He is using 2bornot2b. It may look similar, but is completely different in the way it works.
It is not the eyeball theme with a different css.
-
Also, as stated NUMEROUS times in this thread. 1.3.x will NOT validate XHTML with either of these themes (or any other box-stock theme). 1.4x is the only branch that validates as the code itself has been correctly modified per xhtml standards (self-closing tags and moving most layout info to css seem to be the big changes). So if you wish to have your gallery validate, upgrade to 1.4, but don't expect any support. On a happier note, I've been running it virtually trouble-free for a good while now and I'm no PHP wizard :)
-
@cryogenic: sorry - didn't mean to repeat what's already been stated. :-[
I think I may give v1.4 a try as long as it seems stable...
-
Where can I download the other themes like forest ?
I think they are simply great.
Or better of, how do I make it look like Tarique's gallery. Or maybe that involves a lot of coding. ;)
-
I think I may give v1.4 a try as long as it seems stable...
Please backup your current gallery files and database if you decide to upgrade. However, there is NO SUPPORT for the development version. It is stable for general use, but there are things here and there that need to be worked on. Also, the code is continually being edited, so it's not recommended to use this on a production site unless you can keep on top of getting the latest versions of files. The dev version is only for advanced users, or patient ones who don't mind if something doesn't work as expected.
So don't :\'( if dev cpg doesn't behave as expected.
-
@ Lionheart
all the themes are available from the downloads section, link above.
But where did you see one called forest?
-
Thanks, mate.
Tarique have a css modification of the reynold theme called forest.
http://www.tariquesani.net/index.php?theme=forest
I would also like to know how to make modifications in the right menu of this skin and how to write a welcome message at the top, like this site: http://www.linsson.com/2.lars/
Regards
Dennis
-
I don't know if Tarique is making that theme available, although it does look very good.
To modify the menu, that is done in theme.php for the content, or style.css for the positioning.
The welcome in the website is simply using the anycontent.php. This is exactly what it is for. Just edit it to have the content you want, upload, and add it to the 'contents of main page' in config.
-
Thank you very much Casper.
I hope Tarique will release the Forest css soon.
-
@Lionheart - Forest css is in a mess - I can attach / make a zip and post a link if you are willing to help clean it up :)
[update]
http://tariquesani.net/themes/forest.tar.gz
[/update]
-
Tarique,
I have used your 2born2 theme and modify it to begin my tableless version ...
One question : why some things which are "customizable" are in same time in theme.php and displayimage.php ? Would it be better if ALL parameters about layout were in theme.php ? (Look at http://www.sortons.net/photos/displayimage.php?album=915&pos=5 : on right, I have title and caption, and with help of Nibbler, I have known I had to modify displayimage.php)
-
@Rodinou - now you understand why we devs say that the current templating system is in a mess :D
-
Thanks Tarique, how can I download the 2born2 theme. The forest theme refers to that theme in the buttons and other linked stuff.
How hard is it to clean it up? I'm not a programmer per se ;D
-
Ugh! this is what I meant by cleaning up :D there is a link to 2bornot2b in the first post of this thread
-
I helped him clean up 2beornot2b and reynolds a fair bit. I'm not a programmer, either. I'm going to download forest and play with it a bit even though I have no intentions of using it on my site (I prefer the black of 2bornot2b).
@Tarique, do you use JOE on Unix/Linux? A few things have led me to believe that you do (I saw a JOE file in one and the presence of a template.html~ file).
Also, I can easily (and will) spend a couple/few hours cleaning up the css for forest, however there are a few areas that I don't want to "botch" so to speak and change things in such a way that things don't display as you have intended. Any suggestions for situations such as this?
-
@cyrogenic - yes joe is my editor of choice if available else vi will do :)
-
Just help me out here... where you have duplicate entries in your css... I'm assuming the one farther down in the file is the later addition and the color you intend for the elements to display? I'm a good 35-40% of the way through the file and have removed a fair number of duplicates and whitespace.. it now validates as correct css. Whenever a discrepancy has arisen between an earlier entry and a later entry, I copied the data from the earlier entry to the position of the earlier entry, in most cases... though I did find a few where your earlier entry just plain looked better. I'll post it when I'm done. :)
As a side note, I absolutely love Joe as an editor. It works wonderfully and is easy and quick to use. Also, for those of you out there doing css/html regularly, take note of this page; I find it invaluable! http://www.developingwebs.net/html/hexgen.php
-
@ lionheart,
just use your editor to replace all instances of '2bornot2b' with 'forest', and make sure the images folder in forest contains all the images in the 2b images folder. You may want to change some of them, like the tile.gif.
-
I've noticed that his theme.php in forest has link dependencies to /themes/2bornot2b/images/... I've edited those out of forest so far... as of now, I'm working on the css file, removing duplicates and excess whitespace. Should be done soon. I'm on a windows box, so I'll have to re-package and upload as a zip unless someone has a better plan. :)
@Tarique, when setting the "padding" value the same on all four sides, only a single "padding: 10px" is necessary.. no need for separate padding-left, padding-right, etc. :)
EDIT: All cleaned up to the best of my ability... However, I've noticed that the top part of the admin menu (My Gallery, Memberlist, User Mode, Upload File) isn't offset to the right at all when it should be... is this the "admin_menu2" class?
-
@Tarique, when setting the "padding" value the same on all four sides, only a single "padding: 10px" is necessary.. no need for separate padding-left, padding-right, etc. :)
Of course I know that - but as I have said this was a very messy CSS - thanks for cleaning up
EDIT: All cleaned up to the best of my ability... However, I've noticed that the top part of the admin menu (My Gallery, Memberlist, User Mode, Upload File) isn't offset to the right at all when it should be... is this the "admin_menu2" class?
Yes that is admin_menu2 class
-
Tarique... it APPEARS to be cleaned up... I had to move both of the admin menus and change the "right: ##px" to left: ##px as if you use the "absolute" positioning, you must include both top and left positioning. I'm sure the colors could use some tweaking... here it is in action:
http://cryogenic.doesntexist.org/gallery/index.php?theme=forest and the file in zip format is attatched. I did the best I could :)
EDIT: it was plagued by that stupid empty table bug keeping it from validating xhtml... Played with it a bit, it validates completely now. (see reply #7 on pg1 for exactly details of what I mean... check your other theme.php files for this as well... it's happened in all of them so far)
-
If I finish the tableless version, I have to send you
- css
- template.html
- images
- theme.php
but ... there are some modifications on displayimage.php ...
So ... I'm not really working on a theme, but on a real tableless solution (and if you see : http://www.sortons.net/photos/thumbnails.php?album=950, tableless is easy to custom, and so .. once DONE 1 time, only CSS to change to change the apparence, the layout, the navigation ...)
But I admit : the code is very ... weird (I don't understand really this story between displayimage and theme)
-
I tweaked the css a little more to make more of the links match up and whatnot. The breadcrumb hover being black didn't look too good with the dark background, so I changed it to look similar to the other links where it just underlines but keeps the same color. Looks better now. :)
I'm at work, so I haven't updated the zip file as of yet, though you can see it in action @ the link posted above.
-
For those of you using this with the dev version (1.4) you will need to make the following changes to the theme.php, next time you update your install.
Find;
<td class="admin_menu"><a href="config.php" title="{CONFIG_LNK}">{CONFIG_LNK}</a></td>
Change to;
<td class="admin_menu"><a href="admin.php" title="{ADMIN_LNK}">{ADMIN_LNK}</a></td>
find;
'{CONFIG_LNK}' => $lang_gallery_admin_menu['config_lnk'],
change to;
'{ADMIN_LNK}' => $lang_gallery_admin_menu['admin_lnk'],
find;
'{ADM_MODE_TGT}' => "admin.php?admin_mode=1&referer=$REFERER",
Change to;
'{ADM_MODE_TGT}' => "mode.php?admin_mode=1&referer=$REFERER",
-
what are we supposed to do with that last line of code, Casper? I think you forgot to list what we're supposed to change it to. :P
-
DOH,
Added that to the post above, but I also missed this.
Find;
'{USR_MODE_TGT}' => "admin.php?admin_mode=0&referer=$REFERER",
Change to;
'{USR_MODE_TGT}' => "mode.php?admin_mode=0&referer=$REFERER",
-
All related to the name change of admin.php to mode.php, it appears. I've not updated as of yet since it doesn't seem to offer any new features. I'll wait until a few more files are updated before I go raiding CVS again :P
-
I finally decided to try a go with a Coppermine 1.4 installation. Downloaded all the CVS files, installed with Reynolds theme - all went fine. Now, at last, I have a XHTML installation up and running. You'll find a (very preliminary) version at http://xn--gravl-yua.dk/cpg/ (it's in Danish).
There is one problem, however. In admin mode running Gallery Configuration, trying to make som tweaks to the general setup, I get the following error message:
Warning: Invalid argument supplied for foreach() in /hsphere/local/home/gravol/xn--gravl-yua.dk/cpg/admin.php on line 640
Can anyone tell me what is wrong and how to correct it?
If this is the wrong forum/thread, please direct me to where I should post my question.
Thanks in advance for any help.
Jĝrgen Peter
-
this is the wrong thread indeed - in fact there is no right thread for this question at all: cpg1.4 (the devel version from the cvs) goes unsupported! Absolutely no support means absolutely no support. If you experience issues with it, you will either have to downgrade or fix this on your own. You have to realize that the language files in it still are from cpg1.3.x, I guess this is what is causing that particular error.
Joachim
-
A minor addition to what Gaugau said - Absolutely no support means absolutely no support from any of the devs - other users of 1.4 CVS are most welcome to put in their suggestions to pjoern.
-
Hi there,
this is the wrong thread indeed - in fact there is no right thread for this question at all ... [snip] ... You have to realize that the language files in it still are from cpg1.3.x, I guess this is what is causing that particular error.
Joachim
Well, I'm sorry for my inappropiate question. However, your hint directed me in the right direction, and I fixed it with a tweak of the language file. So THANK YOU very much!
Kind regards,
Jĝrgen Peter
-
I had the same problem until I updated to the latest english language file... perhaps you should post what change you made to your language file that way other users of 1.4 can make the appropriate changes. Seems that the english file got updated, but none of the other language files got fixed? I doubt they have a dev that speaks every single language listed, so my guess is that they rely on users such as yourself to assist with translations.
-
you're right to some extent: during development, we only update the english language file. We don't need translations during the development process though, as taking care of them would mean way to much maintenance work. Once we're ready for release, we have a feature freeze and send out the language files to the translators, requesting them to translate. The bottom line is: although we need contributions and appreciate users being willing to help, we don't need language files for the devel version at this stage yet.
I understand your concern and appreciate your willingness to help, but I'd ask you to stop discussion about the devel version on cpg1.3.x threads.
Joachim
-
Question: how do I take Reynold's layout (really slick, imo) and use that for my site?
When I simply upload his files into my directory I get a huge, ugly mess.
Thanks for the help.
-
#1 Download Reynolds them
#2 Unzip/untar it
#3 Upload the entire reynolds directory into the themes directory of your coppermine server
#4 From the Coppermine config - select Reynolds as the theme
#5 Enjoy
-
#1 Download Reynolds them
#2 Unzip/untar it
#3 Upload the entire reynolds directory into the themes directory of your coppermine server
#4 From the Coppermine config - select Reynolds as the theme
#5 Enjoy
Thank you kindly sir - you can see me here: http://www.madeinbc.ca/anvil/index.php
Anyways, a few more newbie questions:
1) How can I put in a "notes" field at the top, below my title but above my first category? Would be super-cool to have one.
2) Can I edit the menu as to have more options, links to sites that I like, etc? Personalize it a bit?
Thanks again! :)
-
Read the documentation - search the forums
-
Anyways, a few more newbie questions:
1) How can I put in a "notes" field at the top, below my title but above my first category? Would be super-cool to have one.
2) Can I edit the menu as to have more options, links to sites that I like, etc? Personalize it a bit?
we have a "one question per thread" policy on this board, especially on a thread that deals with a particular mod/theme. Don't try hijacking this thread. The questions you're asking have been asked and answered very often already, search the board for details/answers.
Joachim
-
Hi
Seems to be a problem with the Reynolds tar file.
Headers not correct
-
Download again and try
-
Tarique.. have your themes been properly updated to include the new changes in cvs? I remember Casper posting the changes that had to be made to the themes to make them work with the new mode.php filename change. Has this or any other changes been incorporated into the themes? Also, has forest been updated as well?
-
I have updated the 2bornot2b and reynolds themes, and posted them for tarique on the dev board.
But imho, we should not release them whilst 1.4 is still in testing stage, as any problems with them would just confuse matters, when we should be concentrating on getting the main application ready for public release.
-
Hi,
i just wanted to tell you, the reynolds theme rocks! It's simple but absolutely smooth.
I'd like to know who did it? Whoever, thankyou for the great work!
I use it on my new gallery http://gallery.mad-d-sign.com I had to modify
it a bit. I replaced all of the fixed divs by a table structure. This prevents the site from
being messed up when the browser window gets too small.
The biggest question for me is, who took the picture of this pen on top??? As you
can see i tried to replace it by a picture of my digicam but the effect is not the same.
So if anyone knows who made the pen picture plz let me know.
regards
Nico
-
That picture has been taken by my wife.
-
Hi,
could you please give me some hints on how to extract such a picture in such
a smooth way but keeping the shadow like you did? Or is that shadow not real?
(I know this does not belong in this thread so if you like plz send a pm or mail...)
Thank you
regards
Nico
-
The shadow is very much real - other than that I do not understand what you are talking about... - Yes please take this thread to Photography Tips & Tricks forum
-
ok, i opened a new thread there...
-
unrelated postings split into separate thread: http://forum.coppermine-gallery.net/index.php?topic=13677.0
-
I had to modify it a bit. I replaced all of the fixed divs by a table structure. This prevents the site from
being messed up when the browser window gets too small.
Nico could you zip up the changes you made to Reynolds and upload them here in a .zip file for others use. I've been running into the same issue as you but not had the time to make the cahnges. What you did sounds like just what I need. I'm sure others are in the same boat.
So if you'd be willing to share, please put up your modded version of Reynolds with the <div> repairs.
Thanks!
~Jeff
-
hello
is it possible to integrate the language selector on the index page to 2B or not 2B theme ?
thank you very much
++ fabrice
-
yes, just place
{LANGUAGE_SELECT_LIST}anywhere in the template file. It was deliberatly left out, as it causes issues with html validation. This has been mentioned before on this thread, please read the whole thread carefully before replying next time.
-
ok , thank you very much
-
2B or not 2B - Demo http://tariquesani.net/?theme=2bornot2b Download: http://tariquesani.net/themes/2bornot2b.tar.gz 24Kb
hi,
have you test on css validator your demo site, if you chose UTF-8 in the Gallery Options?
i get many errors with my cp133 and utf-8 :\'(
bye
torsten
p.s. can i use the download with cp133?
-
please read the whole thread
-
please read the whole thread
sorry, but i can not found in this thread, Tarique Sani have test with UTF-8 ??? ??? ???
Torsten
-
It's mentioned in the thread several times, but I'll repeat it for you: the theme itself is standards compliant, but coppermine v 1.3.x is not. If you're trying to validate your coppermine install with this theme, you'll get validation errors if you run cpg1.3.x no matter what encoding you have selected, as the errors come from coppermine's core code, not the theme. Cpg1.4.x will be the first standards-compliant coppermine version ever (at least we try hard to make it compliant).
-
I love your new themes and especially the fact that your site (and the Danish one) both validate XHTML!
Does that mean you are using version 1.4? (I have read this entire thread but not seen you state anywhere which version you are running.)
So do I have to install version 1.4 in order to validate for XHTML?
If so, how close are we to a stable release?
Thanks!
-
To which posting/site do you refer to?
There are many postings where people ask for a release date for cpg1.4.x as stable, the usual answer is: it will be released when it's ready ;)
Joachim
-
Thanks Joachim,
I was referring to the fellow who started this thread. (I forget his name because it's quite uncommon.)
His gallery looks great and validates XHTML too!
Is he then using vb 1.4 or did he somehow hack 1.3.x to validate? (I was confused since he didn't specify in his first post - or any other post in this thread that I could see.)
Thanks! :)
-
It's mentioned in the thread several times, but I'll repeat it for you...
thank you ::)
-
I was referring to the fellow who started this thread. (I forget his name because it's quite uncommon.)
His gallery looks great and validates XHTML too!
Is he then using vb 1.4 or did he somehow hack 1.3.x to validate? (I was confused since he didn't specify in his first post - or any other post in this thread that I could see.)
Hehe, the guy who started this thread is Dr. Tarique Sani, the lead developer of coppermine. He surely is using cpg1.4.x - probably even a modified version that was customized to fit his needs. That's why his pages validates. You can easily find out what version a site is using by looking at the html output - at the very bottom, the version is printed.
Joachim
-
You can easily find out what version a site is using by looking at the html output - at the very bottom, the version is printed.
Excellent! That is very useful information. Thanks! :)
EDIT: I suppose one reason I was confused, is that this thread is labeled as CPG1.3.X which lead me to believe that 1.3.x could become XHTML compliant. Perhaps the label should be changed to 1.4.x?
-
no, the files posted in this thread are for cpg1.3.x, but as this thread is very old already, Tarique has meanwhile upgraded his site and the themes he is using to cpg1.4.x.
Please note that all coppermine themes that will come with cpg1.4.x will validate as well as the core code (at least we're trying hard to achieve this). Keep in mind that the themes for cpg1.3.x that are discussed here are to be considered experimental, go unsupported. It doesn't make very much sense to have valid themes when the underlying cpg1.3.x core code doesn't validate, so you should consider those themes as "proof of concept" only.